[PATCH 0/7] MIPS: decstation_64_defconfig: Compile the kernel with warnings as errors

[PATCH 0/7] MIPS: decstation_64_defconfig: Compile the kernel with warnings as errors

[WangYuli]

Patchset ("MIPS: dec: Only check -msym32 when need compiler") from list [1]
allows us to compile kernel image packages with decstation_64_defconfig.

However, compilation warnings remain during the build.

Address these warnings and enable CONFIG_WERROR for decstation_64_defconfig.

[1]. https://lore.kernel.org/all/8ABBF323414AEF93+20250217142541.48149-1-wangyuli@uniontech.com/

WangYuli (7):
  MIPS: dec: Declare which_prom() as static
  MIPS: dec: Create reset.h
  MIPS: cevt-ds1287: Add missing ds1287.h include
  MIPS: ds1287: Match ds1287_set_base_clock() function types
  MIPS: dec: Remove dec_irq_dispatch()
  MIPS: decstation_64_defconfig: Update configs dependencies
  MIPS: decstation_64_defconfig: Compile the kernel with warnings as
    errors

 arch/mips/configs/decstation_64_defconfig | 45 +++++++++--------------
 arch/mips/dec/int-handler.S               |  2 +-
 arch/mips/dec/prom/init.c                 |  5 +--
 arch/mips/dec/reset.c                     |  2 +
 arch/mips/dec/setup.c                     | 15 +-------
 arch/mips/include/asm/dec/reset.h         | 17 +++++++++
 arch/mips/include/asm/ds1287.h            |  2 +-
 arch/mips/kernel/cevt-ds1287.c            |  1 +
 8 files changed, 44 insertions(+), 45 deletions(-)
 create mode 100644 arch/mips/include/asm/dec/reset.h

-- 
2.47.2

[PATCH 1/7] MIPS: dec: Declare which_prom() as static

[WangYuli]

Declare which_prom() as static to suppress gcc compiler warning that
'missing-prototypes'. This function is not intended to be called
from other parts.

Fix follow error with gcc-14 when -Werror:

arch/mips/dec/prom/init.c:45:13: error: no previous prototype for ‘which_prom’ [-Werror=missing-prototypes]
   45 | void __init which_prom(s32 magic, s32 *prom_vec)
      |             ^~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [scripts/Makefile.build:207: arch/mips/dec/prom/init.o] Error 1
make[5]: *** [scripts/Makefile.build:465: arch/mips/dec/prom] Error 2
make[5]: *** Waiting for unfinished jobs....

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/dec/prom/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/dec/prom/init.c b/arch/mips/dec/prom/init.c
index cb12eb211a49..8d74d7d6c05b 100644
--- a/arch/mips/dec/prom/init.c
+++ b/arch/mips/dec/prom/init.c
@@ -42,7 +42,7 @@ int (*__pmax_close)(int);
  * Detect which PROM the DECSTATION has, and set the callback vectors
  * appropriately.
  */
-void __init which_prom(s32 magic, s32 *prom_vec)
+static void __init which_prom(s32 magic, s32 *prom_vec)
 {
 	/*
 	 * No sign of the REX PROM's magic number means we assume a non-REX
-- 
2.47.2

[PATCH 2/7] MIPS: dec: Create reset.h

[WangYuli]

Declare externally used functions in reset.c to resolve compilation
warnings.

Fix follow errors with gcc-14 when -Werror:

arch/mips/dec/reset.c:22:17: error: no previous prototype for ‘dec_machine_restart’ [-Werror=missing-prototypes]
   22 | void __noreturn dec_machine_restart(char *command)
      |                 ^~~~~~~~~~~~~~~~~~~
arch/mips/dec/reset.c:27:17: error: no previous prototype for ‘dec_machine_halt’ [-Werror=missing-prototypes]
   27 | void __noreturn dec_machine_halt(void)
      |                 ^~~~~~~~~~~~~~~~
arch/mips/dec/reset.c:32:17: error: no previous prototype for ‘dec_machine_power_off’ [-Werror=missing-prototypes]
   32 | void __noreturn dec_machine_power_off(void)
      |                 ^~~~~~~~~~~~~~~~~~~~~
arch/mips/dec/reset.c:38:13: error: no previous prototype for ‘dec_intr_halt’ [-Werror=missing-prototypes]
   38 | irqreturn_t dec_intr_halt(int irq, void *dev_id)
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[7]: *** [scripts/Makefile.build:207: arch/mips/dec/reset.o] Error 1
make[7]: *** Waiting for unfinished jobs....

In passing, also correct the include file ordering in setup.c as it
doesn't merit a separate commit.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/dec/prom/init.c         |  3 +--
 arch/mips/dec/reset.c             |  2 ++
 arch/mips/dec/setup.c             |  9 ++-------
 arch/mips/include/asm/dec/reset.h | 17 +++++++++++++++++
 4 files changed, 22 insertions(+), 9 deletions(-)
 create mode 100644 arch/mips/include/asm/dec/reset.h

diff --git a/arch/mips/dec/prom/init.c b/arch/mips/dec/prom/init.c
index 8d74d7d6c05b..a8393052a443 100644
--- a/arch/mips/dec/prom/init.c
+++ b/arch/mips/dec/prom/init.c
@@ -18,7 +18,7 @@
 #include <asm/processor.h>
 
 #include <asm/dec/prom.h>
-
+#include <asm/dec/reset.h>
 
 int (*__rex_bootinit)(void);
 int (*__rex_bootread)(void);
@@ -88,7 +88,6 @@ static void __init which_prom(s32 magic, s32 *prom_vec)
 
 void __init prom_init(void)
 {
-	extern void dec_machine_halt(void);
 	static const char cpu_msg[] __initconst =
 		"Sorry, this kernel is compiled for a wrong CPU type!\n";
 	s32 argc = fw_arg0;
diff --git a/arch/mips/dec/reset.c b/arch/mips/dec/reset.c
index 3df01f1da347..ee1ad38f4a69 100644
--- a/arch/mips/dec/reset.c
+++ b/arch/mips/dec/reset.c
@@ -10,6 +10,8 @@
 
 #include <asm/addrspace.h>
 
+#include <asm/dec/reset.h>
+
 typedef void __noreturn (* noret_func_t)(void);
 
 static inline void __noreturn back_to_prom(void)
diff --git a/arch/mips/dec/setup.c b/arch/mips/dec/setup.c
index 87f0a1436bf9..56a7ecf06b7b 100644
--- a/arch/mips/dec/setup.c
+++ b/arch/mips/dec/setup.c
@@ -17,11 +17,11 @@
 #include <linux/irqnr.h>
 #include <linux/memblock.h>
 #include <linux/param.h>
+#include <linux/pm.h>
 #include <linux/percpu-defs.h>
 #include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/types.h>
-#include <linux/pm.h>
 
 #include <asm/addrspace.h>
 #include <asm/bootinfo.h>
@@ -48,14 +48,9 @@
 #include <asm/dec/kn02ca.h>
 #include <asm/dec/kn03.h>
 #include <asm/dec/kn230.h>
+#include <asm/dec/reset.h>
 #include <asm/dec/system.h>
 
-
-extern void dec_machine_restart(char *command);
-extern void dec_machine_halt(void);
-extern void dec_machine_power_off(void);
-extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
-
 unsigned long dec_kn_slot_base, dec_kn_slot_size;
 
 EXPORT_SYMBOL(dec_kn_slot_base);
diff --git a/arch/mips/include/asm/dec/reset.h b/arch/mips/include/asm/dec/reset.h
new file mode 100644
index 000000000000..5e7b27561fbe
--- /dev/null
+++ b/arch/mips/include/asm/dec/reset.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Reset a DECstation machine.
+ *
+ * Copyright (C) 2025  WangYuli
+ */
+
+#ifndef __ASM_DEC_RESET_H
+
+#include <linux/interrupt.h>
+
+extern void __noreturn dec_machine_restart(char *command);
+extern void __noreturn dec_machine_halt(void);
+extern void __noreturn dec_machine_power_off(void);
+extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
+
+#endif /* __ASM_DEC_RESET_H */
-- 
2.47.2

[PATCH 3/7] MIPS: cevt-ds1287: Add missing ds1287.h include

[WangYuli]

Address the issue of cevt-ds1287.c not including the ds1287.h header
file.

Fix follow errors with gcc-14 when -Werror:

arch/mips/kernel/cevt-ds1287.c:15:5: error: no previous prototype for ‘ds1287_timer_state’ [-Werror=missing-prototypes]
   15 | int ds1287_timer_state(void)
      |     ^~~~~~~~~~~~~~~~~~
arch/mips/kernel/cevt-ds1287.c:20:5: error: no previous prototype for ‘ds1287_set_base_clock’ [-Werror=missing-prototypes]
   20 | int ds1287_set_base_clock(unsigned int hz)
      |     ^~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/cevt-ds1287.c:103:12: error: no previous prototype for ‘ds1287_clockevent_init’ [-Werror=missing-prototypes]
  103 | int __init ds1287_clockevent_init(int irq)
      |            ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
make[7]: *** Waiting for unfinished jobs....
make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
make[6]: *** Waiting for unfinished jobs....

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/kernel/cevt-ds1287.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/kernel/cevt-ds1287.c b/arch/mips/kernel/cevt-ds1287.c
index 9a47fbcd4638..de64d6bb7ba3 100644
--- a/arch/mips/kernel/cevt-ds1287.c
+++ b/arch/mips/kernel/cevt-ds1287.c
@@ -10,6 +10,7 @@
 #include <linux/mc146818rtc.h>
 #include <linux/irq.h>
 
+#include <asm/ds1287.h>
 #include <asm/time.h>
 
 int ds1287_timer_state(void)
-- 
2.47.2

[PATCH 4/7] MIPS: ds1287: Match ds1287_set_base_clock() function types

[WangYuli]

Synchronize the declaration of ds1287_set_base_clock() between
cevt-ds1287.c and ds1287.h.

Fix follow error with gcc-14 when -Werror:

arch/mips/kernel/cevt-ds1287.c:21:5: error: conflicting types for ‘ds1287_set_base_clock’; have ‘int(unsigned int)’
   21 | int ds1287_set_base_clock(unsigned int hz)
      |     ^~~~~~~~~~~~~~~~~~~~~
In file included from arch/mips/kernel/cevt-ds1287.c:13:
./arch/mips/include/asm/ds1287.h:11:13: note: previous declaration of ‘ds1287_set_base_clock’ with type ‘void(unsigned int)’
   11 | extern void ds1287_set_base_clock(unsigned int clock);
      |             ^~~~~~~~~~~~~~~~~~~~~
make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
make[6]: *** Waiting for unfinished jobs....

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/include/asm/ds1287.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/ds1287.h b/arch/mips/include/asm/ds1287.h
index 46cfb01f9a14..51cb61fd4c03 100644
--- a/arch/mips/include/asm/ds1287.h
+++ b/arch/mips/include/asm/ds1287.h
@@ -8,7 +8,7 @@
 #define __ASM_DS1287_H
 
 extern int ds1287_timer_state(void);
-extern void ds1287_set_base_clock(unsigned int clock);
+extern int ds1287_set_base_clock(unsigned int hz);
 extern int ds1287_clockevent_init(int irq);
 
 #endif
-- 
2.47.2

[PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

[WangYuli]

Currently, dec_irq_dispatch() is exclusively invoked by int-handler.S.
Inline the do_IRQ call into int-handler.S to silence the compiler
warning.

Fix follow error with gcc-14 when -Werror:

arch/mips/dec/setup.c:780:25: error: no previous prototype for ‘dec_irq_dispatch’ [-Werror=missing-prototypes]
  780 | asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
      |                         ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[7]: *** [scripts/Makefile.build:207: arch/mips/dec/setup.o] Error 1
make[6]: *** [scripts/Makefile.build:465: arch/mips/dec] Error 2
make[5]: *** [scripts/Makefile.build:465: arch/mips] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [Makefile:1992: .] Error 2
make[3]: *** [debian/rules:74: build-arch] Error 2
dpkg-buildpackage: error: make -f debian/rules binary subprocess returned exit status 2
make[2]: *** [scripts/Makefile.package:126: bindeb-pkg] Error 2
make[1]: *** [/mnt/83364c87-f5ee-4ae8-b862-930f1bd74feb/Projects/CommitUpstream/LinuxKernel/Temp/linux/Makefile:1625: bindeb-pkg] Error 2
make: *** [Makefile:251: __sub-make] Error 2

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/dec/int-handler.S | 2 +-
 arch/mips/dec/setup.c       | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/mips/dec/int-handler.S b/arch/mips/dec/int-handler.S
index 011d1d678840..a0b439c90488 100644
--- a/arch/mips/dec/int-handler.S
+++ b/arch/mips/dec/int-handler.S
@@ -277,7 +277,7 @@
 		 srlv	t3,t1,t2
 
 handle_it:
-		j	dec_irq_dispatch
+		j	do_IRQ
 		 nop
 
 #if defined(CONFIG_32BIT) && defined(CONFIG_MIPS_FP_SUPPORT)
diff --git a/arch/mips/dec/setup.c b/arch/mips/dec/setup.c
index 56a7ecf06b7b..6ba4c4973c9a 100644
--- a/arch/mips/dec/setup.c
+++ b/arch/mips/dec/setup.c
@@ -771,9 +771,3 @@ void __init arch_init_irq(void)
 			pr_err("Failed to register halt interrupt\n");
 	}
 }
-
-asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
-{
-	do_IRQ(irq);
-	return 0;
-}
-- 
2.47.2

[PATCH 6/7] MIPS: decstation_64_defconfig: Update configs dependencies

[WangYuli]

Due to long-term changes in kernel build configurations,
run 'make savedefconfig' to update the build configuration
dependencies.

This commit does not affect the actual .config file content,
in preparation for future modifications to decstation_64_defconfig.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/configs/decstation_64_defconfig | 44 +++++++++--------------
 1 file changed, 17 insertions(+), 27 deletions(-)

diff --git a/arch/mips/configs/decstation_64_defconfig b/arch/mips/configs/decstation_64_defconfig
index da51b9731db0..cf8e72164e40 100644
--- a/arch/mips/configs/decstation_64_defconfig
+++ b/arch/mips/configs/decstation_64_defconfig
@@ -1,27 +1,27 @@
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 CONFIG_HIGH_RES_TIMERS=y
+CONFIG_BPF_SYSCALL=y
 CONFIG_BSD_PROCESS_ACCT=y
 CONFIG_BSD_PROCESS_ACCT_V3=y
 CONFIG_LOG_BUF_SHIFT=15
 CONFIG_EXPERT=y
 # CONFIG_SGETMASK_SYSCALL is not set
 # CONFIG_SYSFS_SYSCALL is not set
-CONFIG_BPF_SYSCALL=y
-# CONFIG_COMPAT_BRK is not set
 CONFIG_MACH_DECSTATION=y
 CONFIG_64BIT=y
-CONFIG_PAGE_SIZE_16KB=y
 CONFIG_TC=y
 CONFIG_MIPS32_O32=y
 CONFIG_MIPS32_N32=y
 # CONFIG_SUSPEND is not set
+CONFIG_PAGE_SIZE_16KB=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_MODULE_SRCVERSION_ALL=y
 CONFIG_PARTITION_ADVANCED=y
 CONFIG_OSF_PARTITION=y
 # CONFIG_EFI_PARTITION is not set
+# CONFIG_COMPAT_BRK is not set
 CONFIG_TRANSPARENT_HUGEPAGE=y
 CONFIG_NET=y
 CONFIG_PACKET=y
@@ -49,7 +49,6 @@ CONFIG_NETWORK_SECMARK=y
 CONFIG_IP_SCTP=m
 CONFIG_VLAN_8021Q=m
 # CONFIG_WIRELESS is not set
-# CONFIG_UEVENT_HELPER is not set
 # CONFIG_FW_LOADER is not set
 # CONFIG_ALLOW_DEV_COREDUMP is not set
 CONFIG_MTD=m
@@ -83,9 +82,9 @@ CONFIG_DECLANCE=y
 # CONFIG_NET_VENDOR_MICREL is not set
 # CONFIG_NET_VENDOR_MICROCHIP is not set
 # CONFIG_NET_VENDOR_MICROSEMI is not set
+# CONFIG_NET_VENDOR_NI is not set
 # CONFIG_NET_VENDOR_NATSEMI is not set
 # CONFIG_NET_VENDOR_NETRONOME is not set
-# CONFIG_NET_VENDOR_NI is not set
 # CONFIG_NET_VENDOR_QUALCOMM is not set
 # CONFIG_NET_VENDOR_RENESAS is not set
 # CONFIG_NET_VENDOR_ROCKER is not set
@@ -114,7 +113,6 @@ CONFIG_FB_TGA=y
 CONFIG_FB_PMAG_AA=y
 CONFIG_FB_PMAG_BA=y
 CONFIG_FB_PMAGB_B=y
-# CONFIG_VGA_CONSOLE is not set
 CONFIG_DUMMY_CONSOLE_COLUMNS=160
 CONFIG_DUMMY_CONSOLE_ROWS=64
 CONFIG_FRAMEBUFFER_CONSOLE=y
@@ -167,37 +165,29 @@ CONFIG_NLS_ISO8859_13=m
 CONFIG_NLS_ISO8859_14=m
 CONFIG_NLS_ISO8859_15=m
 CONFIG_NLS_UTF8=m
-CONFIG_CRYPTO_RSA=m
 CONFIG_CRYPTO_MANAGER=y
-CONFIG_CRYPTO_CCM=m
-CONFIG_CRYPTO_GCM=m
-CONFIG_CRYPTO_CHACHA20POLY1305=m
+CONFIG_CRYPTO_RSA=m
+CONFIG_CRYPTO_BLOWFISH=m
+CONFIG_CRYPTO_CAMELLIA=m
+CONFIG_CRYPTO_CAST5=m
+CONFIG_CRYPTO_CAST6=m
+CONFIG_CRYPTO_FCRYPT=m
+CONFIG_CRYPTO_SERPENT=m
+CONFIG_CRYPTO_TWOFISH=m
 CONFIG_CRYPTO_CTS=m
 CONFIG_CRYPTO_LRW=m
-CONFIG_CRYPTO_OFB=m
 CONFIG_CRYPTO_PCBC=m
 CONFIG_CRYPTO_XTS=m
+CONFIG_CRYPTO_CHACHA20POLY1305=m
+CONFIG_CRYPTO_CCM=m
 CONFIG_CRYPTO_CMAC=m
-CONFIG_CRYPTO_XCBC=m
-CONFIG_CRYPTO_CRC32=m
-CONFIG_CRYPTO_CRCT10DIF=m
 CONFIG_CRYPTO_MD4=m
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_RMD160=m
-CONFIG_CRYPTO_SHA512=m
 CONFIG_CRYPTO_WP512=m
-CONFIG_CRYPTO_ANUBIS=m
-CONFIG_CRYPTO_ARC4=m
-CONFIG_CRYPTO_BLOWFISH=m
-CONFIG_CRYPTO_CAMELLIA=m
-CONFIG_CRYPTO_CAST5=m
-CONFIG_CRYPTO_CAST6=m
-CONFIG_CRYPTO_FCRYPT=m
-CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SEED=m
-CONFIG_CRYPTO_SERPENT=m
-CONFIG_CRYPTO_TEA=m
-CONFIG_CRYPTO_TWOFISH=m
+CONFIG_CRYPTO_XCBC=m
+CONFIG_CRYPTO_CRC32=m
+CONFIG_CRYPTO_CRCT10DIF=m
 CONFIG_CRYPTO_LZO=m
 CONFIG_CRYPTO_842=m
 CONFIG_CRYPTO_LZ4=m
-- 
2.47.2

[PATCH 7/7] MIPS: decstation_64_defconfig: Compile the kernel with warnings as errors

[WangYuli]

All compilation issues under decstation_64_defconfig have been
resolved, and it is now safe to enable CONFIG_WERROR now.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/configs/decstation_64_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/configs/decstation_64_defconfig b/arch/mips/configs/decstation_64_defconfig
index cf8e72164e40..66bf399bbd66 100644
--- a/arch/mips/configs/decstation_64_defconfig
+++ b/arch/mips/configs/decstation_64_defconfig
@@ -1,3 +1,4 @@
+CONFIG_WERROR=y
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 CONFIG_HIGH_RES_TIMERS=y
-- 
2.47.2

Re: [PATCH 2/7] MIPS: dec: Create reset.h

[Thomas Bogendoerfer]

On Tue, Feb 18, 2025 at 08:56:33PM +0800, WangYuli wrote:
> Declare externally used functions in reset.c to resolve compilation
> warnings.
> [...] 
> -
> -extern void dec_machine_restart(char *command);
> -extern void dec_machine_halt(void);
> -extern void dec_machine_power_off(void);
> -extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
> -
>  unsigned long dec_kn_slot_base, dec_kn_slot_size;
>  
>  EXPORT_SYMBOL(dec_kn_slot_base);
> diff --git a/arch/mips/include/asm/dec/reset.h b/arch/mips/include/asm/dec/reset.h
> new file mode 100644
> index 000000000000..5e7b27561fbe
> --- /dev/null
> +++ b/arch/mips/include/asm/dec/reset.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Reset a DECstation machine.
> + *
> + * Copyright (C) 2025  WangYuli

I don't think this copyright is appropriate, you are only moving code
you haven't written.

Thomas.

> + */
> +
> +#ifndef __ASM_DEC_RESET_H
> +
> +#include <linux/interrupt.h>
> +
> +extern void __noreturn dec_machine_restart(char *command);
> +extern void __noreturn dec_machine_halt(void);
> +extern void __noreturn dec_machine_power_off(void);
> +extern irqreturn_t dec_intr_halt(int irq, void *dev_id);
> +
> +#endif /* __ASM_DEC_RESET_H */

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 1/7] MIPS: dec: Declare which_prom() as static

[Thomas Bogendoerfer]

On Tue, Feb 18, 2025 at 08:54:31PM +0800, WangYuli wrote:
> Declare which_prom() as static to suppress gcc compiler warning that
> 'missing-prototypes'. This function is not intended to be called
> from other parts.
> 
> Fix follow error with gcc-14 when -Werror:
> 
> arch/mips/dec/prom/init.c:45:13: error: no previous prototype for ‘which_prom’ [-Werror=missing-prototypes]
>    45 | void __init which_prom(s32 magic, s32 *prom_vec)
>       |             ^~~~~~~~~~
> cc1: all warnings being treated as errors
> make[6]: *** [scripts/Makefile.build:207: arch/mips/dec/prom/init.o] Error 1
> make[5]: *** [scripts/Makefile.build:465: arch/mips/dec/prom] Error 2
> make[5]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/mips/dec/prom/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/dec/prom/init.c b/arch/mips/dec/prom/init.c
> index cb12eb211a49..8d74d7d6c05b 100644
> --- a/arch/mips/dec/prom/init.c
> +++ b/arch/mips/dec/prom/init.c
> @@ -42,7 +42,7 @@ int (*__pmax_close)(int);
>   * Detect which PROM the DECSTATION has, and set the callback vectors
>   * appropriately.
>   */
> -void __init which_prom(s32 magic, s32 *prom_vec)
> +static void __init which_prom(s32 magic, s32 *prom_vec)
>  {
>  	/*
>  	 * No sign of the REX PROM's magic number means we assume a non-REX
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 3/7] MIPS: cevt-ds1287: Add missing ds1287.h include

[Thomas Bogendoerfer]

On Tue, Feb 18, 2025 at 08:57:23PM +0800, WangYuli wrote:
> Address the issue of cevt-ds1287.c not including the ds1287.h header
> file.
> 
> Fix follow errors with gcc-14 when -Werror:
> 
> arch/mips/kernel/cevt-ds1287.c:15:5: error: no previous prototype for ‘ds1287_timer_state’ [-Werror=missing-prototypes]
>    15 | int ds1287_timer_state(void)
>       |     ^~~~~~~~~~~~~~~~~~
> arch/mips/kernel/cevt-ds1287.c:20:5: error: no previous prototype for ‘ds1287_set_base_clock’ [-Werror=missing-prototypes]
>    20 | int ds1287_set_base_clock(unsigned int hz)
>       |     ^~~~~~~~~~~~~~~~~~~~~
> arch/mips/kernel/cevt-ds1287.c:103:12: error: no previous prototype for ‘ds1287_clockevent_init’ [-Werror=missing-prototypes]
>   103 | int __init ds1287_clockevent_init(int irq)
>       |            ^~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
> make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
> make[6]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/mips/kernel/cevt-ds1287.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kernel/cevt-ds1287.c b/arch/mips/kernel/cevt-ds1287.c
> index 9a47fbcd4638..de64d6bb7ba3 100644
> --- a/arch/mips/kernel/cevt-ds1287.c
> +++ b/arch/mips/kernel/cevt-ds1287.c
> @@ -10,6 +10,7 @@
>  #include <linux/mc146818rtc.h>
>  #include <linux/irq.h>
>  
> +#include <asm/ds1287.h>
>  #include <asm/time.h>
>  
>  int ds1287_timer_state(void)
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 4/7] MIPS: ds1287: Match ds1287_set_base_clock() function types

[Thomas Bogendoerfer]

On Tue, Feb 18, 2025 at 08:57:55PM +0800, WangYuli wrote:
> Synchronize the declaration of ds1287_set_base_clock() between
> cevt-ds1287.c and ds1287.h.
> 
> Fix follow error with gcc-14 when -Werror:
> 
> arch/mips/kernel/cevt-ds1287.c:21:5: error: conflicting types for ‘ds1287_set_base_clock’; have ‘int(unsigned int)’
>    21 | int ds1287_set_base_clock(unsigned int hz)
>       |     ^~~~~~~~~~~~~~~~~~~~~
> In file included from arch/mips/kernel/cevt-ds1287.c:13:
> ./arch/mips/include/asm/ds1287.h:11:13: note: previous declaration of ‘ds1287_set_base_clock’ with type ‘void(unsigned int)’
>    11 | extern void ds1287_set_base_clock(unsigned int clock);
>       |             ^~~~~~~~~~~~~~~~~~~~~
> make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
> make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
> make[6]: *** Waiting for unfinished jobs....
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/mips/include/asm/ds1287.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/ds1287.h b/arch/mips/include/asm/ds1287.h
> index 46cfb01f9a14..51cb61fd4c03 100644
> --- a/arch/mips/include/asm/ds1287.h
> +++ b/arch/mips/include/asm/ds1287.h
> @@ -8,7 +8,7 @@
>  #define __ASM_DS1287_H
>  
>  extern int ds1287_timer_state(void);
> -extern void ds1287_set_base_clock(unsigned int clock);
> +extern int ds1287_set_base_clock(unsigned int hz);
>  extern int ds1287_clockevent_init(int irq);
>  
>  #endif
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

[Thomas Bogendoerfer]

On Tue, Feb 18, 2025 at 08:58:42PM +0800, WangYuli wrote:
> Currently, dec_irq_dispatch() is exclusively invoked by int-handler.S.
> Inline the do_IRQ call into int-handler.S to silence the compiler
> warning.
> 
> Fix follow error with gcc-14 when -Werror:
> 
> arch/mips/dec/setup.c:780:25: error: no previous prototype for ‘dec_irq_dispatch’ [-Werror=missing-prototypes]
>   780 | asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
>       |                         ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[7]: *** [scripts/Makefile.build:207: arch/mips/dec/setup.o] Error 1
> make[6]: *** [scripts/Makefile.build:465: arch/mips/dec] Error 2
> make[5]: *** [scripts/Makefile.build:465: arch/mips] Error 2
> make[5]: *** Waiting for unfinished jobs....
> make[4]: *** [Makefile:1992: .] Error 2
> make[3]: *** [debian/rules:74: build-arch] Error 2
> dpkg-buildpackage: error: make -f debian/rules binary subprocess returned exit status 2
> make[2]: *** [scripts/Makefile.package:126: bindeb-pkg] Error 2
> make[1]: *** [/mnt/83364c87-f5ee-4ae8-b862-930f1bd74feb/Projects/CommitUpstream/LinuxKernel/Temp/linux/Makefile:1625: bindeb-pkg] Error 2
> make: *** [Makefile:251: __sub-make] Error 2
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/mips/dec/int-handler.S | 2 +-
>  arch/mips/dec/setup.c       | 6 ------
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/mips/dec/int-handler.S b/arch/mips/dec/int-handler.S
> index 011d1d678840..a0b439c90488 100644
> --- a/arch/mips/dec/int-handler.S
> +++ b/arch/mips/dec/int-handler.S
> @@ -277,7 +277,7 @@
>  		 srlv	t3,t1,t2
>  
>  handle_it:
> -		j	dec_irq_dispatch
> +		j	do_IRQ
>  		 nop
>  
>  #if defined(CONFIG_32BIT) && defined(CONFIG_MIPS_FP_SUPPORT)
> diff --git a/arch/mips/dec/setup.c b/arch/mips/dec/setup.c
> index 56a7ecf06b7b..6ba4c4973c9a 100644
> --- a/arch/mips/dec/setup.c
> +++ b/arch/mips/dec/setup.c
> @@ -771,9 +771,3 @@ void __init arch_init_irq(void)
>  			pr_err("Failed to register halt interrupt\n");
>  	}
>  }
> -
> -asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
> -{
> -	do_IRQ(irq);
> -	return 0;
> -}
> -- 
> 2.47.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 2/7] MIPS: dec: Create reset.h

[WangYuli]

[-- Attachment #1.1.1: Type: text/plain, Size: 435 bytes --]

Hi, Thomas,

On 2025/2/27 17:45, Thomas Bogendoerfer wrote:
> I don't think this copyright is appropriate, you are only moving code
> you haven't written.
>
> Thomas.
>
I agree with your point.

I just "thought" I should write it that way before.

I can submit a patch v2 to fix this.

Do you think it's better to keep the original copyright in reset.c or 
just remove that line altogether?

Thanks,

-- 
WangYuli

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 645 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

[Maciej W. Rozycki]

On Tue, 18 Feb 2025, WangYuli wrote:

> Currently, dec_irq_dispatch() is exclusively invoked by int-handler.S.

 It always has been, since its inception, see commit 187933f23679 ("[MIPS] 
do_IRQ cleanup").

> Inline the do_IRQ call into int-handler.S to silence the compiler
> warning.

 Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for 
MIPS") `do_IRQ' used to be a macro, that's why.  At the time `do_IRQ' was 
converted to a macro `dec_irq_dispatch' was created and previously this 
place used to call `do_IRQ' too.

 It's always good finding out why things are as they are so as to make 
sure you haven't been missing something.  This cleanup should have been 
made along with commit 8f99a16265353, so it's pretty old a technical debt 
being sorted here.

 Please add these findings to your commit description in v2.

 NB I'm off on holiday starting from tomorrow and I had issues with DEC 
hardware in my lab (now sorted, required a visit on site) so I couldn't 
get to your stuff sooner and also I won't be able to verify any of this 
until I'm back mid-March.

  Maciej

Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

[WangYuli]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1341 bytes --]

Hi Maciej,

On 2025/3/1 00:01, Maciej W. Rozycki wrote:
>   Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for
> MIPS") `do_IRQ' used to be a macro, that's why.  At the time `do_IRQ' was
> converted to a macro `dec_irq_dispatch' was created and previously this
> place used to call `do_IRQ' too.
>
>   It's always good finding out why things are as they are so as to make
> sure you haven't been missing something.  This cleanup should have been
> made along with commit 8f99a16265353, so it's pretty old a technical debt
> being sorted here.
>
>   Please add these findings to your commit description in v2.

Alright, thank you for the correction.

I do see that this commit has already been applied to mips-next.

  If it's alright with you and Thomas, I'm happy to send a patch v2 to 
include these details soon.

>   NB I'm off on holiday starting from tomorrow and I had issues with DEC
> hardware in my lab (now sorted, required a visit on site) so I couldn't
> get to your stuff sooner and also I won't be able to verify any of this
> until I'm back mid-March.
>
>    Maciej

It's a pity I don't have DEC hardware myself, therefore I'm limited to 
using cross-compilation to validate compilation issues.

Nevertheless, have a fantastic holiday!

Thanks,

-- 
WangYuli*
*

[-- Attachment #1.1.1.2: Type: text/html, Size: 2207 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 645 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

[Thomas Bogendoerfer]

On Mon, Mar 03, 2025 at 12:23:13PM +0800, WangYuli wrote:
> Hi Maciej,
> 
> On 2025/3/1 00:01, Maciej W. Rozycki wrote:
> >   Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for
> > MIPS") `do_IRQ' used to be a macro, that's why.  At the time `do_IRQ' was
> > converted to a macro `dec_irq_dispatch' was created and previously this
> > place used to call `do_IRQ' too.
> > 
> >   It's always good finding out why things are as they are so as to make
> > sure you haven't been missing something.  This cleanup should have been
> > made along with commit 8f99a16265353, so it's pretty old a technical debt
> > being sorted here.
> > 
> >   Please add these findings to your commit description in v2.
> 
> Alright, thank you for the correction.
> 
> I do see that this commit has already been applied to mips-next.
> 
>  If it's alright with you and Thomas, I'm happy to send a patch v2 to
> include these details soon.

I'll drop the applied patch and take your v2.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]