From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Rong Qianfeng <rongqianfeng@vivo.com>,
biju.das.jz@bp.renesas.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v4 3/3] i2c: jz4780: Use dev_err_probe()
Date: Mon, 9 Sep 2024 12:16:30 +0300 [thread overview]
Message-ID: <Zt687oWU3I1B-pDI@smile.fi.intel.com> (raw)
In-Reply-To: <aqigucchbgq2tblnu7gdkpiw35ezqbmgbl6a5ptzzezngnihsi@iny4xyzkjyz4>
On Mon, Sep 09, 2024 at 10:23:30AM +0200, Andi Shyti wrote:
> On Tue, Aug 27, 2024 at 11:48:41AM GMT, Rong Qianfeng wrote:
...
> > + struct device *dev = &pdev->dev;
>
> I'm not a big fan of this change. There is not much gain in
> polluting git bisect in order to shorten pdev->dev to a single
> dev.
>
> However, I like the /dev_err/dev_err_probe/.
>
> I will take the first two patches from this series, but I will
> leave this if anyone else has a stronger opinion. If you want,
> you can send just this one patch with just the dev_err_probe()
> change.
Usually I combined this with conversion to dev_err_probe() et al.
so it makes new lines a bit shorter and hence readability a bit better.
On its own it's indeed questionable change.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-09-09 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 3:48 [PATCH v4 0/3] i2c: Use devm_clk_get_enabled() helpers Rong Qianfeng
2024-08-27 3:48 ` [PATCH v4 1/3] i2c: emev2: " Rong Qianfeng
2024-08-27 6:39 ` Geert Uytterhoeven
2024-09-07 19:36 ` Wolfram Sang
2024-08-27 3:48 ` [PATCH v4 2/3] i2c: jz4780: " Rong Qianfeng
2024-08-27 3:48 ` [PATCH v4 3/3] i2c: jz4780: Use dev_err_probe() Rong Qianfeng
2024-09-09 8:23 ` Andi Shyti
2024-09-09 8:58 ` Rong Qianfeng
2024-09-09 19:24 ` Andi Shyti
2024-09-10 2:06 ` Rong Qianfeng
2024-09-09 9:16 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt687oWU3I1B-pDI@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=paul@crapouillou.net \
--cc=rongqianfeng@vivo.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox