From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rong Qianfeng <rongqianfeng@vivo.com>
Cc: andriy.shevchenko@intel.com, biju.das.jz@bp.renesas.com,
Andi Shyti <andi.shyti@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v4 1/3] i2c: emev2: Use devm_clk_get_enabled() helpers
Date: Sat, 7 Sep 2024 21:36:36 +0200 [thread overview]
Message-ID: <ZtyrRLojI8GNiEj0@shikoro> (raw)
In-Reply-To: <20240827034841.4121-2-rongqianfeng@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Tue, Aug 27, 2024 at 11:48:39AM +0800, Rong Qianfeng wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids the calls to clk_disable_unprepare().
>
> While at it, no need to save clk pointer, drop sclk from struct
> em_i2c_device.
>
> Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-09-07 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 3:48 [PATCH v4 0/3] i2c: Use devm_clk_get_enabled() helpers Rong Qianfeng
2024-08-27 3:48 ` [PATCH v4 1/3] i2c: emev2: " Rong Qianfeng
2024-08-27 6:39 ` Geert Uytterhoeven
2024-09-07 19:36 ` Wolfram Sang [this message]
2024-08-27 3:48 ` [PATCH v4 2/3] i2c: jz4780: " Rong Qianfeng
2024-08-27 3:48 ` [PATCH v4 3/3] i2c: jz4780: Use dev_err_probe() Rong Qianfeng
2024-09-09 8:23 ` Andi Shyti
2024-09-09 8:58 ` Rong Qianfeng
2024-09-09 19:24 ` Andi Shyti
2024-09-10 2:06 ` Rong Qianfeng
2024-09-09 9:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtyrRLojI8GNiEj0@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=paul@crapouillou.net \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox