* [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
@ 2020-04-17 7:40 Jason Yan
2020-04-17 10:26 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Jason Yan @ 2020-04-17 7:40 UTC (permalink / raw)
To: f.fainelli, tglx, jason, maz, justinpopo6,
bcm-kernel-feedback-list, linux-mips, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following sparse warning:
drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
'bcm7038_l1_of_init' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/irqchip/irq-bcm7038-l1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
index eb9bce93cd05..fd7c537fb42a 100644
--- a/drivers/irqchip/irq-bcm7038-l1.c
+++ b/drivers/irqchip/irq-bcm7038-l1.c
@@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
.map = bcm7038_l1_map,
};
-int __init bcm7038_l1_of_init(struct device_node *dn,
+static int __init bcm7038_l1_of_init(struct device_node *dn,
struct device_node *parent)
{
struct bcm7038_l1_chip *intc;
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
2020-04-17 7:40 [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static Jason Yan
@ 2020-04-17 10:26 ` Sergei Shtylyov
2020-04-17 10:56 ` Jason Yan
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2020-04-17 10:26 UTC (permalink / raw)
To: Jason Yan, f.fainelli, tglx, jason, maz, justinpopo6,
bcm-kernel-feedback-list, linux-mips, linux-kernel
Cc: Hulk Robot
Hello!
On 17.04.2020 10:40, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
> 'bcm7038_l1_of_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
> index eb9bce93cd05..fd7c537fb42a 100644
> --- a/drivers/irqchip/irq-bcm7038-l1.c
> +++ b/drivers/irqchip/irq-bcm7038-l1.c
> @@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
> .map = bcm7038_l1_map,
> };
>
> -int __init bcm7038_l1_of_init(struct device_node *dn,
> +static int __init bcm7038_l1_of_init(struct device_node *dn,
> struct device_node *parent)
Reindent the above line please, it should start under *struct* on the 1st
line.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
2020-04-17 10:26 ` Sergei Shtylyov
@ 2020-04-17 10:56 ` Jason Yan
2020-04-17 11:07 ` Marc Zyngier
0 siblings, 1 reply; 5+ messages in thread
From: Jason Yan @ 2020-04-17 10:56 UTC (permalink / raw)
To: Sergei Shtylyov, f.fainelli, tglx, jason, maz, justinpopo6,
bcm-kernel-feedback-list, linux-mips, linux-kernel
Cc: Hulk Robot
在 2020/4/17 18:26, Sergei Shtylyov 写道:
> Hello!
>
> On 17.04.2020 10:40, Jason Yan wrote:
>
>> Fix the following sparse warning:
>>
>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>> b/drivers/irqchip/irq-bcm7038-l1.c
>> index eb9bce93cd05..fd7c537fb42a 100644
>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>> bcm7038_l1_domain_ops = {
>> .map = bcm7038_l1_map,
>> };
>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>> struct device_node *parent)
>
> Reindent the above line please, it should start under *struct* on
> the 1st line.
OK, will cook a new one.
>
> [...]
>
> MBR, Sergei
>
> .
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
2020-04-17 10:56 ` Jason Yan
@ 2020-04-17 11:07 ` Marc Zyngier
2020-04-17 11:10 ` Jason Yan
0 siblings, 1 reply; 5+ messages in thread
From: Marc Zyngier @ 2020-04-17 11:07 UTC (permalink / raw)
To: Jason Yan
Cc: Sergei Shtylyov, f.fainelli, tglx, jason, justinpopo6,
bcm-kernel-feedback-list, linux-mips, linux-kernel, Hulk Robot
On 2020-04-17 11:56, Jason Yan wrote:
> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>> Hello!
>>
>> On 17.04.2020 10:40, Jason Yan wrote:
>>
>>> Fix the following sparse warning:
>>>
>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>>> ---
>>> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>> index eb9bce93cd05..fd7c537fb42a 100644
>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>>> bcm7038_l1_domain_ops = {
>>> .map = bcm7038_l1_map,
>>> };
>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>> struct device_node *parent)
>>
>> Reindent the above line please, it should start under *struct* on
>> the 1st line.
>
> OK, will cook a new one.
Please don't bother. I've picked the patch already, and it is on its way
to Linus.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
2020-04-17 11:07 ` Marc Zyngier
@ 2020-04-17 11:10 ` Jason Yan
0 siblings, 0 replies; 5+ messages in thread
From: Jason Yan @ 2020-04-17 11:10 UTC (permalink / raw)
To: Marc Zyngier
Cc: Sergei Shtylyov, f.fainelli, tglx, jason, justinpopo6,
bcm-kernel-feedback-list, linux-mips, linux-kernel, Hulk Robot
在 2020/4/17 19:07, Marc Zyngier 写道:
> On 2020-04-17 11:56, Jason Yan wrote:
>> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>>> Hello!
>>>
>>> On 17.04.2020 10:40, Jason Yan wrote:
>>>
>>>> Fix the following sparse warning:
>>>>
>>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>>>> ---
>>>> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>>> index eb9bce93cd05..fd7c537fb42a 100644
>>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>>>> bcm7038_l1_domain_ops = {
>>>> .map = bcm7038_l1_map,
>>>> };
>>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>> struct device_node *parent)
>>>
>>> Reindent the above line please, it should start under *struct* on
>>> the 1st line.
>>
>> OK, will cook a new one.
>
> Please don't bother. I've picked the patch already, and it is on its way
> to Linus.
>
I have send v2 before I saw this. You can just ignore it.
Thanks,
Jason
> Thanks,
>
> M.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-17 11:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-17 7:40 [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static Jason Yan
2020-04-17 10:26 ` Sergei Shtylyov
2020-04-17 10:56 ` Jason Yan
2020-04-17 11:07 ` Marc Zyngier
2020-04-17 11:10 ` Jason Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox