From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sergey Shtylyov <sergei.shtylyov@gmail.com>
Cc: Felipe Ribeiro de Souza <felipers@ime.usp.br>,
andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
nuno.sa@analog.com, paul@crapouillou.net,
Lucas Ivars Cadima Ciziks <lucas@ciziks.com>,
linux-iio@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: adc: ingenic-adc: refactor ingenic_adc_read_chan_info_raw()
Date: Wed, 22 Apr 2026 23:32:50 +0300 [thread overview]
Message-ID: <aekwcosBXRXgRsPn@ashevche-desk.local> (raw)
In-Reply-To: <e62e3f14-c1fe-45bc-ae9e-760058dfca1d@gmail.com>
On Wed, Apr 22, 2026 at 04:28:24PM +0300, Sergey Shtylyov wrote:
> On 4/22/26 11:41 AM, Andy Shevchenko wrote:
[...]
> >> + dev_err(iio_dev->dev.parent, "Failed to enable clock: %d\n",
> >> + ret);
> >
> > Make it a single line. It's fine to go a bit over 80 for readability purposes.
>
> And BTW the new checkpatch limit is 100 columns. :-)
Yes. But checkpatch has lower priority over documentation. Documentation
clearly says 80 and IIO tries to follow this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-22 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:14 [PATCH v3 0/2] use guard()() to handle synchronisation Felipe Ribeiro de Souza
2026-04-21 22:14 ` [PATCH v3 1/2] iio: adc: ingenic-adc: refactor ingenic_adc_read_chan_info_raw() Felipe Ribeiro de Souza
2026-04-22 8:41 ` Andy Shevchenko
2026-04-22 13:28 ` Sergey Shtylyov
2026-04-22 20:32 ` Andy Shevchenko [this message]
2026-04-21 22:14 ` [PATCH v3 2/2] iio: adc: ingenic-adc: use guard()() to handle synchronisation Felipe Ribeiro de Souza
2026-04-22 8:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aekwcosBXRXgRsPn@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=felipers@ime.usp.br \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lucas@ciziks.com \
--cc=nuno.sa@analog.com \
--cc=paul@crapouillou.net \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox