From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: brgl@kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: RB532: serial: statify setup_serial_port()
Date: Tue, 26 May 2026 16:43:47 +0200 [thread overview]
Message-ID: <ahWxo4OPnCtG970H@alpha.franken.de> (raw)
In-Reply-To: <20260430112410.65986-1-bartosz.golaszewski@oss.qualcomm.com>
On Thu, Apr 30, 2026 at 01:24:10PM +0200, Bartosz Golaszewski wrote:
> This function is not used outside of this compilation unit so make it
> static.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> arch/mips/rb532/serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/rb532/serial.c b/arch/mips/rb532/serial.c
> index 70482540b3dbc..228eff07e5e85 100644
> --- a/arch/mips/rb532/serial.c
> +++ b/arch/mips/rb532/serial.c
> @@ -45,7 +45,7 @@ static struct uart_port rb532_uart = {
> .regshift = 2
> };
>
> -int __init setup_serial_port(void)
> +static int __init setup_serial_port(void)
> {
> rb532_uart.uartclk = idt_cpu_freq;
>
> --
> 2.47.3
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-05-26 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 11:24 [PATCH] MIPS: RB532: serial: statify setup_serial_port() Bartosz Golaszewski
2026-05-26 14:43 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahWxo4OPnCtG970H@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox