Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Dan malek <danm@embeddededge.com>
To: Ulrich Eckhardt <eckhardt@satorlaser.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [patch] some cleanups for Alchemy processors
Date: Mon, 18 Apr 2005 10:45:33 -0400	[thread overview]
Message-ID: <ca4c0616e67fe48cc66f3116afa1a5bc@embeddededge.com> (raw)
In-Reply-To: <200504181137.49593.eckhardt@satorlaser.com>


On Apr 18, 2005, at 5:37 AM, Ulrich Eckhardt wrote:

> -void static inline au_writeb(u8 val, int reg)
> +void static inline au_writeb(u8 val, unsigned long port)
>  {
> -	*(volatile u8 *)(reg) = val;
> +	*(volatile u8 *)(port) = val;

Technically, these are registers, not "ports", so please
don't change their name.  They are memory mapped
registers, as their name implies.

Thanks.


	-- Dan

  parent reply	other threads:[~2005-04-18 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18  9:37 [patch] some cleanups for Alchemy processors Ulrich Eckhardt
2005-04-18 11:54 ` Christoph Hellwig
2005-04-18 14:45 ` Dan malek [this message]
2005-04-18 15:27 ` Ulrich Eckhardt
2005-04-21  5:32   ` Pete Popov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca4c0616e67fe48cc66f3116afa1a5bc@embeddededge.com \
    --to=danm@embeddededge.com \
    --cc=eckhardt@satorlaser.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox