Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH]: you can't use p and p++ without a secuence point
@ 2002-12-19 11:03 Juan Quintela
  0 siblings, 0 replies; only message in thread
From: Juan Quintela @ 2002-12-19 11:03 UTC (permalink / raw)
  To: Ralf Baechle, mipslist


Hi
        using p & p++ without a sequence point in the middle is
        undefined behaviour.  Once there fix the casts also.
        and change == to = as normally == means identity, not
        asignation :(

Later, Juan.

Index: arch/mips/lib/dump_tlb.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/lib/dump_tlb.c,v
retrieving revision 1.8.2.6
diff -u -r1.8.2.6 dump_tlb.c
--- arch/mips/lib/dump_tlb.c	18 Dec 2002 22:47:37 -0000	1.8.2.6
+++ arch/mips/lib/dump_tlb.c	19 Dec 2002 10:38:02 -0000
@@ -225,9 +226,7 @@
 
 	for(i=0;i<8;i++)
 	{
-		printk("*%08lx == %08lx, ",
-		       (unsigned long)p, (unsigned long)*p++);
-		printk("*%08lx == %08lx\n",
-		       (unsigned long)p, (unsigned long)*p++);
+		printk("*%8p = %08lx, ", p, *p); p++;
+		printk("*%8p = %08lx\n", p, *p); p++;
 	}
 }


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-12-19 10:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-19 11:03 [PATCH]: you can't use p and p++ without a secuence point Juan Quintela

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox