* Re: [PATCH] SNI PCIT CPLUS: workaround for messed up PCI irq wiring
From: Ralf Baechle @ 2007-11-08 22:24 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips
In-Reply-To: <20071108210911.GA19753@alpha.franken.de>
On Thu, Nov 08, 2007 at 10:09:11PM +0100, Thomas Bogendoerfer wrote:
> SNI PCIT CPLUS: workaround for messed up irq wiring for onboard PCI bus 1
Oh pleassure.
Thanks & applied,
Ralf
^ permalink raw reply
* [PATCH] SNI PCIT CPLUS: workaround for messed up PCI irq wiring
From: Thomas Bogendoerfer @ 2007-11-08 21:09 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
SNI PCIT CPLUS: workaround for messed up irq wiring for onboard PCI bus 1
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
diff --git a/arch/mips/pci/fixup-sni.c b/arch/mips/pci/fixup-sni.c
index a45bedd..5c8a79b 100644
--- a/arch/mips/pci/fixup-sni.c
+++ b/arch/mips/pci/fixup-sni.c
@@ -113,6 +113,16 @@ static char irq_tab_pcit[13][5] __initdata = {
{ 0, INTA, INTB, INTC, INTD }, /* Slot 5 */
};
+static char irq_tab_pcit_cplus[13][5] __initdata = {
+ /* INTA INTB INTC INTD */
+ { 0, 0, 0, 0, 0 }, /* HOST bridge */
+ { 0, INTB, INTC, INTD, INTA }, /* PCI Slot 9 */
+ { 0, 0, 0, 0, 0 }, /* PCI-EISA */
+ { 0, 0, 0, 0, 0 }, /* Unused */
+ { 0, INTA, INTB, INTC, INTD }, /* PCI-PCI bridge */
+ { 0, INTB, INTC, INTD, INTA }, /* fixup */
+};
+
static inline int is_rm300_revd(void)
{
unsigned char csmsr = *(volatile unsigned char *)PCIMT_CSMSR;
@@ -123,8 +133,19 @@ static inline int is_rm300_revd(void)
int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
{
switch (sni_brd_type) {
- case SNI_BRD_PCI_TOWER:
case SNI_BRD_PCI_TOWER_CPLUS:
+ if (slot == 4) {
+ /*
+ * SNI messed up interrupt wiring for onboard
+ * PCI bus 1; we need to fix this up here
+ */
+ while (dev && dev->bus->number != 1)
+ dev = dev->bus->self;
+ if (dev && dev->devfn >= PCI_DEVFN(4, 0))
+ slot = 5;
+ }
+ return irq_tab_pcit_cplus[slot][pin];
+ case SNI_BRD_PCI_TOWER:
return irq_tab_pcit[slot][pin];
case SNI_BRD_PCI_MTOWER:
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply related
* Re: [PATCH] Put cast inside macro instead of all the callers
From: Maciej W. Rozycki @ 2007-11-08 15:26 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Ulrich Eckhardt, linux-mips
In-Reply-To: <20071101174705.GA23917@linux-mips.org>
On Thu, 1 Nov 2007, Ralf Baechle wrote:
> > I'm not sure if this is always a compile-time constant so that you can adorn
> > it with a LL. However, note that this is not a cast, a cast is at runtime.
>
> No. The compiler can evaluate the cast of a constant value at compile
> time and that exactly is what the code is exploiting here.
Except that some versions of GCC "forget" to stop a warning here as
irrelevant after the cast, hence the need for the stupid "#ifdef", sigh...
> > > if (sp >= (long)CKSEG0 && sp < (long)CKSEG2)
> > > usp = CKSEG1ADDR(sp);
> > > #ifdef CONFIG_64BIT
> > > - else if ((long long)sp >= (long long)PHYS_TO_XKPHYS(0LL, 0) &&
> > > - (long long)sp < (long long)PHYS_TO_XKPHYS(8LL, 0))
> > > - usp = PHYS_TO_XKPHYS((long long)K_CALG_UNCACHED,
> > > + else if ((long long)sp >= (long long)PHYS_TO_XKPHYS(0, 0) &&
> > > + (long long)sp < (long long)PHYS_TO_XKPHYS(8, 0))
> > > + usp = PHYS_TO_XKPHYS(K_CALG_UNCACHED,
> > > XKPHYS_TO_PHYS((long long)sp));
> >
> > I'd say this code is broken in way too many aspects:
> > 1. A plethora of casts. PHYS_TO_XKPHYS() should return a physical address
> > (i.e. 32 or 64 bits unsigned integer) already, so casting its result should
> > not be necessary.
>
> No argument about the beauty of the whole thing.
The casts were an attempt by myself to shut up GCC warning about
comparisons giving a predictable result because of a limited size of the
data type used. Of course this is no longer true with "long long", but
GCC does not care and warns regardless.
A possible workaround would be using auxiliary variables of the "long
long" type, but I recall it making GCC produce worse code for some cases.
I can check it again, since it has been a while, and if a recent version
of GCC produces reasonable code, then I can try to recheck this approach.
Please note this code changes quite wildly depending on the exact
configuration, so chances are GCC may warn with one, but not another.
Maciej
^ permalink raw reply
* [PATCH] MIPS - remove dead config symbols from MIPS code
From: Jiri Olsa @ 2007-11-08 13:28 UTC (permalink / raw)
To: kernel-janitors; +Cc: Andrew Morton, linux-mips, ralf
remove dead config symbols from MIPS code
Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
---
include/asm-mips/pmc-sierra/msp71xx/msp_regs.h | 4 ----
include/asm-mips/sibyte/board.h | 1 -
include/asm-mips/sibyte/swarm.h | 12 ------------
include/asm-mips/sn/addrs.h | 2 --
include/asm-mips/sn/agent.h | 4 +---
include/asm-mips/sn/klconfig.h | 18 +-----------------
6 files changed, 2 insertions(+), 39 deletions(-)
diff --git a/include/asm-mips/pmc-sierra/msp71xx/msp_regs.h b/include/asm-mips/pmc-sierra/msp71xx/msp_regs.h
index 0b56f55..603eb73 100644
--- a/include/asm-mips/pmc-sierra/msp71xx/msp_regs.h
+++ b/include/asm-mips/pmc-sierra/msp71xx/msp_regs.h
@@ -585,11 +585,7 @@
* UART defines *
***************************************************************************
*/
-#ifndef CONFIG_MSP_FPGA
#define MSP_BASE_BAUD 25000000
-#else
-#define MSP_BASE_BAUD 6000000
-#endif
#define MSP_UART_REG_LEN 0x20
/*
diff --git a/include/asm-mips/sibyte/board.h b/include/asm-mips/sibyte/board.h
index da198a1..33028b9 100644
--- a/include/asm-mips/sibyte/board.h
+++ b/include/asm-mips/sibyte/board.h
@@ -20,7 +20,6 @@
#define _SIBYTE_BOARD_H
#if defined(CONFIG_SIBYTE_SWARM) || defined(CONFIG_SIBYTE_PTSWARM) || \
- defined(CONFIG_SIBYTE_PT1120) || defined(CONFIG_SIBYTE_PT1125) || \
defined(CONFIG_SIBYTE_CRHONE) || defined(CONFIG_SIBYTE_CRHINE) || \
defined(CONFIG_SIBYTE_LITTLESUR)
#include <asm/sibyte/swarm.h>
diff --git a/include/asm-mips/sibyte/swarm.h b/include/asm-mips/sibyte/swarm.h
index 540865f..86db37e 100644
--- a/include/asm-mips/sibyte/swarm.h
+++ b/include/asm-mips/sibyte/swarm.h
@@ -32,18 +32,6 @@
#define SIBYTE_HAVE_IDE 1
#define SIBYTE_DEFAULT_CONSOLE "ttyS0,115200"
#endif
-#ifdef CONFIG_SIBYTE_PT1120
-#define SIBYTE_BOARD_NAME "PT1120"
-#define SIBYTE_HAVE_PCMCIA 1
-#define SIBYTE_HAVE_IDE 1
-#define SIBYTE_DEFAULT_CONSOLE "ttyS0,115200"
-#endif
-#ifdef CONFIG_SIBYTE_PT1125
-#define SIBYTE_BOARD_NAME "PT1125"
-#define SIBYTE_HAVE_PCMCIA 1
-#define SIBYTE_HAVE_IDE 1
-#define SIBYTE_DEFAULT_CONSOLE "ttyS0,115200"
-#endif
#ifdef CONFIG_SIBYTE_LITTLESUR
#define SIBYTE_BOARD_NAME "BCM91250C2 (LittleSur)"
#define SIBYTE_HAVE_PCMCIA 0
diff --git a/include/asm-mips/sn/addrs.h b/include/asm-mips/sn/addrs.h
index fec9bdd..bef3049 100644
--- a/include/asm-mips/sn/addrs.h
+++ b/include/asm-mips/sn/addrs.h
@@ -19,8 +19,6 @@
#if defined(CONFIG_SGI_IP27)
#include <asm/sn/sn0/addrs.h>
-#elif defined(CONFIG_SGI_IP35)
-#include <asm/sn/sn1/addrs.h>
#endif
diff --git a/include/asm-mips/sn/agent.h b/include/asm-mips/sn/agent.h
index ac4ea85..62ee456 100644
--- a/include/asm-mips/sn/agent.h
+++ b/include/asm-mips/sn/agent.h
@@ -17,9 +17,7 @@
#if defined(CONFIG_SGI_IP27)
#include <asm/sn/sn0/hub.h>
-#elif defined(CONFIG_SGI_IP35)
-#include <asm/sn/sn1/hub.h>
-#endif /* !CONFIG_SGI_IP27 && !CONFIG_SGI_IP35 */
+#endif /* !CONFIG_SGI_IP27 */
/*
* NIC register macros
diff --git a/include/asm-mips/sn/klconfig.h b/include/asm-mips/sn/klconfig.h
index 96cfd2a..39ddb19 100644
--- a/include/asm-mips/sn/klconfig.h
+++ b/include/asm-mips/sn/klconfig.h
@@ -40,26 +40,10 @@
//#include <sys/graph.h>
//#include <sys/xtalk/xbow.h>
-#elif defined(CONFIG_SGI_IP35)
-
-#include <asm/sn/sn1/addrs.h>
-#include <sys/sn/router.h>
-#include <sys/graph.h>
-#include <asm/xtalk/xbow.h>
-
-#endif /* !CONFIG_SGI_IP27 && !CONFIG_SGI_IP35 */
-
-#if defined(CONFIG_SGI_IP27) || defined(CONFIG_SGI_IP35)
#include <asm/sn/agent.h>
#include <asm/fw/arc/types.h>
#include <asm/fw/arc/hinv.h>
-#if defined(CONFIG_SGI_IP35)
-// The hack file has to be before vector and after sn0_fru....
-#include <asm/hack.h>
-#include <asm/sn/vector.h>
-#include <asm/xtalk/xtalk.h>
-#endif /* CONFIG_SGI_IP35 */
-#endif /* CONFIG_SGI_IP27 || CONFIG_SGI_IP35 */
+#endif /* CONFIG_SGI_IP27 */
typedef u64 nic_t;
^ permalink raw reply related
* Re: [PATCH][au1000] Remove useless EXTRA_CFLAGS
From: Maciej W. Rozycki @ 2007-11-08 11:25 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Florian Fainelli, linux-mips
In-Reply-To: <20071108094708.GA10665@linux-mips.org>
On Thu, 8 Nov 2007, Ralf Baechle wrote:
> > Yeah... If only GCC had no bugs and always had a clue of what to warn
> > about...
>
> The least of all problems.
It depends for whom I suppose. ;-) It is a pain when you have to stretch
your imagination to rewrite a piece of source code GCC warns about unduly
and both keep it readable and not make the generated binary worse...
Especially where configuration-specific macros are involved.
> As of 2.6.20-rc2-git2 we had 137 warnings in MIPS specific code of a total
> of 218 for the kernel and 44 for modules - that's a insane 52%. And people
> happily added more crappy code because they didn't not even _notice_ the
> warnings some of which indeed were bugs.
Well, adding no warnings should be the rule #1 and I can understand it is
easier for you to enforce it by the means of -Werror. ;-)
Maciej
^ permalink raw reply
* Re: [PATCH] IP22: Disable EARLY PRINTK, because it breaks serial console
From: Maciej W. Rozycki @ 2007-11-08 11:12 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: Martin Michlmayr, Ralf Baechle, linux-mips
In-Reply-To: <20071107215423.GA11915@alpha.franken.de>
On Wed, 7 Nov 2007, Thomas Bogendoerfer wrote:
> having a more generic zilog driver with platform backends is quite high on
> my todo list. But I won't make promisses when this happens...
Synchronous and DMA operation is the tough part, at least for the
DECstation. OTOH, such a framework actually exists already as
drivers/net/wan/z85230.[ch], but fitting it into the serial subsystem is a
lot of work as the serial core currently has no notion of synchronous
modes at all. Ultimately you'd like to be able to switch between
asynchronous and synchronous line disciplines on a port by port basis
(possibly including halves of the same chip).
Maciej
^ permalink raw reply
* Re: [PATCH] IP22: Disable EARLY PRINTK, because it breaks serial console
From: Ralf Baechle @ 2007-11-08 9:57 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: Maciej W. Rozycki, Martin Michlmayr, linux-mips
In-Reply-To: <20071107215423.GA11915@alpha.franken.de>
On Wed, Nov 07, 2007 at 10:54:23PM +0100, Thomas Bogendoerfer wrote:
> > Ideally, of course, all the SCC drivers should get merged eventually, but
> > due to subtle (and sometimes broken, as it is the case with the
> > DECstation) differences in wiring for various systems it may never really
> > happen, sigh...
>
> having a more generic zilog driver with platform backends is quite high on
> my todo list. But I won't make promisses when this happens...
Right now there are alot of artificial differences between the sun and IP22
8530 drivers by just different prefixes. A good start would already be
to unify all these needless differences which is largely a mechanical job.
Once that is that is it will become easier to spot all the relevant
functional differences - there aren't that many but by now they're well
hidden.
Ralf
^ permalink raw reply
* Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Ralf Baechle @ 2007-11-08 9:48 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-pm, Rafael J. Wysocki, linuxppc-dev, Guennadi Liakhovetski,
Scott Wood, David Howells, linux-mips, Paul Mundt, Bryan Wu,
Russell King
In-Reply-To: <20071107135849.207149000@sipsolutions.net>
On Wed, Nov 07, 2007 at 02:58:00PM +0100, Johannes Berg wrote:
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Cheers,
Ralf
^ permalink raw reply
* Re: [PATCH][au1000] Remove useless EXTRA_CFLAGS
From: Ralf Baechle @ 2007-11-08 9:47 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Florian Fainelli, linux-mips
In-Reply-To: <Pine.LNX.4.64N.0711071239560.14970@blysk.ds.pg.gda.pl>
On Wed, Nov 07, 2007 at 12:41:29PM +0000, Maciej W. Rozycki wrote:
> > And to ensure it will stay that way I'll keep -Werror. It seems only
> > little PITAs like this keep everybody on their toes :-)
>
> Yeah... If only GCC had no bugs and always had a clue of what to warn
> about...
The least of all problems.
As of 2.6.20-rc2-git2 we had 137 warnings in MIPS specific code of a total
of 218 for the kernel and 44 for modules - that's a insane 52%. And people
happily added more crappy code because they didn't not even _notice_ the
warnings some of which indeed were bugs.
Compare to 2.6.23 - 13 warnings for MIPS specific code of a total of 48
warnings and another 23 warnings for all the modules. For a codebase
which overall had grown by half a million lines between those releases.
Ralf
^ permalink raw reply
* Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Paul Mackerras @ 2007-11-08 2:30 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-pm, Bryan Wu, linux-mips, Ralf Baechle, Rafael J. Wysocki,
linuxppc-dev, Paul Mundt, Guennadi Liakhovetski, Russell King
In-Reply-To: <20071107135849.207149000@sipsolutions.net>
Johannes Berg writes:
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
Acked-by: Paul Mackerras <paulus@samba.org>
^ permalink raw reply
* Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Russell King @ 2007-11-07 22:21 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-pm, Rafael J. Wysocki, linuxppc-dev, Guennadi Liakhovetski,
Scott Wood, David Howells, Ralf Baechle, linux-mips, Paul Mundt,
Bryan Wu
In-Reply-To: <20071107135849.207149000@sipsolutions.net>
On Wed, Nov 07, 2007 at 02:58:00PM +0100, Johannes Berg wrote:
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: linuxppc-dev@ozlabs.org
> Cc: linux-pm@lists.linux-foundation.org
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Bryan Wu <bryan.wu@analog.com>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Architecture maintainers should evaluate whether their
> ARCH_SUSPEND_POSSIBLE symbol should be set only under
> stricter circumstances like I've done for powerpc.
>
> Always setting it is not usually a problem, however, since the
> infrastructure is only available for use after suspend_set_ops().
>
> arch/arm/Kconfig | 3 +++
> arch/blackfin/Kconfig | 4 ++++
> arch/frv/Kconfig | 5 +++++
> arch/i386/Kconfig | 4 ++++
> arch/mips/Kconfig | 4 ++++
> arch/powerpc/Kconfig | 4 ++++
> arch/sh/Kconfig | 4 ++++
> arch/x86_64/Kconfig | 3 +++
> kernel/power/Kconfig | 21 +++------------------
> 9 files changed, 34 insertions(+), 18 deletions(-)
>
> --- everything.orig/arch/i386/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/i386/Kconfig 2007-11-07 14:45:28.631515461 +0100
> @@ -1323,3 +1323,7 @@ config KTIME_SCALAR
> config ARCH_HIBERNATION_POSSIBLE
> def_bool y
> depends on !SMP || !X86_VOYAGER
> +
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !X86_VOYAGER
> --- everything.orig/arch/x86_64/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/x86_64/Kconfig 2007-11-07 14:45:28.631515461 +0100
> @@ -716,6 +716,9 @@ menu "Power management options"
>
> source kernel/power/Kconfig
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> +
> config ARCH_HIBERNATION_POSSIBLE
> def_bool y
>
> --- everything.orig/kernel/power/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/kernel/power/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -64,7 +64,7 @@ config PM_TRACE
> config PM_SLEEP_SMP
> bool
> depends on SMP
> - depends on SUSPEND_SMP_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> + depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> depends on PM_SLEEP
> select HOTPLUG_CPU
> default y
> @@ -74,29 +74,14 @@ config PM_SLEEP
> depends on SUSPEND || HIBERNATION
> default y
>
> -config SUSPEND_UP_POSSIBLE
> - bool
> - depends on (X86 && !X86_VOYAGER) || PPC || ARM || BLACKFIN || MIPS \
> - || SUPERH || FRV
> - depends on !SMP
> - default y
> -
> -config SUSPEND_SMP_POSSIBLE
> - bool
> - depends on (X86 && !X86_VOYAGER) \
> - || (PPC && (PPC_PSERIES || PPC_PMAC)) || ARM
> - depends on SMP
> - default y
> -
> config SUSPEND
> bool "Suspend to RAM and standby"
> - depends on PM
> - depends on SUSPEND_UP_POSSIBLE || SUSPEND_SMP_POSSIBLE
> + depends on PM && ARCH_SUSPEND_POSSIBLE
> default y
> ---help---
> Allow the system to enter sleep states in which main memory is
> powered and thus its contents are preserved, such as the
> - suspend-to-RAM state (i.e. the ACPI S3 state).
> + suspend-to-RAM state (e.g. the ACPI S3 state).
>
> config HIBERNATION
> bool "Hibernation (aka 'suspend to disk')"
> --- everything.orig/arch/blackfin/Kconfig 2007-11-07 14:44:55.551521971 +0100
> +++ everything/arch/blackfin/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -993,6 +993,10 @@ endmenu
> menu "Power management options"
> source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> choice
> prompt "Select PM Wakeup Event Source"
> default PM_WAKEUP_GPIO_BY_SIC_IWR
> --- everything.orig/arch/arm/Kconfig 2007-11-07 14:44:55.651522948 +0100
> +++ everything/arch/arm/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -977,6 +977,9 @@ menu "Power management options"
>
> source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> +
> endmenu
>
> source "net/Kconfig"
> --- everything.orig/arch/mips/Kconfig 2007-11-07 14:44:55.701522460 +0100
> +++ everything/arch/mips/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -1999,6 +1999,10 @@ endmenu
>
> menu "Power management options"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source "kernel/power/Kconfig"
>
> endmenu
> --- everything.orig/arch/sh/Kconfig 2007-11-07 14:44:55.801520344 +0100
> +++ everything/arch/sh/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -748,6 +748,10 @@ endmenu
> menu "Power management options (EXPERIMENTAL)"
> depends on EXPERIMENTAL && SYS_SUPPORTS_PM
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source kernel/power/Kconfig
>
> endmenu
> --- everything.orig/arch/frv/Kconfig 2007-11-07 14:44:55.861520941 +0100
> +++ everything/arch/frv/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -357,6 +357,11 @@ source "drivers/pcmcia/Kconfig"
> # should probably wait a while.
>
> menu "Power management options"
> +
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source kernel/power/Kconfig
> endmenu
>
> --- everything.orig/arch/powerpc/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/powerpc/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -155,6 +155,10 @@ config ARCH_HIBERNATION_POSSIBLE
> depends on (PPC64 && HIBERNATE_64) || (PPC32 && HIBERNATE_32)
> default y
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on ADB_PMU || PPC_EFIKA || PPC_LITE5200
> +
> config PPC_DCR_NATIVE
> bool
> default n
>
> --
>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply
* Re: [PATCH] IP22: Disable EARLY PRINTK, because it breaks serial console
From: Thomas Bogendoerfer @ 2007-11-07 21:54 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Martin Michlmayr, Ralf Baechle, linux-mips
In-Reply-To: <Pine.LNX.4.64N.0711071648040.14970@blysk.ds.pg.gda.pl>
On Wed, Nov 07, 2007 at 04:55:10PM +0000, Maciej W. Rozycki wrote:
> On Tue, 30 Oct 2007, Martin Michlmayr wrote:
>
> > * Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2007-09-11 12:44]:
> > > Disable EARLY PRINTK, because it breaks serial console
> >
> > Ralf, at the moment IP22 output stops after "Serial: IP22 Zilog driver
> > (1 chips).". Can you put this patch in until there's a real fix?
>
> Is it by any chance the same problem that I noticed with the DECstation
> and reported in the thread starting at:
it's the same problem
> "http://marc.info/?l=linux-kernel&m=119030963931879&w=2"? If so, there is
> a fix for the DECstation provided somewhere down the discussion which you
> may consider porting to IP22. I think the change to the serial core by
> RMK mentioned there has already been applied upstream.
I ported your fix, but it didn't work for me. Maybe because the
IP22 zilog driver is still a little bit different than the DEC one.
> Ideally, of course, all the SCC drivers should get merged eventually, but
> due to subtle (and sometimes broken, as it is the case with the
> DECstation) differences in wiring for various systems it may never really
> happen, sigh...
having a more generic zilog driver with platform backends is quite high on
my todo list. But I won't make promisses when this happens...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply
* Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Rafael J. Wysocki @ 2007-11-07 22:19 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-pm, linuxppc-dev, Guennadi Liakhovetski, Scott Wood,
David Howells, Ralf Baechle, linux-mips, Paul Mundt, Bryan Wu,
Russell King, Andrew Morton, LKML
In-Reply-To: <20071107135849.207149000@sipsolutions.net>
On Wednesday, 7 of November 2007, Johannes Berg wrote:
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: linuxppc-dev@ozlabs.org
> Cc: linux-pm@lists.linux-foundation.org
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Bryan Wu <bryan.wu@analog.com>
> Cc: Russell King <rmk@arm.linux.org.uk>
> ---
> Architecture maintainers should evaluate whether their
> ARCH_SUSPEND_POSSIBLE symbol should be set only under
> stricter circumstances like I've done for powerpc.
>
> Always setting it is not usually a problem, however, since the
> infrastructure is only available for use after suspend_set_ops().
>
> arch/arm/Kconfig | 3 +++
> arch/blackfin/Kconfig | 4 ++++
> arch/frv/Kconfig | 5 +++++
> arch/i386/Kconfig | 4 ++++
> arch/mips/Kconfig | 4 ++++
> arch/powerpc/Kconfig | 4 ++++
> arch/sh/Kconfig | 4 ++++
> arch/x86_64/Kconfig | 3 +++
> kernel/power/Kconfig | 21 +++------------------
> 9 files changed, 34 insertions(+), 18 deletions(-)
>
> --- everything.orig/arch/i386/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/i386/Kconfig 2007-11-07 14:45:28.631515461 +0100
> @@ -1323,3 +1323,7 @@ config KTIME_SCALAR
> config ARCH_HIBERNATION_POSSIBLE
> def_bool y
> depends on !SMP || !X86_VOYAGER
> +
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !X86_VOYAGER
> --- everything.orig/arch/x86_64/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/x86_64/Kconfig 2007-11-07 14:45:28.631515461 +0100
> @@ -716,6 +716,9 @@ menu "Power management options"
>
> source kernel/power/Kconfig
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> +
> config ARCH_HIBERNATION_POSSIBLE
> def_bool y
>
> --- everything.orig/kernel/power/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/kernel/power/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -64,7 +64,7 @@ config PM_TRACE
> config PM_SLEEP_SMP
> bool
> depends on SMP
> - depends on SUSPEND_SMP_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> + depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> depends on PM_SLEEP
> select HOTPLUG_CPU
> default y
> @@ -74,29 +74,14 @@ config PM_SLEEP
> depends on SUSPEND || HIBERNATION
> default y
>
> -config SUSPEND_UP_POSSIBLE
> - bool
> - depends on (X86 && !X86_VOYAGER) || PPC || ARM || BLACKFIN || MIPS \
> - || SUPERH || FRV
> - depends on !SMP
> - default y
> -
> -config SUSPEND_SMP_POSSIBLE
> - bool
> - depends on (X86 && !X86_VOYAGER) \
> - || (PPC && (PPC_PSERIES || PPC_PMAC)) || ARM
> - depends on SMP
> - default y
> -
> config SUSPEND
> bool "Suspend to RAM and standby"
> - depends on PM
> - depends on SUSPEND_UP_POSSIBLE || SUSPEND_SMP_POSSIBLE
> + depends on PM && ARCH_SUSPEND_POSSIBLE
> default y
> ---help---
> Allow the system to enter sleep states in which main memory is
> powered and thus its contents are preserved, such as the
> - suspend-to-RAM state (i.e. the ACPI S3 state).
> + suspend-to-RAM state (e.g. the ACPI S3 state).
>
> config HIBERNATION
> bool "Hibernation (aka 'suspend to disk')"
> --- everything.orig/arch/blackfin/Kconfig 2007-11-07 14:44:55.551521971 +0100
> +++ everything/arch/blackfin/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -993,6 +993,10 @@ endmenu
> menu "Power management options"
> source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> choice
> prompt "Select PM Wakeup Event Source"
> default PM_WAKEUP_GPIO_BY_SIC_IWR
> --- everything.orig/arch/arm/Kconfig 2007-11-07 14:44:55.651522948 +0100
> +++ everything/arch/arm/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -977,6 +977,9 @@ menu "Power management options"
>
> source "kernel/power/Kconfig"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> +
> endmenu
>
> source "net/Kconfig"
> --- everything.orig/arch/mips/Kconfig 2007-11-07 14:44:55.701522460 +0100
> +++ everything/arch/mips/Kconfig 2007-11-07 14:45:28.641531465 +0100
> @@ -1999,6 +1999,10 @@ endmenu
>
> menu "Power management options"
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source "kernel/power/Kconfig"
>
> endmenu
> --- everything.orig/arch/sh/Kconfig 2007-11-07 14:44:55.801520344 +0100
> +++ everything/arch/sh/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -748,6 +748,10 @@ endmenu
> menu "Power management options (EXPERIMENTAL)"
> depends on EXPERIMENTAL && SYS_SUPPORTS_PM
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source kernel/power/Kconfig
>
> endmenu
> --- everything.orig/arch/frv/Kconfig 2007-11-07 14:44:55.861520941 +0100
> +++ everything/arch/frv/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -357,6 +357,11 @@ source "drivers/pcmcia/Kconfig"
> # should probably wait a while.
>
> menu "Power management options"
> +
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on !SMP
> +
> source kernel/power/Kconfig
> endmenu
>
> --- everything.orig/arch/powerpc/Kconfig 2007-11-07 14:45:28.591544215 +0100
> +++ everything/arch/powerpc/Kconfig 2007-11-07 14:45:28.651528536 +0100
> @@ -155,6 +155,10 @@ config ARCH_HIBERNATION_POSSIBLE
> depends on (PPC64 && HIBERNATE_64) || (PPC32 && HIBERNATE_32)
> default y
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> + depends on ADB_PMU || PPC_EFIKA || PPC_LITE5200
> +
> config PPC_DCR_NATIVE
> bool
> default n
>
--
"Premature optimization is the root of all evil." - Donald Knuth
^ permalink raw reply
* Re: Deleting read-only environment variable on Sibyte board.
From: Ralf Baechle @ 2007-11-07 19:42 UTC (permalink / raw)
To: Manoj Ekbote; +Cc: linux-mips
In-Reply-To: <03235919BBDE634289BB6A0758A20B36025B79F4@NT-SJCA-0751.brcm.ad.broadcom.com>
On Wed, Nov 07, 2007 at 11:36:38AM -0800, Manoj Ekbote wrote:
> It looks like the variable was set with 'setenv -ro' command. This will
> need a manual delete.
> Bad news - This would probably require a new firmware build. There is
> no current command to remove -ro variables (non-existing feature).
I ran over a bit of documentation regarding how variables are stored by
CFE. Looks easy enough to write a little app to convert those variables
to writeable.
Ralf
^ permalink raw reply
* RE: Deleting read-only environment variable on Sibyte board.
From: Manoj Ekbote @ 2007-11-07 19:36 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
In-Reply-To: <20071106222834.GA4079@linux-mips.org>
It looks like the variable was set with 'setenv -ro' command. This will
need a manual delete.
Bad news - This would probably require a new firmware build. There is
no current command to remove -ro variables (non-existing feature).
>-----Original Message-----
>From: Ralf Baechle [mailto:ralf@linux-mips.org]
>Sent: Tuesday, November 06, 2007 2:29 PM
>To: Manoj Ekbote
>Cc: linux-mips@linux-mips.org
>Subject: Re: Deleting read-only environment variable on Sibyte board.
>
>On Tue, Nov 06, 2007 at 12:18:51PM -0800, Manoj Ekbote wrote:
>
>> Hi Ralf,
>>
>> Can you try 'Unsetenv [NAME]'?
>
>I'm getting an error message, something about the variable
>being read-only.
>
>Thanks anyway,
>
> Ralf
>
>
^ permalink raw reply
* Re: Preliminary patch for ip32 ttyS* device
From: Maciej W. Rozycki @ 2007-11-07 17:21 UTC (permalink / raw)
To: Giuseppe Sacco; +Cc: mips kernel list
In-Reply-To: <1194446585.5849.21.camel@scarafaggio>
On Wed, 7 Nov 2007, Giuseppe Sacco wrote:
> I have been investigating about it for one week and I am still not
> convinced that mapbase must be initialised. I tried to understand the
> meaning of mapbase and membase, but I am unsure about the value I should
> set mapbase to.
>
> I learnt that when specifying mapbase its region would be registered and
> reserved using request_mem_region(). Otherwise, if you do not specify
> mapbase, the region is not reserved. Apart from reserving the memory
> region, mapbase isn't use anymore. Is mapbase mandatory?
>
> If mapbase isn't mandatory, the second part of my patch is probably
> right and fixes a bug.
You ought to use mapbase and ioremap() with new code as you are not
allowed to use readb()/writeb()/etc. on addresses obtained otherwise than
by calling ioremap(). The use of request_mem_region(), etc. is not
strictly mandatory, but it is nice to have. Many serial drivers use these
functions, so I cannot see a reason why it would be a hassle for ip32.
Maciej
^ permalink raw reply
* Re: [PATCH] IP22: Disable EARLY PRINTK, because it breaks serial console
From: Maciej W. Rozycki @ 2007-11-07 16:55 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: Ralf Baechle, linux-mips, Thomas Bogendoerfer
In-Reply-To: <20071030073349.GA15984@deprecation.cyrius.com>
On Tue, 30 Oct 2007, Martin Michlmayr wrote:
> * Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2007-09-11 12:44]:
> > Disable EARLY PRINTK, because it breaks serial console
>
> Ralf, at the moment IP22 output stops after "Serial: IP22 Zilog driver
> (1 chips).". Can you put this patch in until there's a real fix?
Is it by any chance the same problem that I noticed with the DECstation
and reported in the thread starting at:
"http://marc.info/?l=linux-kernel&m=119030963931879&w=2"? If so, there is
a fix for the DECstation provided somewhere down the discussion which you
may consider porting to IP22. I think the change to the serial core by
RMK mentioned there has already been applied upstream.
Ideally, of course, all the SCC drivers should get merged eventually, but
due to subtle (and sometimes broken, as it is the case with the
DECstation) differences in wiring for various systems it may never really
happen, sigh...
Maciej
^ permalink raw reply
* Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Paul Mundt @ 2007-11-07 15:13 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-pm, Rafael J. Wysocki, linuxppc-dev, Guennadi Liakhovetski,
Scott Wood, David Howells, Ralf Baechle, linux-mips, Bryan Wu,
Russell King
In-Reply-To: <20071107135849.207149000@sipsolutions.net>
On Wed, Nov 07, 2007 at 02:58:00PM +0100, Johannes Berg wrote:
> This cleans up the suspend Kconfig and removes the need to
> declare centrally which architectures support suspend. All
> architectures that currently support suspend are modified
> accordingly.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: linuxppc-dev@ozlabs.org
> Cc: linux-pm@lists.linux-foundation.org
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Bryan Wu <bryan.wu@analog.com>
> Cc: Russell King <rmk@arm.linux.org.uk>
> ---
> Architecture maintainers should evaluate whether their
> ARCH_SUSPEND_POSSIBLE symbol should be set only under
> stricter circumstances like I've done for powerpc.
>
The SH bits look fine.
Acked-by: Paul Mundt <lethal@linux-sh.org>
^ permalink raw reply
* [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
From: Johannes Berg @ 2007-11-07 13:58 UTC (permalink / raw)
To: linux-pm
Cc: Rafael J. Wysocki, linuxppc-dev, Guennadi Liakhovetski,
Scott Wood, David Howells, Ralf Baechle, linux-mips, Paul Mundt,
Bryan Wu, Russell King
In-Reply-To: <20071107135758.100171000@sipsolutions.net>
[-- Attachment #1: 026-suspend-kconfig-cleanup.patch --]
[-- Type: text/plain, Size: 5478 bytes --]
This cleans up the suspend Kconfig and removes the need to
declare centrally which architectures support suspend. All
architectures that currently support suspend are modified
accordingly.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: linuxppc-dev@ozlabs.org
Cc: linux-pm@lists.linux-foundation.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Scott Wood <scottwood@freescale.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Bryan Wu <bryan.wu@analog.com>
Cc: Russell King <rmk@arm.linux.org.uk>
---
Architecture maintainers should evaluate whether their
ARCH_SUSPEND_POSSIBLE symbol should be set only under
stricter circumstances like I've done for powerpc.
Always setting it is not usually a problem, however, since the
infrastructure is only available for use after suspend_set_ops().
arch/arm/Kconfig | 3 +++
arch/blackfin/Kconfig | 4 ++++
arch/frv/Kconfig | 5 +++++
arch/i386/Kconfig | 4 ++++
arch/mips/Kconfig | 4 ++++
arch/powerpc/Kconfig | 4 ++++
arch/sh/Kconfig | 4 ++++
arch/x86_64/Kconfig | 3 +++
kernel/power/Kconfig | 21 +++------------------
9 files changed, 34 insertions(+), 18 deletions(-)
--- everything.orig/arch/i386/Kconfig 2007-11-07 14:45:28.591544215 +0100
+++ everything/arch/i386/Kconfig 2007-11-07 14:45:28.631515461 +0100
@@ -1323,3 +1323,7 @@ config KTIME_SCALAR
config ARCH_HIBERNATION_POSSIBLE
def_bool y
depends on !SMP || !X86_VOYAGER
+
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on !X86_VOYAGER
--- everything.orig/arch/x86_64/Kconfig 2007-11-07 14:45:28.591544215 +0100
+++ everything/arch/x86_64/Kconfig 2007-11-07 14:45:28.631515461 +0100
@@ -716,6 +716,9 @@ menu "Power management options"
source kernel/power/Kconfig
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+
config ARCH_HIBERNATION_POSSIBLE
def_bool y
--- everything.orig/kernel/power/Kconfig 2007-11-07 14:45:28.591544215 +0100
+++ everything/kernel/power/Kconfig 2007-11-07 14:45:28.641531465 +0100
@@ -64,7 +64,7 @@ config PM_TRACE
config PM_SLEEP_SMP
bool
depends on SMP
- depends on SUSPEND_SMP_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
+ depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
depends on PM_SLEEP
select HOTPLUG_CPU
default y
@@ -74,29 +74,14 @@ config PM_SLEEP
depends on SUSPEND || HIBERNATION
default y
-config SUSPEND_UP_POSSIBLE
- bool
- depends on (X86 && !X86_VOYAGER) || PPC || ARM || BLACKFIN || MIPS \
- || SUPERH || FRV
- depends on !SMP
- default y
-
-config SUSPEND_SMP_POSSIBLE
- bool
- depends on (X86 && !X86_VOYAGER) \
- || (PPC && (PPC_PSERIES || PPC_PMAC)) || ARM
- depends on SMP
- default y
-
config SUSPEND
bool "Suspend to RAM and standby"
- depends on PM
- depends on SUSPEND_UP_POSSIBLE || SUSPEND_SMP_POSSIBLE
+ depends on PM && ARCH_SUSPEND_POSSIBLE
default y
---help---
Allow the system to enter sleep states in which main memory is
powered and thus its contents are preserved, such as the
- suspend-to-RAM state (i.e. the ACPI S3 state).
+ suspend-to-RAM state (e.g. the ACPI S3 state).
config HIBERNATION
bool "Hibernation (aka 'suspend to disk')"
--- everything.orig/arch/blackfin/Kconfig 2007-11-07 14:44:55.551521971 +0100
+++ everything/arch/blackfin/Kconfig 2007-11-07 14:45:28.641531465 +0100
@@ -993,6 +993,10 @@ endmenu
menu "Power management options"
source "kernel/power/Kconfig"
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on !SMP
+
choice
prompt "Select PM Wakeup Event Source"
default PM_WAKEUP_GPIO_BY_SIC_IWR
--- everything.orig/arch/arm/Kconfig 2007-11-07 14:44:55.651522948 +0100
+++ everything/arch/arm/Kconfig 2007-11-07 14:45:28.641531465 +0100
@@ -977,6 +977,9 @@ menu "Power management options"
source "kernel/power/Kconfig"
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+
endmenu
source "net/Kconfig"
--- everything.orig/arch/mips/Kconfig 2007-11-07 14:44:55.701522460 +0100
+++ everything/arch/mips/Kconfig 2007-11-07 14:45:28.641531465 +0100
@@ -1999,6 +1999,10 @@ endmenu
menu "Power management options"
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on !SMP
+
source "kernel/power/Kconfig"
endmenu
--- everything.orig/arch/sh/Kconfig 2007-11-07 14:44:55.801520344 +0100
+++ everything/arch/sh/Kconfig 2007-11-07 14:45:28.651528536 +0100
@@ -748,6 +748,10 @@ endmenu
menu "Power management options (EXPERIMENTAL)"
depends on EXPERIMENTAL && SYS_SUPPORTS_PM
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on !SMP
+
source kernel/power/Kconfig
endmenu
--- everything.orig/arch/frv/Kconfig 2007-11-07 14:44:55.861520941 +0100
+++ everything/arch/frv/Kconfig 2007-11-07 14:45:28.651528536 +0100
@@ -357,6 +357,11 @@ source "drivers/pcmcia/Kconfig"
# should probably wait a while.
menu "Power management options"
+
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on !SMP
+
source kernel/power/Kconfig
endmenu
--- everything.orig/arch/powerpc/Kconfig 2007-11-07 14:45:28.591544215 +0100
+++ everything/arch/powerpc/Kconfig 2007-11-07 14:45:28.651528536 +0100
@@ -155,6 +155,10 @@ config ARCH_HIBERNATION_POSSIBLE
depends on (PPC64 && HIBERNATE_64) || (PPC32 && HIBERNATE_32)
default y
+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+ depends on ADB_PMU || PPC_EFIKA || PPC_LITE5200
+
config PPC_DCR_NATIVE
bool
default n
--
^ permalink raw reply
* Re: Preliminary patch for ip32 ttyS* device
From: Giuseppe Sacco @ 2007-11-07 14:43 UTC (permalink / raw)
To: mips kernel list
In-Reply-To: <20071031130828.GE14187@linux-mips.org>
Il giorno mer, 31/10/2007 alle 13.08 +0000, Ralf Baechle ha scritto:
[...]
> > diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
> > index 3bb5d24..7caa877 100644
> > --- a/drivers/serial/serial_core.c
> > +++ b/drivers/serial/serial_core.c
> > @@ -2455,6 +2455,8 @@ int uart_match_port(struct uart_port *port1, struct uart_port *port2)
> > case UPIO_AU:
> > case UPIO_TSI:
> > case UPIO_DWAPB:
> > + if (port1->mapbase==0 && port2->mapbase==0)
> > + return (port1->membase == port2->membase);
>
> This hack is only needed because ->mapbase is not initialized.
I have been investigating about it for one week and I am still not
convinced that mapbase must be initialised. I tried to understand the
meaning of mapbase and membase, but I am unsure about the value I should
set mapbase to.
I learnt that when specifying mapbase its region would be registered and
reserved using request_mem_region(). Otherwise, if you do not specify
mapbase, the region is not reserved. Apart from reserving the memory
region, mapbase isn't use anymore. Is mapbase mandatory?
If mapbase isn't mandatory, the second part of my patch is probably
right and fixes a bug.
Bye,
Giuseppe
^ permalink raw reply
* Re: WAIT vs. tickless kernel
From: Atsushi Nemoto @ 2007-11-07 14:23 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
In-Reply-To: <20071107.003925.74752709.anemo@mba.ocn.ne.jp>
On Wed, 07 Nov 2007 00:39:25 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> + MFC0 k0, CP0_EPC
> + ori k0, 0x1f /* 32 byte rollback region */
> + xori k0, 0x1f
> + PTR_LA k1, r4k_wait
Well, this part should be like this, for better pipelining.
MFC0 k0, CP0_EPC
PTR_LA k1, r4k_wait
ori k0, 0x1f /* 32 byte rollback region */
xori k0, 0x1f
> + bne k0, k1, 9f
> + MTC0 k0, CP0_EPC
> +9:
And if we could assume branch-likely, this can be:
.set noreorder
beql k0, k1, 9f
MTC0 k0, CP0_EPC
9:
But not sure if it really have points.
> .align 5
> +BUILD_ROLLBACK_PROLOGUE handle_int
> NESTED(handle_int, PT_SIZE, sp)
And one more question: should we put one more ".align 5" just befor
handle_int for CPUs do not need the rollback?
---
Atsushi Nemoto
^ permalink raw reply
* Re: [MIPS] Fix and cleanup the MIPS part of the (ab)use of CLOCK_TICK_RATE.
From: Ralf Baechle @ 2007-11-07 14:17 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips
In-Reply-To: <20071107.231036.75185559.anemo@mba.ocn.ne.jp>
On Wed, Nov 07, 2007 at 11:10:36PM +0900, Atsushi Nemoto wrote:
> The CLOCK_TICK_RATE is used for ACTHZ, TICK_NSEC, etc.
>
> At least for i8253-free platforms, It looks a value multiple of HZ
> would be better for such constants, assuming we have dyntick or
> accurate HZ clockevents.
>
> How about something like this?
>
> diff --git a/include/asm-mips/timex.h b/include/asm-mips/timex.h
> index 5816ad1..e9622b6 100644
> --- a/include/asm-mips/timex.h
> +++ b/include/asm-mips/timex.h
> @@ -18,7 +18,11 @@
> * So keeping it defined to the number for the PIT is the only sane thing
> * for now.
> */
> +#ifdef CONFIG_I8253
> #define CLOCK_TICK_RATE 1193182
> +#else
> +#define CLOCK_TICK_RATE 1024000 /* multiple of HZ */
> +#endif
kernel/time/ntp.c:#define CLOCK_TICK_OVERFLOW (LATCH * HZ - CLOCK_TICK_RATE)
kernel/time/ntp.c: (s64)CLOCK_TICK_RATE)
drivers/char/vt_ioctl.c: arg = CLOCK_TICK_RATE / arg;
drivers/char/vt_ioctl.c: count = CLOCK_TICK_RATE / count;
There is so much abuse of this variable, it's not even funny. It really
deserve to be taken out and shot. And that's just two cases.
Ralf
^ permalink raw reply
* Re: [MIPS] Fix and cleanup the MIPS part of the (ab)use of CLOCK_TICK_RATE.
From: Atsushi Nemoto @ 2007-11-07 14:10 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
In-Reply-To: <S20025770AbXKAPqq/20071101154646Z+4363@ftp.linux-mips.org>
On Thu, 01 Nov 2007 15:46:41 +0000, linux-mips@linux-mips.org wrote:
> Author: Ralf Baechle <ralf@linux-mips.org> Thu Nov 1 15:45:37 2007 +0000
> Commit: 0a354a30fe552b78a4db0873c19d8936551cc158
> Gitweb: http://www.linux-mips.org/g/linux/0a354a30
> Branch: master
>
> This is the clock rate of the i8253 PIT. A MIPS system may not have
> a PIT by the symbol is used all over the kernel including some APIs.
> So keeping it defined to the number for the PIT is the only sane thing
> for now.
The CLOCK_TICK_RATE is used for ACTHZ, TICK_NSEC, etc.
At least for i8253-free platforms, It looks a value multiple of HZ
would be better for such constants, assuming we have dyntick or
accurate HZ clockevents.
How about something like this?
diff --git a/include/asm-mips/timex.h b/include/asm-mips/timex.h
index 5816ad1..e9622b6 100644
--- a/include/asm-mips/timex.h
+++ b/include/asm-mips/timex.h
@@ -18,7 +18,11 @@
* So keeping it defined to the number for the PIT is the only sane thing
* for now.
*/
+#ifdef CONFIG_I8253
#define CLOCK_TICK_RATE 1193182
+#else
+#define CLOCK_TICK_RATE 1024000 /* multiple of HZ */
+#endif
/*
* Standard way to access the cycle counter.
^ permalink raw reply related
* Re: [PATCH][au1000] Remove useless EXTRA_CFLAGS
From: Maciej W. Rozycki @ 2007-11-07 12:41 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Florian Fainelli, linux-mips
In-Reply-To: <20071029151010.GA3953@linux-mips.org>
On Mon, 29 Oct 2007, Ralf Baechle wrote:
> And to ensure it will stay that way I'll keep -Werror. It seems only
> little PITAs like this keep everybody on their toes :-)
Yeah... If only GCC had no bugs and always had a clue of what to warn
about...
Maciej
^ permalink raw reply
* Re: [PATCH] Fix typo in R3000 TRACE_IRQFLAGS code
From: Ralf Baechle @ 2007-11-07 9:43 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips
In-Reply-To: <20071107.010848.37531337.anemo@mba.ocn.ne.jp>
On Wed, Nov 07, 2007 at 01:08:48AM +0900, Atsushi Nemoto wrote:
> Subject: [PATCH] Fix typo in R3000 TRACE_IRQFLAGS code
I guess that's because the last R3000 is still busy compiling a 2.6.0
kernel ;-)
Applied,
Ralf
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox