From: "Kunwu Chan" <kunwu.chan@linux.dev>
To: "SeongJae Park" <sj@kernel.org>
Cc: "SeongJae Park" <sj@kernel.org>,
shuah@kernel.org, damon@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, "Kunwu Chan" <kunwu.chan@gmail.com>,
"Wang Lian" <lianux.mm@gmail.com>,
"Kunwu Chan" <chentao@kylinos.cn>,
"Cheng Nie" <niecheng1@uniontech.com>
Subject: Re: [PATCH 2/5] selftests/damon: fix memcg filter path handling
Date: Mon, 01 Jun 2026 02:19:48 +0000 [thread overview]
Message-ID: <075c80f2482b358705292a2557defdf384c94f7c@linux.dev> (raw)
In-Reply-To: <20260531163607.99063-1-sj@kernel.org>
June 1, 2026 at 12:36 AM, "SeongJae Park" <sj@kernel.org mailto:sj@kernel.org?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > wrote:
>
> Conventionally, this mail should be sent as a direct reply to the coverletter.
> But somehow this was sent as a reply to the first patch of the series. Please
> send all patches of a series as a direct reply to the coverletter from the next
> time.
>
Thanks, SJ.
Sorry about that. I'll make sure future revisions are sent as direct
replies to the cover letter.
> On Sun, 31 May 2026 17:17:21 +0800 Kunwu Chan <kunwu.chan@linux.dev> wrote:
>
> >
> > From: Kunwu Chan <kunwu.chan@gmail.com>
> >
> > A trailing comma in the memcg_path assignment makes
> > memcg_path a single-element tuple instead of a string.
> >
> > As a result, an invalid value is written to sysfs and memcg
> > filter configuration fails.
> >
> > Remove the comma.
> >
> Good findinng! But, Cheng sent [1] a same patch earlier. I believe Cheng is
> working on revisioning it. I think we should give Cheng more time for that.
>
Yes, I noticed that after sending the series and saw that Cheng had
already posted the same fix.
I'll drop this patch from v2 and let Cheng continue with his version.
Thanks,
Kunwu
> [1] https://lore.kernel.org/20260529145248.84593-1-sj@kernel.org
>
> Thanks,
> SJ
>
> [...]
>
next prev parent reply other threads:[~2026-06-01 2:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 8:56 [PATCH 0/5] selftests/damon: misc fixes for test bugs Kunwu Chan
2026-05-31 9:17 ` [PATCH 1/5] selftests/damon: prevent cross-context state pollution in DamonCtx Kunwu Chan
2026-05-31 9:17 ` [PATCH 2/5] selftests/damon: fix memcg filter path handling Kunwu Chan
2026-05-31 16:36 ` SeongJae Park
2026-06-01 2:19 ` Kunwu Chan [this message]
2026-05-31 9:17 ` [PATCH 3/5] selftests/damon/damos_tried_regions: fix expectation output and join TypeError Kunwu Chan
2026-05-31 16:39 ` SeongJae Park
2026-05-31 9:17 ` [PATCH 4/5] selftests/damon/damos_tried_regions: handle empty tried regions in early cycles Kunwu Chan
2026-05-31 16:54 ` SeongJae Park
2026-06-01 2:33 ` Kunwu Chan
2026-05-31 9:17 ` [PATCH 5/5] selftests/damon: fix dead code, skipped checks, and broken lookups Kunwu Chan
2026-05-31 16:59 ` SeongJae Park
2026-05-31 16:30 ` [PATCH 1/5] selftests/damon: prevent cross-context state pollution in DamonCtx SeongJae Park
2026-06-01 2:11 ` Kunwu Chan
2026-05-31 17:08 ` [PATCH 0/5] selftests/damon: misc fixes for test bugs SeongJae Park
2026-06-01 2:38 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075c80f2482b358705292a2557defdf384c94f7c@linux.dev \
--to=kunwu.chan@linux.dev \
--cc=chentao@kylinos.cn \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@gmail.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=niecheng1@uniontech.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox