From: SeongJae Park <sj@kernel.org>
To: Kunwu Chan <kunwu.chan@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
shuah@kernel.org, damon@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Kunwu Chan <kunwu.chan@gmail.com>,
Wang Lian <lianux.mm@gmail.com>, Kunwu Chan <chentao@kylinos.cn>
Subject: Re: [PATCH 3/5] selftests/damon/damos_tried_regions: fix expectation output and join TypeError
Date: Sun, 31 May 2026 09:39:00 -0700 [thread overview]
Message-ID: <20260531163900.99184-1-sj@kernel.org> (raw)
In-Reply-To: <20260531091724.84381-3-kunwu.chan@linux.dev>
On Sun, 31 May 2026 17:17:22 +0800 Kunwu Chan <kunwu.chan@linux.dev> wrote:
> From: Kunwu Chan <kunwu.chan@gmail.com>
>
> The expectation print has wrong operator precedence: '%' binds
> before the conditional expression, so the else branch prints
> 'not met' without the prefix 'expectation (>= 14) is'. Add
> parentheses to fix it.
>
> Also, '\n'.join() on the list of ints raises TypeError;
> convert to str in the list comprehension.
Nice findings and fixes, thank you!
>
> Co-developed-by: Wang Lian <lianux.mm@gmail.com>
> Signed-off-by: Wang Lian <lianux.mm@gmail.com>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
checkpatch.pl may warn here like below, and it should be fixed.
WARNING: From:/Signed-off-by: email address mismatch: 'From: Kunwu Chan <kunwu.chan@gmail.com>' != 'Signed-off-by: Kunwu Chan <chentao@kylinos.cn>'
Other than that,
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-05-31 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 8:56 [PATCH 0/5] selftests/damon: misc fixes for test bugs Kunwu Chan
2026-05-31 9:17 ` [PATCH 1/5] selftests/damon: prevent cross-context state pollution in DamonCtx Kunwu Chan
2026-05-31 9:17 ` [PATCH 2/5] selftests/damon: fix memcg filter path handling Kunwu Chan
2026-05-31 16:36 ` SeongJae Park
2026-06-01 2:19 ` Kunwu Chan
2026-05-31 9:17 ` [PATCH 3/5] selftests/damon/damos_tried_regions: fix expectation output and join TypeError Kunwu Chan
2026-05-31 16:39 ` SeongJae Park [this message]
2026-05-31 9:17 ` [PATCH 4/5] selftests/damon/damos_tried_regions: handle empty tried regions in early cycles Kunwu Chan
2026-05-31 16:54 ` SeongJae Park
2026-06-01 2:33 ` Kunwu Chan
2026-05-31 9:17 ` [PATCH 5/5] selftests/damon: fix dead code, skipped checks, and broken lookups Kunwu Chan
2026-05-31 16:59 ` SeongJae Park
2026-05-31 16:30 ` [PATCH 1/5] selftests/damon: prevent cross-context state pollution in DamonCtx SeongJae Park
2026-06-01 2:11 ` Kunwu Chan
2026-05-31 17:08 ` [PATCH 0/5] selftests/damon: misc fixes for test bugs SeongJae Park
2026-06-01 2:38 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260531163900.99184-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=chentao@kylinos.cn \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@gmail.com \
--cc=kunwu.chan@linux.dev \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox