From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, "Liam R . Howlett" <liam@infradead.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>, Zi Yan <ziy@nvidia.com>
Subject: Re: [PATCH v3 5/6] mm: mincore: improve mincore_hugetlb()
Date: Mon, 20 Jul 2026 10:27:38 +0100 [thread overview]
Message-ID: <133f3f9a-bd3a-432a-afc7-ccecc57d5099@kernel.org> (raw)
In-Reply-To: <20260717091347.1144789-6-wangkefeng.wang@huawei.com>
On 7/17/26 10:13, Kefeng Wang wrote:
> The walk_hugetlb_range() always passes a non-NULL pte, so remove the
> dead NULL check. Replace the per-page iteration loop with memset()
> for better performance.
>
> Reviewed-by: Pedro Falcato <pfalcato@suse.de>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/mincore.c | 27 +++++++--------------------
> 1 file changed, 7 insertions(+), 20 deletions(-)
>
> diff --git a/mm/mincore.c b/mm/mincore.c
> index ba7d1fc320a3..e825d11a7c7e 100644
> --- a/mm/mincore.c
> +++ b/mm/mincore.c
> @@ -28,30 +28,17 @@ static int mincore_hugetlb(pte_t *pte, unsigned long hmask, unsigned long addr,
> unsigned long end, struct mm_walk *walk)
> {
> #ifdef CONFIG_HUGETLB_PAGE
> - unsigned char present;
> + unsigned long nr = (end - addr) >> PAGE_SHIFT;
Can be const.
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-07-20 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260717091347.1144789-1-wangkefeng.wang@huawei.com>
[not found] ` <20260717091347.1144789-2-wangkefeng.wang@huawei.com>
2026-07-20 9:21 ` [PATCH v3 1/6] mm: introduce pud_is_huge() helper David Hildenbrand (Arm)
[not found] ` <20260717091347.1144789-3-wangkefeng.wang@huawei.com>
2026-07-20 9:25 ` [PATCH v3 2/6] mm: mincore: remove special handling for VM_PFNMAP David Hildenbrand (Arm)
2026-07-20 9:26 ` David Hildenbrand (Arm)
2026-07-20 12:41 ` [PATCH v3-fixup 2/6] mm: mincore: fixup for " Kefeng Wang
[not found] ` <20260717091347.1144789-6-wangkefeng.wang@huawei.com>
2026-07-20 9:27 ` David Hildenbrand (Arm) [this message]
2026-07-20 12:42 ` [PATCH v3-fixup 5/6] mm: mincore: fixup improve mincore_hugetlb() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=133f3f9a-bd3a-432a-afc7-ccecc57d5099@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=pfalcato@suse.de \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox