Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, David Hildenbrand <david@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
	Pedro Falcato <pfalcato@suse.de>, Zi Yan <ziy@nvidia.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v3-fixup 2/6] mm: mincore: fixup for remove special handling for VM_PFNMAP
Date: Mon, 20 Jul 2026 20:41:51 +0800	[thread overview]
Message-ID: <20260720124151.1483820-1-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20260717091347.1144789-3-wangkefeng.wang@huawei.com>

Address David's comments
- rename mincore_pud_range to mincore_pud_entry
- change int nr to const unsigned long
- remove a local vec variable

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/mincore.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/mm/mincore.c b/mm/mincore.c
index d7841a38b54a..9ea81638d09f 100644
--- a/mm/mincore.c
+++ b/mm/mincore.c
@@ -146,16 +146,15 @@ static int mincore_unmapped_range(unsigned long addr, unsigned long end,
 	return 0;
 }
 
-static int mincore_pud_range(pud_t *pudp, unsigned long addr, unsigned long end,
+static int mincore_pud_entry(pud_t *pudp, unsigned long addr, unsigned long end,
 		struct mm_walk *walk)
 {
 	if (pud_is_huge(pudp_get(pudp))) {
-		int nr = (end - addr) >> PAGE_SHIFT;
-		unsigned char *vec = walk->private;
+		const unsigned long nr = (end - addr) >> PAGE_SHIFT;
 
-		memset(vec, 1, nr);
-		walk->action = ACTION_CONTINUE;
+		memset(walk->private, 1, nr);
 		walk->private += nr;
+		walk->action = ACTION_CONTINUE;
 	}
 
 	return 0;
@@ -233,7 +232,7 @@ static inline bool can_do_mincore(struct vm_area_struct *vma)
 }
 
 static const struct mm_walk_ops mincore_walk_ops = {
-	.pud_entry		= mincore_pud_range,
+	.pud_entry		= mincore_pud_entry,
 	.pmd_entry		= mincore_pte_range,
 	.pte_hole		= mincore_unmapped_range,
 	.hugetlb_entry		= mincore_hugetlb,
-- 
2.55.0



  parent reply	other threads:[~2026-07-20 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260717091347.1144789-1-wangkefeng.wang@huawei.com>
     [not found] ` <20260717091347.1144789-2-wangkefeng.wang@huawei.com>
2026-07-20  9:21   ` [PATCH v3 1/6] mm: introduce pud_is_huge() helper David Hildenbrand (Arm)
     [not found] ` <20260717091347.1144789-3-wangkefeng.wang@huawei.com>
2026-07-20  9:25   ` [PATCH v3 2/6] mm: mincore: remove special handling for VM_PFNMAP David Hildenbrand (Arm)
2026-07-20  9:26   ` David Hildenbrand (Arm)
2026-07-20 12:41   ` Kefeng Wang [this message]
     [not found] ` <20260717091347.1144789-6-wangkefeng.wang@huawei.com>
2026-07-20  9:27   ` [PATCH v3 5/6] mm: mincore: improve mincore_hugetlb() David Hildenbrand (Arm)
2026-07-20 12:42   ` [PATCH v3-fixup 5/6] mm: mincore: fixup " Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720124151.1483820-1-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox