[akpm-mm:mm-nonmm-unstable 84/106] kernel/liveupdate/luo_session.c:101:3: sparse: sparse: symbol 'luo_session_global' was not declared. Should it be static?

[akpm-mm:mm-nonmm-unstable 84/106] kernel/liveupdate/luo_session.c:101:3: sparse: sparse: symbol 'luo_session_global' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
head:   c3e0350a1f9934c5e56d859a26bf37a15ab7bb25
commit: 877409d046405d44ba7e15e19345239c1affa4a5 [84/106] liveupdate: luo_session: add sessions support
config: x86_64-randconfig-123-20251114 (https://download.01.org/0day-ci/archive/20251114/202511140809.4JN2GCxV-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140809.4JN2GCxV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511140809.4JN2GCxV-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/liveupdate/luo_session.c:101:3: sparse: sparse: symbol 'luo_session_global' was not declared. Should it be static?

vim +/luo_session_global +101 kernel/liveupdate/luo_session.c

    89	
    90	/**
    91	 * struct luo_session_global - Global container for managing LUO sessions.
    92	 * @incoming:     The sessions passed from the previous kernel.
    93	 * @outgoing:     The sessions that are going to be passed to the next kernel.
    94	 * @deserialized: The sessions have been deserialized once /dev/liveupdate
    95	 *                has been opened.
    96	 */
    97	struct luo_session_global {
    98		struct luo_session_head incoming;
    99		struct luo_session_head outgoing;
   100		bool deserialized;
 > 101	} luo_session_global;
   102	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-nonmm-unstable 84/106] kernel/liveupdate/luo_session.c:101:3: sparse: sparse: symbol 'luo_session_global' was not declared. Should it be static?

[Pasha Tatashin]

On Thu, Nov 13, 2025 at 7:29 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
> head:   c3e0350a1f9934c5e56d859a26bf37a15ab7bb25
> commit: 877409d046405d44ba7e15e19345239c1affa4a5 [84/106] liveupdate: luo_session: add sessions support
> config: x86_64-randconfig-123-20251114 (https://download.01.org/0day-ci/archive/20251114/202511140809.4JN2GCxV-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140809.4JN2GCxV-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511140809.4JN2GCxV-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> kernel/liveupdate/luo_session.c:101:3: sparse: sparse: symbol 'luo_session_global' was not declared. Should it be static?
>
> vim +/luo_session_global +101 kernel/liveupdate/luo_session.c
>
>     89
>     90  /**
>     91   * struct luo_session_global - Global container for managing LUO sessions.
>     92   * @incoming:     The sessions passed from the previous kernel.
>     93   * @outgoing:     The sessions that are going to be passed to the next kernel.
>     94   * @deserialized: The sessions have been deserialized once /dev/liveupdate
>     95   *                has been opened.
>     96   */
>     97  struct luo_session_global {
>     98          struct luo_session_head incoming;
>     99          struct luo_session_head outgoing;
>    100          bool deserialized;
>  > 101  } luo_session_global;
>    102

Thank you, the fix is:

From 3c561cef2649c368b8aeb8e6e16fd096fd8634a7 Mon Sep 17 00:00:00 2001
From: Pasha Tatashin <pasha.tatashin@soleen.com>
Date: Thu, 13 Nov 2025 23:29:18 -0500
Subject: [PATCH] Fixup: liveupdate: luo_session: add sessions support

---
 kernel/liveupdate/luo_session.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c
index ec526de83987..e1a45af892eb 100644
--- a/kernel/liveupdate/luo_session.c
+++ b/kernel/liveupdate/luo_session.c
@@ -98,7 +98,9 @@ struct luo_session_global {
  struct luo_session_head incoming;
  struct luo_session_head outgoing;
  bool deserialized;
-} luo_session_global;
+};
+
+static struct luo_session_global luo_session_global;

 static struct luo_session *luo_session_alloc(const char *name)
 {
-- 
2.52.0.rc1.455.g30608eb744-goog