public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH 15/19] mm/damon/sysfs-schemes: implement tried_region/probe_hits file
Date: Sun, 26 Apr 2026 13:52:16 -0700	[thread overview]
Message-ID: <20260426205222.93895-16-sj@kernel.org> (raw)
In-Reply-To: <20260426205222.93895-1-sj@kernel.org>

Implement a file for letting users read the per-region per-probe
positive samples count.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/sysfs-schemes.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index c3c1ff6108863..48a949484a052 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -20,6 +20,7 @@ struct damon_sysfs_scheme_region {
 	unsigned int nr_accesses;
 	unsigned int age;
 	unsigned long sz_filter_passed;
+	unsigned char probe_hits[DAMON_MAX_PROBES];
 	struct list_head list;
 };
 
@@ -34,6 +35,9 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(
 	sysfs_region->ar = region->ar;
 	sysfs_region->nr_accesses = region->nr_accesses_bp / 10000;
 	sysfs_region->age = region->age;
+	memcpy(sysfs_region->probe_hits, region->probe_hits,
+			sizeof(*sysfs_region->probe_hits) *
+			ARRAY_SIZE(sysfs_region->probe_hits));
 	INIT_LIST_HEAD(&sysfs_region->list);
 	return sysfs_region;
 }
@@ -83,6 +87,28 @@ static ssize_t sz_filter_passed_show(struct kobject *kobj,
 	return sysfs_emit(buf, "%lu\n", region->sz_filter_passed);
 }
 
+static ssize_t probe_hits_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_scheme_region *region = container_of(kobj,
+			struct damon_sysfs_scheme_region, kobj);
+	char *str;
+	int ret, i;
+
+	str = kcalloc(2048, sizeof(*str), GFP_KERNEL);
+	if (!str)
+		return -ENOMEM;
+	for (i = 0; i < DAMON_MAX_PROBES; i++) {
+		snprintf(&str[strlen(str)], 2048 - strlen(str), "%hhu",
+				region->probe_hits[i]);
+		if (i < DAMON_MAX_PROBES - 1)
+			snprintf(&str[strlen(str)], 2048 - strlen(str), ",");
+	}
+	ret = sysfs_emit(buf, "%s\n", str);
+	kfree(str);
+	return ret;
+}
+
 static void damon_sysfs_scheme_region_release(struct kobject *kobj)
 {
 	struct damon_sysfs_scheme_region *region = container_of(kobj,
@@ -107,12 +133,16 @@ static struct kobj_attribute damon_sysfs_scheme_region_age_attr =
 static struct kobj_attribute damon_sysfs_scheme_region_sz_filter_passed_attr =
 		__ATTR_RO_MODE(sz_filter_passed, 0400);
 
+static struct kobj_attribute damon_sysfs_scheme_region_probe_hits_attr =
+		__ATTR_RO_MODE(probe_hits, 0400);
+
 static struct attribute *damon_sysfs_scheme_region_attrs[] = {
 	&damon_sysfs_scheme_region_start_attr.attr,
 	&damon_sysfs_scheme_region_end_attr.attr,
 	&damon_sysfs_scheme_region_nr_accesses_attr.attr,
 	&damon_sysfs_scheme_region_age_attr.attr,
 	&damon_sysfs_scheme_region_sz_filter_passed_attr.attr,
+	&damon_sysfs_scheme_region_probe_hits_attr.attr,
 	NULL,
 };
 ATTRIBUTE_GROUPS(damon_sysfs_scheme_region);
-- 
2.47.3


  parent reply	other threads:[~2026-04-26 20:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 20:52 [RFC PATCH 00/19] mm/damon: introduce data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 01/19] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 02/19] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 03/19] mm/damon/core: introduce damon_filter SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 04/19] mm/damon/core: commit probes SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 05/19] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 06/19] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 07/19] mm/damon/core: do data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 08/19] mm/damon/paddr: support " SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 09/19] mm/damon/sysfs: implement probes dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 10/19] mm/damon/sysfs: implement probe dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 11/19] mm/damon/sysfs: implement filters directory SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 12/19] mm/damon/sysfs: implement filter dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 13/19] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 14/19] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-04-26 20:52 ` SeongJae Park [this message]
2026-04-26 20:52 ` [RFC PATCH 16/19] mm/damon: trace probe_hits SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 17/19] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 18/19] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 19/19] Docs/admin-guide/mm/damon/usage: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260426205222.93895-16-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox