public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH 03/19] mm/damon/core: introduce damon_filter
Date: Sun, 26 Apr 2026 13:52:04 -0700	[thread overview]
Message-ID: <20260426205222.93895-4-sj@kernel.org> (raw)
In-Reply-To: <20260426205222.93895-1-sj@kernel.org>

Define a data structure for constructing damon_probe's attributes check,
namely damon_filter.  It is very similar to damos_filter but works only
for monitoring purposes.  Also embed that into damon_probe, implement
essential handling of the link, with fundamental helpers.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 include/linux/damon.h | 36 ++++++++++++++++++++++++++++++++++++
 mm/damon/core.c       | 30 ++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)

diff --git a/include/linux/damon.h b/include/linux/damon.h
index 65d7ee0a70ac0..3290792eab547 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -732,12 +732,38 @@ struct damon_intervals_goal {
 	unsigned long max_sample_us;
 };
 
+/**
+ * enum damon_filter_type - Type of &struct damon_filter
+ *
+ * @DAMON_TEST_TYPE_ANON:	Anonymous pages.
+ */
+enum damon_filter_type {
+	DAMON_TEST_TYPE_ANON,
+};
+
+/**
+ * struct damon_filter - DAMON region filter for &struct damon_probe.
+ *
+ * @type:	Type of the region.
+ * @matcing:	Whether this filter is for the type-matching ones.
+ * @allow:	Whether the @type-@matching ones should pass this filter.
+ * @list:	Siblings list.
+ */
+struct damon_filter {
+	enum damon_filter_type type;
+	bool matching;
+	bool allow;
+	struct list_head list;
+};
+
 /**
  * struct damon_probe - Data region attribute probe.
  *
+ * @filters:	Filters for assessing if a given region is for this probe.
  * @list:	Siblings list.
  */
 struct damon_probe {
+	struct list_head filters;
 	struct list_head list;
 };
 
@@ -893,6 +919,12 @@ static inline unsigned long damon_sz_region(struct damon_region *r)
 	return r->ar.end - r->ar.start;
 }
 
+#define damon_for_each_filter(f, p) \
+	list_for_each_entry(f, &p->filters, list)
+
+#define damon_for_each_filter_safe(f, next, p) \
+	list_for_each_entry_safe(f, next, &p->filters, list)
+
 #define damon_for_each_probe(p, ctx) \
 	list_for_each_entry(p, &ctx->probes, list)
 
@@ -940,6 +972,10 @@ static inline unsigned long damon_sz_region(struct damon_region *r)
 
 #ifdef CONFIG_DAMON
 
+struct damon_filter *damon_new_filter(enum damon_filter_type type,
+		bool matching, bool allow);
+void damon_add_filter(struct damon_probe *probe, struct damon_filter *f);
+
 struct damon_probe *damon_new_probe(void);
 void damon_add_probe(struct damon_ctx *ctx, struct damon_probe *probe);
 
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 861ab977d1edf..170abba8fdf2a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -109,6 +109,31 @@ int damon_select_ops(struct damon_ctx *ctx, enum damon_ops_id id)
 	return err;
 }
 
+struct damon_filter *damon_new_filter(enum damon_filter_type type,
+		bool matching, bool allow)
+{
+	struct damon_filter *filter;
+
+	filter = kmalloc_obj(*filter);
+	if (!filter)
+		return NULL;
+	filter->type = type;
+	filter->matching = matching;
+	filter->allow = allow;
+	INIT_LIST_HEAD(&filter->list);
+	return filter;
+}
+
+void damon_add_filter(struct damon_probe *p, struct damon_filter *f)
+{
+	list_add_tail(&f->list, &p->filters);
+}
+
+static void damon_free_filter(struct damon_filter *f)
+{
+	kfree(f);
+}
+
 struct damon_probe *damon_new_probe(void)
 {
 	struct damon_probe *p;
@@ -116,6 +141,7 @@ struct damon_probe *damon_new_probe(void)
 	p = kmalloc_obj(*p);
 	if (!p)
 		return NULL;
+	INIT_LIST_HEAD(&p->filters);
 	INIT_LIST_HEAD(&p->list);
 	return p;
 }
@@ -132,6 +158,10 @@ static void damon_del_probe(struct damon_probe *p)
 
 static void damon_free_probe(struct damon_probe *p)
 {
+	struct damon_filter *f, *next;
+
+	damon_for_each_filter_safe(f, next, p)
+		damon_free_filter(f);
 	kfree(p);
 }
 
-- 
2.47.3


  parent reply	other threads:[~2026-04-26 20:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 20:52 [RFC PATCH 00/19] mm/damon: introduce data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 01/19] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 02/19] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-04-26 20:52 ` SeongJae Park [this message]
2026-04-26 20:52 ` [RFC PATCH 04/19] mm/damon/core: commit probes SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 05/19] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 06/19] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 07/19] mm/damon/core: do data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 08/19] mm/damon/paddr: support " SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 09/19] mm/damon/sysfs: implement probes dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 10/19] mm/damon/sysfs: implement probe dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 11/19] mm/damon/sysfs: implement filters directory SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 12/19] mm/damon/sysfs: implement filter dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 13/19] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 14/19] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 15/19] mm/damon/sysfs-schemes: implement tried_region/probe_hits file SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 16/19] mm/damon: trace probe_hits SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 17/19] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 18/19] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-04-26 20:52 ` [RFC PATCH 19/19] Docs/admin-guide/mm/damon/usage: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260426205222.93895-4-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox