* Re: [PATCH v1 1/3] mm/damon: Introduce DAMOS_QUOTA_HUGEPAGE auto tuning
[not found] <20260616150316.580819-2-gutierrez.asier@huawei-partners.com>
@ 2026-06-17 3:31 ` SeongJae Park
0 siblings, 0 replies; only message in thread
From: SeongJae Park @ 2026-06-17 3:31 UTC (permalink / raw)
To: gutierrez.asier
Cc: SeongJae Park, artem.kuzin, stepanov.anatoly, wangkefeng.wang,
yanquanmin1, zuoze1, damon, akpm, linux-mm, linux-kernel
On Tue, 16 Jun 2026 15:03:14 +0000 <gutierrez.asier@huawei-partners.com> wrote:
> From: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
>
> Introduce DAMOS_QUOTA_HUGEPAGE auto tuning Add a new
Please fix the name of the quota, and add the ending period after 'tuning'.
> DAMOS quota goal metric to measure the amount of huge page
> consumption to total memory consumption ratio.
>
> Signed-off-by: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
> ---
> include/linux/damon.h | 2 ++
> mm/damon/core.c | 14 ++++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 6f7edb3590ef..23a9cec05033 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -162,6 +162,7 @@ enum damos_action {
> * @DAMOS_QUOTA_INACTIVE_MEM_BP: Inactive to total LRU memory ratio.
> * @DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP: Scheme-eligible memory ratio of a
> * node in basis points (0-10000).
> + * @DAMOS_QUOTA_HUGEPAGE_MEM_BP: Huge page to total used memory ratio.
> * @NR_DAMOS_QUOTA_GOAL_METRICS: Number of DAMOS quota goal metrics.
> *
> * Metrics equal to larger than @NR_DAMOS_QUOTA_GOAL_METRICS are unsupported.
> @@ -176,6 +177,7 @@ enum damos_quota_goal_metric {
> DAMOS_QUOTA_ACTIVE_MEM_BP,
> DAMOS_QUOTA_INACTIVE_MEM_BP,
> DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP,
> + DAMOS_QUOTA_HUGEPAGE_MEM_BP,
> NR_DAMOS_QUOTA_GOAL_METRICS,
> };
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 7e4b9affc5b0..b001f80681b1 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -2795,6 +2795,17 @@ static unsigned int damos_get_in_active_mem_bp(bool active_ratio)
> return mult_frac(inactive, 10000, total);
> }
>
> +static unsigned int damos_hugepage_mem_bp(void)
> +{
> + unsigned long thp, total;
> +
> + thp = global_node_page_state(NR_ANON_THPS) +
> + global_node_page_state(NR_SHMEM_THPS) +
> + global_node_page_state(NR_FILE_THPS);
> + total = totalram_pages() - global_zone_page_state(NR_FREE_PAGES);
> + return mult_frac(thp, 10000, total);
> +}
> +
> static void damos_set_quota_goal_current_value(struct damon_ctx *c,
> struct damos *s, struct damos_quota_goal *goal)
> {
> @@ -2826,6 +2837,9 @@ static void damos_set_quota_goal_current_value(struct damon_ctx *c,
> goal->current_value = damos_get_node_eligible_mem_bp(c, s,
> goal->nid);
> break;
> + case DAMOS_QUOTA_HUGEPAGE_MEM_BP:
> + goal->current_value = damos_hugepage_mem_bp();
> + break;
> default:
> break;
> }
> --
> 2.43.0
Code looks good to me.
Thanks,
SJ
^ permalink raw reply [flat|nested] only message in thread