Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies
@ 2026-07-07  9:03 Kaitao Cheng
  2026-07-07 10:06 ` David Hildenbrand (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kaitao Cheng @ 2026-07-07  9:03 UTC (permalink / raw)
  To: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
	Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko
  Cc: linux-mm, linux-kernel, Muchun Song, Kaitao Cheng

From: Kaitao Cheng <chengkaitao@kylinos.cn>

MHP_MEMMAP_ON_MEMORY is defined inside the MEMORY_HOTPLUG block, and
MEMORY_HOTPLUG already depends on SPARSEMEM_VMEMMAP. Keep the explicit
MEMORY_HOTPLUG dependency for local readability, but drop the redundant
SPARSEMEM_VMEMMAP dependency.

ZONE_DEVICE depends on MEMORY_HOTREMOVE, which depends on MEMORY_HOTPLUG.
MEMORY_HOTPLUG in turn depends on SPARSEMEM_VMEMMAP. Drop the direct
MEMORY_HOTPLUG and SPARSEMEM_VMEMMAP dependencies from ZONE_DEVICE.

This does not change the set of valid configurations.

Signed-off-by: Kaitao Cheng <chengkaitao@kylinos.cn>
---
 mm/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/Kconfig b/mm/Kconfig
index 04fe5171bb8c..ff29f770d10a 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -596,7 +596,7 @@ config MEMORY_HOTREMOVE
 
 config MHP_MEMMAP_ON_MEMORY
 	def_bool y
-	depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP
+	depends on MEMORY_HOTPLUG
 	depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
 
 endif # MEMORY_HOTPLUG
@@ -1235,9 +1235,7 @@ config ZONE_DMA32
 
 config ZONE_DEVICE
 	bool "Device memory (pmem, HMM, etc...) hotplug support"
-	depends on MEMORY_HOTPLUG
 	depends on MEMORY_HOTREMOVE
-	depends on SPARSEMEM_VMEMMAP
 	select XARRAY_MULTI
 
 	help
-- 
2.50.1 (Apple Git-155)



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies
  2026-07-07  9:03 [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies Kaitao Cheng
@ 2026-07-07 10:06 ` David Hildenbrand (Arm)
  2026-07-07 11:05 ` Muchun Song
  2026-07-07 11:11 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand (Arm) @ 2026-07-07 10:06 UTC (permalink / raw)
  To: Kaitao Cheng, Andrew Morton, Lorenzo Stoakes, Liam R . Howlett,
	Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko
  Cc: linux-mm, linux-kernel, Muchun Song, Kaitao Cheng

On 7/7/26 11:03, Kaitao Cheng wrote:
> From: Kaitao Cheng <chengkaitao@kylinos.cn>
> 
> MHP_MEMMAP_ON_MEMORY is defined inside the MEMORY_HOTPLUG block, and
> MEMORY_HOTPLUG already depends on SPARSEMEM_VMEMMAP. Keep the explicit
> MEMORY_HOTPLUG dependency for local readability, but drop the redundant
> SPARSEMEM_VMEMMAP dependency.
> 
> ZONE_DEVICE depends on MEMORY_HOTREMOVE, which depends on MEMORY_HOTPLUG.
> MEMORY_HOTPLUG in turn depends on SPARSEMEM_VMEMMAP. Drop the direct
> MEMORY_HOTPLUG and SPARSEMEM_VMEMMAP dependencies from ZONE_DEVICE.
> 
> This does not change the set of valid configurations.
> 
> Signed-off-by: Kaitao Cheng <chengkaitao@kylinos.cn>
> ---
>  mm/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 04fe5171bb8c..ff29f770d10a 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -596,7 +596,7 @@ config MEMORY_HOTREMOVE
>  
>  config MHP_MEMMAP_ON_MEMORY
>  	def_bool y
> -	depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP
> +	depends on MEMORY_HOTPLUG
>  	depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>  
>  endif # MEMORY_HOTPLUG
> @@ -1235,9 +1235,7 @@ config ZONE_DMA32
>  
>  config ZONE_DEVICE
>  	bool "Device memory (pmem, HMM, etc...) hotplug support"
> -	depends on MEMORY_HOTPLUG
>  	depends on MEMORY_HOTREMOVE
> -	depends on SPARSEMEM_VMEMMAP
>  	select XARRAY_MULTI

I'm planning on merging  MEMORY_HOTPLUG and MEMORY_HOTREMOVE soon, but for now
that is good enough.

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies
  2026-07-07  9:03 [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies Kaitao Cheng
  2026-07-07 10:06 ` David Hildenbrand (Arm)
@ 2026-07-07 11:05 ` Muchun Song
  2026-07-07 11:11 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: Muchun Song @ 2026-07-07 11:05 UTC (permalink / raw)
  To: Kaitao Cheng
  Cc: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
	Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, linux-mm, linux-kernel,
	Kaitao Cheng



> On Jul 7, 2026, at 17:03, Kaitao Cheng <kaitao.cheng@linux.dev> wrote:
> 
> From: Kaitao Cheng <chengkaitao@kylinos.cn>
> 
> MHP_MEMMAP_ON_MEMORY is defined inside the MEMORY_HOTPLUG block, and
> MEMORY_HOTPLUG already depends on SPARSEMEM_VMEMMAP. Keep the explicit
> MEMORY_HOTPLUG dependency for local readability, but drop the redundant
> SPARSEMEM_VMEMMAP dependency.
> 
> ZONE_DEVICE depends on MEMORY_HOTREMOVE, which depends on MEMORY_HOTPLUG.
> MEMORY_HOTPLUG in turn depends on SPARSEMEM_VMEMMAP. Drop the direct
> MEMORY_HOTPLUG and SPARSEMEM_VMEMMAP dependencies from ZONE_DEVICE.
> 
> This does not change the set of valid configurations.
> 
> Signed-off-by: Kaitao Cheng <chengkaitao@kylinos.cn>

Acked-by: Muchun Song <muchun.song@linux.dev>

Thanks



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies
  2026-07-07  9:03 [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies Kaitao Cheng
  2026-07-07 10:06 ` David Hildenbrand (Arm)
  2026-07-07 11:05 ` Muchun Song
@ 2026-07-07 11:11 ` Lorenzo Stoakes
  2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Stoakes @ 2026-07-07 11:11 UTC (permalink / raw)
  To: Kaitao Cheng
  Cc: Andrew Morton, David Hildenbrand, Liam R . Howlett,
	Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
	linux-mm, linux-kernel, Muchun Song, Kaitao Cheng

On Tue, Jul 07, 2026 at 05:03:31PM +0800, Kaitao Cheng wrote:
> From: Kaitao Cheng <chengkaitao@kylinos.cn>
>
> MHP_MEMMAP_ON_MEMORY is defined inside the MEMORY_HOTPLUG block, and
> MEMORY_HOTPLUG already depends on SPARSEMEM_VMEMMAP. Keep the explicit
> MEMORY_HOTPLUG dependency for local readability, but drop the redundant
> SPARSEMEM_VMEMMAP dependency.
>
> ZONE_DEVICE depends on MEMORY_HOTREMOVE, which depends on MEMORY_HOTPLUG.
> MEMORY_HOTPLUG in turn depends on SPARSEMEM_VMEMMAP. Drop the direct
> MEMORY_HOTPLUG and SPARSEMEM_VMEMMAP dependencies from ZONE_DEVICE.
>
> This does not change the set of valid configurations.
>
> Signed-off-by: Kaitao Cheng <chengkaitao@kylinos.cn>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>

> ---
>  mm/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 04fe5171bb8c..ff29f770d10a 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -596,7 +596,7 @@ config MEMORY_HOTREMOVE
>
>  config MHP_MEMMAP_ON_MEMORY
>  	def_bool y
> -	depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP
> +	depends on MEMORY_HOTPLUG
>  	depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>
>  endif # MEMORY_HOTPLUG
> @@ -1235,9 +1235,7 @@ config ZONE_DMA32
>
>  config ZONE_DEVICE
>  	bool "Device memory (pmem, HMM, etc...) hotplug support"
> -	depends on MEMORY_HOTPLUG
>  	depends on MEMORY_HOTREMOVE
> -	depends on SPARSEMEM_VMEMMAP
>  	select XARRAY_MULTI
>
>  	help
> --
> 2.50.1 (Apple Git-155)
>

Cheers, Lorenzo


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-07-07 11:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-07  9:03 [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies Kaitao Cheng
2026-07-07 10:06 ` David Hildenbrand (Arm)
2026-07-07 11:05 ` Muchun Song
2026-07-07 11:11 ` Lorenzo Stoakes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox