[PATCH 0/4] Docs/ABI/damon: sysfs ABI document fixes and additions

[PATCH 0/4] Docs/ABI/damon: sysfs ABI document fixes and additions

[Song Hu]

This series fixes typos and fills in missing entries in the DAMON
sysfs ABI document (Documentation/ABI/testing/sysfs-kernel-mm-damon).

Patch 1 fixes a path typo, "intrvals_goal" -> "intervals_goal", in
four What: entries; the documented path points to a non-existent
directory, so it is Cc'ed to stable.

Patch 2 fixes two further typos ("WDate:", "manimum").

Patches 3 and 4 add ABI entries that exist in the kernel and are
already described in usage.rst but are missing from the canonical ABI
document: the 'update_tuned_intervals' state command (patch 3) and the
'tried_regions/<R>/probes/<P>/hits' file (patch 4).

Song Hu (4):
  Docs/ABI/damon: fix typo in intervals_goal sysfs path
  Docs/ABI/damon: fix typos
  Docs/ABI/damon: document update_tuned_intervals state command
  Docs/ABI/damon: document tried_regions probe hits

 .../ABI/testing/sysfs-kernel-mm-damon         | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

-- 
2.43.0

[PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path

[Song Hu]

The ABI document spells the DAMON sysfs directory as "intrvals_goal"
(missing 'e') in four What: entries, but the kernel creates it as
"intervals_goal" (mm/damon/sysfs.c).  Following the documented path
therefore yields a non-existent directory.

Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
Cc: stable@vger.kernel.org
Signed-off-by: Song Hu <husong@kylinos.cn>
---
 Documentation/ABI/testing/sysfs-kernel-mm-damon | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index dd6b5bd76e11..885409a26786 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -112,7 +112,7 @@ Description:	Writing a value to this file sets the update interval of the
 		DAMON context in microseconds as the value.  Reading this file
 		returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/access_bp
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/access_bp
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the monitoring intervals
@@ -120,7 +120,7 @@ Description:	Writing a value to this file sets the monitoring intervals
 		the given time interval (aggrs in same directory), in bp
 		(1/10,000).  Reading this file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/aggrs
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/aggrs
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the time interval to achieve
@@ -128,14 +128,14 @@ Description:	Writing a value to this file sets the time interval to achieve
 		access events ratio (access_bp in same directory) within.
 		Reading this file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/min_sample_us
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/min_sample_us
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the minimum value of
 		auto-tuned sampling interval in microseconds.  Reading this
 		file returns the value.
 
-What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intrvals_goal/max_sample_us
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/intervals/intervals_goal/max_sample_us
 Date:		Feb 2025
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the maximum value of
-- 
2.43.0

Re: [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path

[SJ Park]

On Fri, 10 Jul 2026 12:47:34 +0800 Song Hu <husong@kylinos.cn> wrote:

> The ABI document spells the DAMON sysfs directory as "intrvals_goal"
> (missing 'e') in four What: entries, but the kernel creates it as
> "intervals_goal" (mm/damon/sysfs.c).  Following the documented path
> therefore yields a non-existent directory.

Nice catch!

> 
> Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ  Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH 1/4] Docs/ABI/damon: fix typo in intervals_goal sysfs path

[SJ Park]

On Fri, 10 Jul 2026 07:17:37 -0700 SJ Park <sj@kernel.org> wrote:

> On Fri, 10 Jul 2026 12:47:34 +0800 Song Hu <husong@kylinos.cn> wrote:
> 
> > The ABI document spells the DAMON sysfs directory as "intrvals_goal"
> > (missing 'e') in four What: entries, but the kernel creates it as
> > "intervals_goal" (mm/damon/sysfs.c).  Following the documented path
> > therefore yields a non-existent directory.
> 
> Nice catch!
> 
> > 
> > Fixes: e2b23dc62369 ("Docs/ABI/damon: document intervals auto-tuning ABI")
> > Cc: stable@vger.kernel.org

By the way, hotfixes and non-hotfixes usually take different trains to the
mainline.  Having those in single series therefore makes maintainer works
difficult.  I understand this is not a hotfix but just somewhat worthy to
eventually be backported to stable kernels.  So no problem for this.

But, from the next time, please clarify or use different series for Cc: stable@
patches.


Thanks,
SJ

[...]

[PATCH 2/4] Docs/ABI/damon: fix typos

[Song Hu]

Fix two typos in the DAMON sysfs ABI document:

  - "WDate:" -> "Date:" on the nr_regions/min entry
  - "manimum" -> "minimum" in the nr_accesses/min description

Signed-off-by: Song Hu <husong@kylinos.cn>
---
 Documentation/ABI/testing/sysfs-kernel-mm-damon | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index 885409a26786..03aecc07a5bd 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -144,7 +144,7 @@ Description:	Writing a value to this file sets the maximum value of
 
 What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/nr_regions/min
 
-WDate:		Mar 2022
+Date:		Mar 2022
 Contact:	SJ Park <sj@kernel.org>
 Description:	Writing a value to this file sets the minimum number of
 		monitoring regions of the DAMON context as the value.  Reading
@@ -281,7 +281,7 @@ Description:	Writing to and reading from this file sets and gets the maximum
 What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/access_pattern/nr_accesses/min
 Date:		Mar 2022
 Contact:	SJ Park <sj@kernel.org>
-Description:	Writing to and reading from this file sets and gets the manimum
+Description:	Writing to and reading from this file sets and gets the minimum
 		'nr_accesses' of the scheme's target regions.
 
 What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/access_pattern/nr_accesses/max
-- 
2.43.0

Re: [PATCH 2/4] Docs/ABI/damon: fix typos

[SJ Park]

On Fri, 10 Jul 2026 12:47:35 +0800 Song Hu <husong@kylinos.cn> wrote:

> Fix two typos in the DAMON sysfs ABI document:
> 
>   - "WDate:" -> "Date:" on the nr_regions/min entry
>   - "manimum" -> "minimum" in the nr_accesses/min description

Good eyes!

> 
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

[PATCH 3/4] Docs/ABI/damon: document update_tuned_intervals state command

[Song Hu]

The 'update_tuned_intervals' command of the 'state' file, added in
commit 1077605396b4 ("mm/damon/sysfs: implement a command to update
auto-tuned monitoring intervals"), is described in usage.rst but
missing from the canonical ABI document.  Add it.

Signed-off-by: Song Hu <husong@kylinos.cn>
---
 Documentation/ABI/testing/sysfs-kernel-mm-damon | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index 03aecc07a5bd..7e8192527191 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -36,7 +36,10 @@ Description:	Writing 'on' or 'off' to this file makes the kdamond starts or
 		kdamond.  Writing 'clear_schemes_tried_regions' to the file
 		removes contents of the 'tried_regions' directory.  Writing
 		'update_schemes_effective_quotas' to the file updates
-		'.../quotas/effective_bytes' files of this kdamond.
+		'.../quotas/effective_bytes' files of this kdamond.  Writing
+		'update_tuned_intervals' to the file updates 'sample_us' and
+		'aggr_us' files under 'monitoring_attrs/intervals' with the
+		auto-tuned sampling and aggregation intervals.
 
 What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/pid
 Date:		Mar 2022
-- 
2.43.0

Re: [PATCH 3/4] Docs/ABI/damon: document update_tuned_intervals state command

[SJ Park]

On Fri, 10 Jul 2026 12:47:36 +0800 Song Hu <husong@kylinos.cn> wrote:

> The 'update_tuned_intervals' command of the 'state' file, added in
> commit 1077605396b4 ("mm/damon/sysfs: implement a command to update
> auto-tuned monitoring intervals"), is described in usage.rst but
> missing from the canonical ABI document.  Add it.

I initially thought this information is better to be only in usage document.
But, ABI doc is already describing all the inputs.  So, this looks good to me
now.

> 
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>

> ---
>  Documentation/ABI/testing/sysfs-kernel-mm-damon | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> index 03aecc07a5bd..7e8192527191 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> @@ -36,7 +36,10 @@ Description:	Writing 'on' or 'off' to this file makes the kdamond starts or
>  		kdamond.  Writing 'clear_schemes_tried_regions' to the file
>  		removes contents of the 'tried_regions' directory.  Writing
>  		'update_schemes_effective_quotas' to the file updates
> -		'.../quotas/effective_bytes' files of this kdamond.
> +		'.../quotas/effective_bytes' files of this kdamond.  Writing
> +		'update_tuned_intervals' to the file updates 'sample_us' and
> +		'aggr_us' files under 'monitoring_attrs/intervals' with the
> +		auto-tuned sampling and aggregation intervals.
>  
>  What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/pid
>  Date:		Mar 2022
> -- 
> 2.43.0


Thanks,
SJ

[PATCH 4/4] Docs/ABI/damon: document tried_regions probe hits

[Song Hu]

The 'tried_regions/<R>/probes/<P>/hits' file, added in commit
5b0de1bc3325 ("mm/damon/sysfs-schemes: implement probe/hits file"),
is described in usage.rst but missing from the canonical ABI document.

Document the 'probes/' directory and the 'probes/<P>/hits' file.

Signed-off-by: Song Hu <husong@kylinos.cn>
---
 Documentation/ABI/testing/sysfs-kernel-mm-damon | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index 7e8192527191..e8645f987fc3 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -644,3 +644,15 @@ Contact:	SJ Park <sj@kernel.org>
 Description:	Reading this file returns the size of the memory in the region
 		that passed DAMON operations layer-handled filters of the
 		scheme in bytes.
+
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/tried_regions/<R>/probes/
+Date:		May 2026
+Contact:	SJ Park <sj@kernel.org>
+Description:	Directory for DAMON data-attribute monitoring probes of the
+		region.
+
+What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/tried_regions/<R>/probes/<P>/hits
+Date:		May 2026
+Contact:	SJ Park <sj@kernel.org>
+Description:	Reading this file returns the number of data-attribute
+		monitoring probe-hit positive samples of the region.
-- 
2.43.0

Re: [PATCH 4/4] Docs/ABI/damon: document tried_regions probe hits

[SJ Park]

On Fri, 10 Jul 2026 12:47:37 +0800 Song Hu <husong@kylinos.cn> wrote:

> The 'tried_regions/<R>/probes/<P>/hits' file, added in commit
> 5b0de1bc3325 ("mm/damon/sysfs-schemes: implement probe/hits file"),
> is described in usage.rst but missing from the canonical ABI document.
> 
> Document the 'probes/' directory and the 'probes/<P>/hits' file.

Thank you for catching and fixing this!

> 
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH 0/4] Docs/ABI/damon: sysfs ABI document fixes and additions

[SJ Park]

'hkml patch check' [1] says you forgot Cc-ing below people who are recommended
by get_maintainer.pl.  I Cc-ed them.  Please Cc all recipients who
get_maitnainer.pl is recommending, from the next time.  'hkml patch format' [2]
could also help you doing so.

- Andrew Morton <akpm@linux-foundation.org>
- David Hildenbrand <david@kernel.org>
- Lorenzo Stoakes <ljs@kernel.org>
- "Liam R. Howlett" <liam@infradead.org>
- Vlastimil Babka <vbabka@kernel.org>
- Mike Rapoport <rppt@kernel.org>
- Suren Baghdasaryan <surenb@google.com>
- Michal Hocko <mhocko@suse.com>

On Fri, 10 Jul 2026 12:47:33 +0800 Song Hu <husong@kylinos.cn> wrote:

> This series fixes typos and fills in missing entries in the DAMON
> sysfs ABI document (Documentation/ABI/testing/sysfs-kernel-mm-damon).
> 
> Patch 1 fixes a path typo, "intrvals_goal" -> "intervals_goal", in
> four What: entries; the documented path points to a non-existent
> directory, so it is Cc'ed to stable.
> 
> Patch 2 fixes two further typos ("WDate:", "manimum").
> 
> Patches 3 and 4 add ABI entries that exist in the kernel and are
> already described in usage.rst but are missing from the canonical ABI
> document: the 'update_tuned_intervals' state command (patch 3) and the
> 'tried_regions/<R>/probes/<P>/hits' file (patch 4).

Looks good overall.  Patch 3 looks unnecessary, though.  Let me add comments to
each patch.

> 
> Song Hu (4):
>   Docs/ABI/damon: fix typo in intervals_goal sysfs path
>   Docs/ABI/damon: fix typos
>   Docs/ABI/damon: document update_tuned_intervals state command
>   Docs/ABI/damon: document tried_regions probe hits
> 
>  .../ABI/testing/sysfs-kernel-mm-damon         | 29 ++++++++++++++-----
>  1 file changed, 22 insertions(+), 7 deletions(-)
> 
> -- 
> 2.43.0

[1] https://github.com/sjp38/hackermail/blob/master/USAGE.md#checking-patches
[2] https://github.com/sjp38/hackermail/blob/master/USAGE.md#formatting-patches


Thanks,
SJ

Re: [PATCH 0/4] Docs/ABI/damon: sysfs ABI document fixes and additions

[SJ Park]

On Fri, 10 Jul 2026 07:16:38 -0700 SJ Park <sj@kernel.org> wrote:

[...]
> On Fri, 10 Jul 2026 12:47:33 +0800 Song Hu <husong@kylinos.cn> wrote:
> 
> > This series fixes typos and fills in missing entries in the DAMON
> > sysfs ABI document (Documentation/ABI/testing/sysfs-kernel-mm-damon).
> > 
> > Patch 1 fixes a path typo, "intrvals_goal" -> "intervals_goal", in
> > four What: entries; the documented path points to a non-existent
> > directory, so it is Cc'ed to stable.
> > 
> > Patch 2 fixes two further typos ("WDate:", "manimum").
> > 
> > Patches 3 and 4 add ABI entries that exist in the kernel and are
> > already described in usage.rst but are missing from the canonical ABI
> > document: the 'update_tuned_intervals' state command (patch 3) and the
> > 'tried_regions/<R>/probes/<P>/hits' file (patch 4).
> 
> Looks good overall.  Patch 3 looks unnecessary, though.  Let me add comments to
> each patch.

Sorry, I was misreading patch 3.  All patches including the third one looks
good to me now.

This series is applied to damon/next [1] tree.  If this series is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]