[PATCH v1] mm/damon: remove trailing semicolons after function definitions

[PATCH v1] mm/damon: remove trailing semicolons after function definitions

[Xuewen Wang]

Three function definitions terminate with '};' instead of '}',
which is unnecessary and inconsistent with kernel coding style:

- damon_pa_initcall() in paddr.c
- damon_va_initcall() in vaddr.c
- damos_get_some_mem_psi_total() in core.c

No functional change intended.

Signed-off-by: Xuewen Wang <wangxuewen@kylinos.cn>
---
 mm/damon/core.c  | 2 +-
 mm/damon/paddr.c | 2 +-
 mm/damon/vaddr.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 7e4b9affc5b0..4197957009aa 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2579,7 +2579,7 @@ static u64 damos_get_some_mem_psi_total(void)
 static inline u64 damos_get_some_mem_psi_total(void)
 {
 	return 0;
-};
+}
 
 #endif	/* CONFIG_PSI */
 
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index d0598f5f2688..17353b14af77 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -453,6 +453,6 @@ static int __init damon_pa_initcall(void)
 	};
 
 	return damon_register_ops(&ops);
-};
+}
 
 subsys_initcall(damon_pa_initcall);
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index d27147603564..13f4e05f871b 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -983,7 +983,7 @@ static int __init damon_va_initcall(void)
 	if (err)
 		return err;
 	return damon_register_ops(&ops_fvaddr);
-};
+}
 
 subsys_initcall(damon_va_initcall);
 
-- 
2.25.1

Re: [PATCH v1] mm/damon: remove trailing semicolons after function definitions

[SJ Park]

On Tue, 14 Jul 2026 15:53:58 +0800 Xuewen Wang <wangxuewen@kylinos.cn> wrote:

> Three function definitions terminate with '};' instead of '}',
> which is unnecessary and inconsistent with kernel coding style:
> 
> - damon_pa_initcall() in paddr.c
> - damon_va_initcall() in vaddr.c
> - damos_get_some_mem_psi_total() in core.c
> 
> No functional change intended.

Nice catch!  Thank you for this patch!

> 
> Signed-off-by: Xuewen Wang <wangxuewen@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>

This series is applied to damon/next [1] tree.  If this series is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]