* Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid
[not found] <20260716091444.284702-1-lienze@kylinos.cn>
@ 2026-07-16 13:54 ` SJ Park
0 siblings, 0 replies; only message in thread
From: SJ Park @ 2026-07-16 13:54 UTC (permalink / raw)
To: Enze Li; +Cc: SJ Park, damon, linux-mm, enze.li
Hello Enze,
Thank you for this patch!
On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <lienze@kylinos.cn> wrote:
> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible
> through kernel command line usage and sysfs interface.
But... It is a static module. Is there a way to read this documentation from
the user space? If there is no such a way, I don't really think this change is
needed. If we want to document this, we could use comments.
I show 'enabled' parameter has MODULE_PARM_DESC(). If the inconsistency is a
problem, I think it might be better to consistently remove MODULE_PARM_DESC().
It may also be beneficial to comment why we don't have MODULE_PARM_DESC()s on
the module. What do you think?
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] only message in thread