From: Nikunj A Dadhania <nikunj@amd.com>
To: <ljs@kernel.org>
Cc: <akpm@linux-foundation.org>, <baolu.lu@linux.intel.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>, <david@kernel.org>,
<den@openvz.org>, <devnexen@gmail.com>, <hpa@zytor.com>,
<iommu@lists.linux.dev>, <jgg@ziepe.ca>, <jgross@suse.com>,
<jirislaby@kernel.org>, <kas@kernel.org>, <kevin.tian@intel.com>,
<liam@infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <lists@steffen.cc>, <luto@kernel.org>,
<mingo@redhat.com>, <peterz@infradead.org>, <pfalcato@suse.de>,
<rppt@kernel.org>, <shakeel.butt@linux.dev>,
<stable@vger.kernel.org>, <surenb@google.com>,
<syzbot@syzkaller.appspotmail.com>, <tglx@kernel.org>,
<toshi.kani@hpe.com>, <vbabka@kernel.org>,
<vishal.moola@gmail.com>, <will@kernel.org>, <x86@kernel.org>,
<nikunj@amd.com>, <bharata@amd.com>, <Ananth.Narayan@amd.com>
Subject: Re: [PATCH 0/5] x86/mm/pat: CPA fixes
Date: Thu, 13 Aug 2026 05:55:44 +0000 [thread overview]
Message-ID: <20260813055544.25567-1-nikunj@amd.com> (raw)
In-Reply-To: <anXvODEvV4f_Taj7@lucifer>
On Fri, Aug 07, 2026 at 04:36:08PM +0100, Lorenzo Stoakes (ARM) wrote:
> +static void poke_vmalloc_pages_safe(struct page **pages, void *addr,
> + bool cross_page_boundary)
> +{
> + guard(mmap_read_lock)(&init_mm);
> + poke_vmalloc_pages(pages, addr, cross_page_boundary);
> +}
Tested just the proposed patch from this email (without the rest of the
CPA fixes series) on the 512-guest concurrent boot harness (details in
[1]) and still see the memcmp BUG, I havent hit the first BUG though:
kernel BUG at arch/x86/kernel/alternative.c:2727!
Oops: invalid opcode: 0000 [#1] SMP NOPTI
CPU: 1 UID: 0 PID: 485 Comm: (udev-worker) Not tainted 7.2.0-rc5-pokesafe+ #42 PREEMPT(full)
RIP: 0010:__text_poke.cold+0xdb/0x2af
The instrumentation captured the following before the memcmp BUG:
SMP alternatives: __text_poke: memcmp failed at addr=ffffffffc06ce1bb len=4
SMP alternatives: __text_poke: expected (src): 2e 2e 31 c0
SMP alternatives: __text_poke: found (dst): f9 b8 9b d3
SMP alternatives: __text_poke: pfn at poke time (vmalloc_to_page): 8ece
SMP alternatives: __text_poke: pfn at readback time (vmalloc_to_page): c6ce
SMP alternatives: __text_poke: page table dump for addr:
PGD 2f042067 P4D 2f043067 PUD 2f045067 PMD c6001a1
pfn acquired at the start of __text_poke() (0x8ece) differs from pfn
at readback time (0xc6ce) in the instrumentaion.
[1] https://lore.kernel.org/all/20260812063316.21371-1-nikunj@amd.com/
Regards,
Nikunj
next prev parent reply other threads:[~2026-08-13 5:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 13:07 [PATCH 0/5] x86/mm/pat: CPA fixes Mike Rapoport (Microsoft)
2026-07-28 13:07 ` [PATCH 1/5] x86/mm/pat: introcude cpa_lock() and cpa_unlock() Mike Rapoport (Microsoft)
2026-07-28 13:13 ` Lorenzo Stoakes (ARM)
2026-07-28 14:21 ` Peter Zijlstra
2026-07-28 14:30 ` Dave Hansen
2026-07-28 14:31 ` Peter Zijlstra
2026-07-28 14:46 ` Mike Rapoport
2026-07-28 14:50 ` Lorenzo Stoakes (ARM)
2026-07-28 14:55 ` Peter Zijlstra
2026-07-28 15:01 ` Peter Zijlstra
2026-07-28 15:20 ` Lorenzo Stoakes (ARM)
2026-07-28 15:33 ` Peter Zijlstra
2026-07-28 15:54 ` Mike Rapoport
2026-07-28 15:02 ` Lorenzo Stoakes (ARM)
2026-07-28 15:30 ` Peter Zijlstra
2026-07-28 15:16 ` Peter Zijlstra
2026-07-28 16:01 ` Mike Rapoport
2026-07-28 13:07 ` [PATCH 2/5] x86/mm/pat: acquire init_mm write lock on collapse to avoid UAF Mike Rapoport
2026-07-28 13:07 ` [PATCH 3/5] x86/mm/pat: acquire init_mm read lock on attribute change " Mike Rapoport
2026-07-28 13:14 ` Lorenzo Stoakes (ARM)
2026-07-28 13:07 ` [PATCH 4/5] x86/mm/pat: allocate split page tables as kernel page tables Mike Rapoport
2026-07-28 13:07 ` [PATCH 5/5] x86/mm/pat: fix effective RW computation in lookup_address_in_pgd_attr() Mike Rapoport (Microsoft)
2026-07-28 13:11 ` [PATCH 0/5] x86/mm/pat: CPA fixes Lorenzo Stoakes (ARM)
2026-07-30 15:53 ` Steffen Dirkwinkel
2026-08-03 12:41 ` Pedro Falcato
2026-08-07 15:36 ` Lorenzo Stoakes (ARM)
2026-08-12 11:46 ` Pedro Falcato
2026-08-12 15:15 ` Mike Rapoport
2026-08-12 15:42 ` Lorenzo Stoakes (ARM)
2026-08-13 5:55 ` Nikunj A Dadhania [this message]
2026-08-13 8:51 ` Mike Rapoport
2026-08-13 9:23 ` Lorenzo Stoakes (ARM)
2026-08-13 9:24 ` Nikunj A. Dadhania
2026-08-03 15:14 ` Mike Rapoport
2026-08-07 14:34 ` Lorenzo Stoakes (ARM)
2026-08-07 15:00 ` Lorenzo Stoakes (ARM)
2026-08-12 22:20 ` Dave Hansen
2026-08-13 8:57 ` Lorenzo Stoakes (ARM)
2026-08-13 9:06 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813055544.25567-1-nikunj@amd.com \
--to=nikunj@amd.com \
--cc=Ananth.Narayan@amd.com \
--cc=akpm@linux-foundation.org \
--cc=baolu.lu@linux.intel.com \
--cc=bharata@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=den@openvz.org \
--cc=devnexen@gmail.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=jirislaby@kernel.org \
--cc=kas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lists@steffen.cc \
--cc=ljs@kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=syzbot@syzkaller.appspotmail.com \
--cc=tglx@kernel.org \
--cc=toshi.kani@hpe.com \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox