* [PATCH] mm/damon/core: remove declaration of kdamond_fn()
@ 2026-08-27 16:39 Zenghui Yu
2026-08-27 16:47 ` Zenghui Yu
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zenghui Yu @ 2026-08-27 16:39 UTC (permalink / raw)
To: damon, linux-mm, linux-kernel; +Cc: sj, akpm, Zenghui Yu (Huawei)
From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
It was added by commit 2224d8485492 ("mm: introduce Data Access MONitor
(DAMON)") but is actually not needed. Remove it.
Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
mm/damon/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 37d661e2bbc1..183080556404 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1922,8 +1922,6 @@ static unsigned long damon_apply_min_nr_regions(struct damon_ctx *ctx)
return max_region_sz;
}
-static int kdamond_fn(void *data);
-
/*
* __damon_start() - Starts monitoring with given context.
* @ctx: monitoring context
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
2026-08-27 16:39 [PATCH] mm/damon/core: remove declaration of kdamond_fn() Zenghui Yu
@ 2026-08-27 16:47 ` Zenghui Yu
2026-08-28 1:01 ` SJ Park
2026-08-28 0:54 ` kernel test robot
2026-08-28 5:33 ` kernel test robot
2 siblings, 1 reply; 5+ messages in thread
From: Zenghui Yu @ 2026-08-27 16:47 UTC (permalink / raw)
To: damon, linux-mm, linux-kernel; +Cc: sj, akpm
Please ignore this patch. This is absolutely wrong. Sorry for the noise..
On 8/28/26 12:39 AM, Zenghui Yu wrote:
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
>
> It was added by commit 2224d8485492 ("mm: introduce Data Access MONitor
> (DAMON)") but is actually not needed. Remove it.
>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> ---
> mm/damon/core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 37d661e2bbc1..183080556404 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1922,8 +1922,6 @@ static unsigned long damon_apply_min_nr_regions(struct damon_ctx *ctx)
> return max_region_sz;
> }
>
> -static int kdamond_fn(void *data);
> -
> /*
> * __damon_start() - Starts monitoring with given context.
> * @ctx: monitoring context
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
2026-08-27 16:39 [PATCH] mm/damon/core: remove declaration of kdamond_fn() Zenghui Yu
2026-08-27 16:47 ` Zenghui Yu
@ 2026-08-28 0:54 ` kernel test robot
2026-08-28 5:33 ` kernel test robot
2 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-08-28 0:54 UTC (permalink / raw)
To: Zenghui Yu, damon, linux-mm, linux-kernel
Cc: oe-kbuild-all, sj, akpm, Zenghui Yu (Huawei)
Hi Zenghui,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Zenghui-Yu/mm-damon-core-remove-declaration-of-kdamond_fn/20260828-003953
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20260827163953.83520-1-zenghui.yu%40linux.dev
patch subject: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
config: hexagon-randconfig-r052-20260828 (https://download.01.org/0day-ci/archive/20260828/202608280848.9o0Z64CP-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260828/202608280848.9o0Z64CP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608280848.9o0Z64CP-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/damon/core.c:1941:30: error: use of undeclared identifier 'kdamond_fn'
1941 | ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
| ^
1 error generated.
vim +/kdamond_fn +1941 mm/damon/core.c
b1029f29eb1d5fb SJ Park 2026-02-28 1924
2224d8485492e49 SeongJae Park 2021-09-07 1925 /*
2224d8485492e49 SeongJae Park 2021-09-07 1926 * __damon_start() - Starts monitoring with given context.
2224d8485492e49 SeongJae Park 2021-09-07 1927 * @ctx: monitoring context
2224d8485492e49 SeongJae Park 2021-09-07 1928 *
2224d8485492e49 SeongJae Park 2021-09-07 1929 * This function should be called while damon_lock is hold.
2224d8485492e49 SeongJae Park 2021-09-07 1930 *
2224d8485492e49 SeongJae Park 2021-09-07 1931 * Return: 0 on success, negative error code otherwise.
2224d8485492e49 SeongJae Park 2021-09-07 1932 */
2224d8485492e49 SeongJae Park 2021-09-07 1933 static int __damon_start(struct damon_ctx *ctx)
2224d8485492e49 SeongJae Park 2021-09-07 1934 {
2224d8485492e49 SeongJae Park 2021-09-07 1935 int err = -EBUSY;
2224d8485492e49 SeongJae Park 2021-09-07 1936
2224d8485492e49 SeongJae Park 2021-09-07 1937 mutex_lock(&ctx->kdamond_lock);
2224d8485492e49 SeongJae Park 2021-09-07 1938 if (!ctx->kdamond) {
2224d8485492e49 SeongJae Park 2021-09-07 1939 err = 0;
6376a824595607e SJ Park 2023-12-08 1940 reinit_completion(&ctx->kdamond_started);
2224d8485492e49 SeongJae Park 2021-09-07 @1941 ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
2224d8485492e49 SeongJae Park 2021-09-07 1942 nr_running_ctxs);
2224d8485492e49 SeongJae Park 2021-09-07 1943 if (IS_ERR(ctx->kdamond)) {
2224d8485492e49 SeongJae Park 2021-09-07 1944 err = PTR_ERR(ctx->kdamond);
7ec1992b891e59d Colin Ian King 2021-11-05 1945 ctx->kdamond = NULL;
6376a824595607e SJ Park 2023-12-08 1946 } else {
6376a824595607e SJ Park 2023-12-08 1947 wait_for_completion(&ctx->kdamond_started);
2224d8485492e49 SeongJae Park 2021-09-07 1948 }
2224d8485492e49 SeongJae Park 2021-09-07 1949 }
2224d8485492e49 SeongJae Park 2021-09-07 1950 mutex_unlock(&ctx->kdamond_lock);
2224d8485492e49 SeongJae Park 2021-09-07 1951
2224d8485492e49 SeongJae Park 2021-09-07 1952 return err;
2224d8485492e49 SeongJae Park 2021-09-07 1953 }
2224d8485492e49 SeongJae Park 2021-09-07 1954
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
2026-08-27 16:47 ` Zenghui Yu
@ 2026-08-28 1:01 ` SJ Park
0 siblings, 0 replies; 5+ messages in thread
From: SJ Park @ 2026-08-28 1:01 UTC (permalink / raw)
To: Zenghui Yu; +Cc: SJ Park, damon, linux-mm, linux-kernel, akpm
On Fri, 28 Aug 2026 00:47:08 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:
> Please ignore this patch. This is absolutely wrong. Sorry for the noise..
No worry. Thank you for the patch though!
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
2026-08-27 16:39 [PATCH] mm/damon/core: remove declaration of kdamond_fn() Zenghui Yu
2026-08-27 16:47 ` Zenghui Yu
2026-08-28 0:54 ` kernel test robot
@ 2026-08-28 5:33 ` kernel test robot
2 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-08-28 5:33 UTC (permalink / raw)
To: Zenghui Yu, damon, linux-mm, linux-kernel
Cc: oe-kbuild-all, sj, akpm, Zenghui Yu (Huawei)
Hi Zenghui,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Zenghui-Yu/mm-damon-core-remove-declaration-of-kdamond_fn/20260828-003953
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20260827163953.83520-1-zenghui.yu%40linux.dev
patch subject: [PATCH] mm/damon/core: remove declaration of kdamond_fn()
config: xtensa-randconfig-r073-20260828 (https://download.01.org/0day-ci/archive/20260828/202608281351.Hv386MvO-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 16.1.0
smatch: v0.5.0-9187-g5189e3fb
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260828/202608281351.Hv386MvO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608281351.Hv386MvO-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from include/linux/psi_types.h:5,
from include/linux/cgroup-defs.h:24,
from include/linux/cgroup.h:29,
from include/linux/memcontrol.h:13,
from include/linux/damon.h:10,
from mm/damon/core.c:8:
mm/damon/core.c: In function '__damon_start':
>> mm/damon/core.c:1941:44: error: 'kdamond_fn' undeclared (first use in this function)
1941 | ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
| ^~~~~~~~~~
include/linux/kthread.h:46:32: note: in definition of macro 'kthread_create'
46 | kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
| ^~~~~~~~
mm/damon/core.c:1941:32: note: in expansion of macro 'kthread_run'
1941 | ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
| ^~~~~~~~~~~
mm/damon/core.c:1941:44: note: each undeclared identifier is reported only once for each function it appears in
include/linux/kthread.h:46:32: note: in definition of macro 'kthread_create'
46 | kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
| ^~~~~~~~
mm/damon/core.c:1941:32: note: in expansion of macro 'kthread_run'
1941 | ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
| ^~~~~~~~~~~
mm/damon/core.c: At top level:
>> mm/damon/core.c:3750:12: warning: 'kdamond_fn' defined but not used [-Wunused-function]
3750 | static int kdamond_fn(void *data)
| ^~~~~~~~~~
vim +/kdamond_fn +1941 mm/damon/core.c
b1029f29eb1d5fb SJ Park 2026-02-28 1924
2224d8485492e49 SeongJae Park 2021-09-07 1925 /*
2224d8485492e49 SeongJae Park 2021-09-07 1926 * __damon_start() - Starts monitoring with given context.
2224d8485492e49 SeongJae Park 2021-09-07 1927 * @ctx: monitoring context
2224d8485492e49 SeongJae Park 2021-09-07 1928 *
2224d8485492e49 SeongJae Park 2021-09-07 1929 * This function should be called while damon_lock is hold.
2224d8485492e49 SeongJae Park 2021-09-07 1930 *
2224d8485492e49 SeongJae Park 2021-09-07 1931 * Return: 0 on success, negative error code otherwise.
2224d8485492e49 SeongJae Park 2021-09-07 1932 */
2224d8485492e49 SeongJae Park 2021-09-07 1933 static int __damon_start(struct damon_ctx *ctx)
2224d8485492e49 SeongJae Park 2021-09-07 1934 {
2224d8485492e49 SeongJae Park 2021-09-07 1935 int err = -EBUSY;
2224d8485492e49 SeongJae Park 2021-09-07 1936
2224d8485492e49 SeongJae Park 2021-09-07 1937 mutex_lock(&ctx->kdamond_lock);
2224d8485492e49 SeongJae Park 2021-09-07 1938 if (!ctx->kdamond) {
2224d8485492e49 SeongJae Park 2021-09-07 1939 err = 0;
6376a824595607e SJ Park 2023-12-08 1940 reinit_completion(&ctx->kdamond_started);
2224d8485492e49 SeongJae Park 2021-09-07 @1941 ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
2224d8485492e49 SeongJae Park 2021-09-07 1942 nr_running_ctxs);
2224d8485492e49 SeongJae Park 2021-09-07 1943 if (IS_ERR(ctx->kdamond)) {
2224d8485492e49 SeongJae Park 2021-09-07 1944 err = PTR_ERR(ctx->kdamond);
7ec1992b891e59d Colin Ian King 2021-11-05 1945 ctx->kdamond = NULL;
6376a824595607e SJ Park 2023-12-08 1946 } else {
6376a824595607e SJ Park 2023-12-08 1947 wait_for_completion(&ctx->kdamond_started);
2224d8485492e49 SeongJae Park 2021-09-07 1948 }
2224d8485492e49 SeongJae Park 2021-09-07 1949 }
2224d8485492e49 SeongJae Park 2021-09-07 1950 mutex_unlock(&ctx->kdamond_lock);
2224d8485492e49 SeongJae Park 2021-09-07 1951
2224d8485492e49 SeongJae Park 2021-09-07 1952 return err;
2224d8485492e49 SeongJae Park 2021-09-07 1953 }
2224d8485492e49 SeongJae Park 2021-09-07 1954
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-28 5:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-27 16:39 [PATCH] mm/damon/core: remove declaration of kdamond_fn() Zenghui Yu
2026-08-27 16:47 ` Zenghui Yu
2026-08-28 1:01 ` SJ Park
2026-08-28 0:54 ` kernel test robot
2026-08-28 5:33 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox