From: Christos Skarlos <christosskarlos.kernel@gmail.com>
To: akpm@linux-foundation.org, david@kernel.org,
muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org,
hannes@cmpxchg.org
Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com,
liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org,
jannh@google.com, pfalcato@suse.de, kasong@tencent.com,
qi.zheng@linux.dev, shakeel.butt@linux.dev,
axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com,
mhocko@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Christos Skarlos <christosskarlos.kernel@gmail.com>
Subject: [PATCH 3/3] mm/hugetlb: fix various coding style warnings.
Date: Sat, 5 Sep 2026 17:01:40 +0300 [thread overview]
Message-ID: <20260905140140.60792-5-christosskarlos.kernel@gmail.com> (raw)
In-Reply-To: <20260905140140.60792-1-christosskarlos.kernel@gmail.com>
Resolve coding style issues flagged by the checkpatch.pl script. Specifically:
- Fix block comment formatting to keep tailing '*/' on a separate line.
- Add missing blank lines after variable declarations.
- Remove anecessary braces {} from single statement blocks.
No functional changes where introduced.
Signed-off-by: Christos Skarlos <christosskarlos.kernel@gmail.com>
---
mm/hugetlb.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 4f6f58bf3db6..ec8e799e356e 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -145,7 +145,8 @@ static inline void unlock_or_release_subpool(struct hugepage_subpool *spool,
/* If no pages are used, and no other handles to the subpool
* remain, give up any reservations based on minimum size and
- * free the subpool */
+ * free the subpool
+ */
spin_unlock_irqrestore(&spool->lock, irq_flags);
if (free_subpool) {
@@ -3700,6 +3701,7 @@ static void try_to_free_low(struct hstate *h, unsigned long count,
for_each_node_mask(i, *nodes_allowed) {
struct folio *folio, *next;
struct list_head *freel = &h->hugepage_freelists[i];
+
list_for_each_entry_safe(folio, next, freel, lru) {
if (count >= h->nr_huge_pages)
goto out;
@@ -3764,6 +3766,7 @@ static int set_max_huge_pages(struct hstate *h, unsigned long count, int nid,
unsigned long allocated;
struct folio *folio;
LIST_HEAD(page_list);
+
NODEMASK_ALLOC(nodemask_t, node_alloc_noretry, GFP_KERNEL);
/*
@@ -4188,9 +4191,9 @@ void __init hugetlb_add_hstate(unsigned int order)
struct hstate *h;
unsigned long i;
- if (size_to_hstate(PAGE_SIZE << order)) {
+ if (size_to_hstate(PAGE_SIZE << order))
return;
- }
+
BUG_ON(hugetlb_max_hstate >= HUGE_MAX_HSTATE);
BUG_ON(order < order_base_2(__NR_USED_SUBPAGE));
WARN_ON(order > MAX_FOLIO_ORDER);
@@ -4832,11 +4835,11 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct folio *folio,
pte_t entry = folio_mk_pte(folio, vma->vm_page_prot);
unsigned int shift = huge_page_shift(hstate_vma(vma));
- if (try_mkwrite && (vma->vm_flags & VM_WRITE)) {
+ if (try_mkwrite && (vma->vm_flags & VM_WRITE))
entry = pte_mkwrite_novma(pte_mkdirty(entry));
- } else {
+ else
entry = pte_wrprotect(entry);
- }
+
entry = pte_mkyoung(entry);
entry = arch_make_huge_pte(entry, shift, vma->vm_flags);
@@ -4919,6 +4922,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
last_addr_mask = hugetlb_mask_last_page(h);
for (addr = src_vma->vm_start; addr < src_vma->vm_end; addr += sz) {
spinlock_t *src_ptl, *dst_ptl;
+
src_pte = hugetlb_walk(src_vma, addr, sz);
if (!src_pte) {
addr |= last_addr_mask;
@@ -6321,6 +6325,7 @@ int hugetlb_mfill_atomic_pte(pte_t *dst_pte,
folio = alloc_hugetlb_folio(dst_vma, dst_addr, false);
if (IS_ERR(folio)) {
pte_t *actual_pte = hugetlb_walk(dst_vma, dst_addr, PMD_SIZE);
+
if (actual_pte) {
ret = -EEXIST;
goto out;
--
2.55.0
next prev parent reply other threads:[~2026-09-05 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 14:01 [PATCH 0/3] mm: minor janitorial style cleanups Christos Skarlos
2026-09-05 14:01 ` [PATCH] mm/huge_memory: fix various coding style warnings Christos Skarlos
2026-09-05 16:07 ` Zi Yan
2026-09-05 14:01 ` [PATCH 1/3] mm/mmap: " Christos Skarlos
2026-09-05 16:19 ` Zi Yan
2026-09-05 14:01 ` [PATCH 2/3] mm/vamscan: fix various coding style warnings and errors Christos Skarlos
2026-09-05 16:22 ` Zi Yan
2026-09-05 14:01 ` Christos Skarlos [this message]
2026-09-05 16:24 ` [PATCH 3/3] mm/hugetlb: fix various coding style warnings Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905140140.60792-5-christosskarlos.kernel@gmail.com \
--to=christosskarlos.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nico.pache@linux.dev \
--cc=osalvador@suse.de \
--cc=pfalcato@suse.de \
--cc=qi.zheng@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox