From: "Zi Yan" <ziy@nvidia.com>
To: "Christos Skarlos" <christosskarlos.kernel@gmail.com>,
<akpm@linux-foundation.org>, <david@kernel.org>,
<muchun.song@linux.dev>, <osalvador@suse.de>, <ljs@kernel.org>,
<hannes@cmpxchg.org>
Cc: <baolin.wang@linux.alibaba.com>, <liam@infradead.org>,
<nico.pache@linux.dev>, <ryan.roberts@arm.com>,
<dev.jain@arm.com>, <baohua@kernel.org>, <lance.yang@linux.dev>,
<usama.arif@linux.dev>, <kas@kernel.org>, <vbabka@kernel.org>,
<jannh@google.com>, <pfalcato@suse.de>, <kasong@tencent.com>,
<qi.zheng@linux.dev>, <shakeel.butt@linux.dev>,
<axelrasmussen@google.com>, <yuanchu@google.com>,
<weixugc@google.com>, <mhocko@kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm/hugetlb: fix various coding style warnings.
Date: Sat, 05 Sep 2026 12:24:07 -0400 [thread overview]
Message-ID: <DL7ISZ2NKFSC.1R1X1VJPVOI02@nvidia.com> (raw)
In-Reply-To: <20260905140140.60792-5-christosskarlos.kernel@gmail.com>
On Sat Sep 5, 2026 at 10:01 AM EDT, Christos Skarlos wrote:
> Resolve coding style issues flagged by the checkpatch.pl script. Specifically:
> - Fix block comment formatting to keep tailing '*/' on a separate line.
> - Add missing blank lines after variable declarations.
> - Remove anecessary braces {} from single statement blocks.
>
> No functional changes where introduced.
>
> Signed-off-by: Christos Skarlos <christosskarlos.kernel@gmail.com>
> ---
> mm/hugetlb.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
<snip>
> @@ -3764,6 +3766,7 @@ static int set_max_huge_pages(struct hstate *h, unsigned long count, int nid,
> unsigned long allocated;
> struct folio *folio;
> LIST_HEAD(page_list);
> +
> NODEMASK_ALLOC(nodemask_t, node_alloc_noretry, GFP_KERNEL);
Please check the definition of NODEMASK_ALLOC. No new line is needed
here.
--
Best Regards,
Yan, Zi
prev parent reply other threads:[~2026-09-05 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 14:01 [PATCH 0/3] mm: minor janitorial style cleanups Christos Skarlos
2026-09-05 14:01 ` [PATCH] mm/huge_memory: fix various coding style warnings Christos Skarlos
2026-09-05 16:07 ` Zi Yan
2026-09-05 14:01 ` [PATCH 1/3] mm/mmap: " Christos Skarlos
2026-09-05 16:19 ` Zi Yan
2026-09-05 14:01 ` [PATCH 2/3] mm/vamscan: fix various coding style warnings and errors Christos Skarlos
2026-09-05 16:22 ` Zi Yan
2026-09-05 14:01 ` [PATCH 3/3] mm/hugetlb: fix various coding style warnings Christos Skarlos
2026-09-05 16:24 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL7ISZ2NKFSC.1R1X1VJPVOI02@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=christosskarlos.kernel@gmail.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nico.pache@linux.dev \
--cc=osalvador@suse.de \
--cc=pfalcato@suse.de \
--cc=qi.zheng@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox