* [PATCH] mm: remove PageWriteback
@ 2026-09-05 19:08 Tal Zussman
2026-09-07 14:08 ` Lorenzo Stoakes (ARM)
2026-09-07 22:04 ` SJ Park
0 siblings, 2 replies; 4+ messages in thread
From: Tal Zussman @ 2026-09-05 19:08 UTC (permalink / raw)
To: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Matthew Wilcox
Cc: linux-mm, linux-kernel, Tal Zussman
The last caller of PageWriteback() was removed in commit f75987e543c2
("libceph: remove pinning assertion in ceph_msg_data_iter_next()").
This flag is now only used on folios, so we can remove all the page
accessors. folio_test_clear_writeback() is not used, so don't add
FOLIO_TEST_CLEAR_FLAG() for it.
Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
include/linux/page-flags.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 3dc79c0c5adf..86dd0470da11 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -588,8 +588,8 @@ FOLIO_FLAG(owner_2, FOLIO_HEAD_PAGE)
* Only test-and-set exist for PG_writeback. The unconditional operators are
* risky: they bypass page accounting.
*/
-TESTPAGEFLAG(Writeback, writeback, PF_NO_TAIL)
- TESTSCFLAG(Writeback, writeback, PF_NO_TAIL)
+FOLIO_TEST_FLAG(writeback, FOLIO_HEAD_PAGE)
+ FOLIO_TEST_SET_FLAG(writeback, FOLIO_HEAD_PAGE)
FOLIO_FLAG(mappedtodisk, FOLIO_HEAD_PAGE)
/* PG_readahead is only used for reads; PG_reclaim is only for writes */
---
base-commit: b733fe31e781ed45c56d2ec561dbb61a903693c8
change-id: 20260904-remove-pagewriteback-69d2aa5b3ee9
Best regards,
--
Tal Zussman <tz2294@columbia.edu>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove PageWriteback
2026-09-05 19:08 [PATCH] mm: remove PageWriteback Tal Zussman
@ 2026-09-07 14:08 ` Lorenzo Stoakes (ARM)
2026-09-07 14:29 ` David Hildenbrand (Arm)
2026-09-07 22:04 ` SJ Park
1 sibling, 1 reply; 4+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-09-07 14:08 UTC (permalink / raw)
To: Tal Zussman
Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Matthew Wilcox, linux-mm, linux-kernel
On Sat, Sep 05, 2026 at 03:08:30PM -0400, Tal Zussman wrote:
> The last caller of PageWriteback() was removed in commit f75987e543c2
> ("libceph: remove pinning assertion in ceph_msg_data_iter_next()").
> This flag is now only used on folios, so we can remove all the page
> accessors. folio_test_clear_writeback() is not used, so don't add
> FOLIO_TEST_CLEAR_FLAG() for it.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
Nice! LGTM so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> include/linux/page-flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 3dc79c0c5adf..86dd0470da11 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -588,8 +588,8 @@ FOLIO_FLAG(owner_2, FOLIO_HEAD_PAGE)
> * Only test-and-set exist for PG_writeback. The unconditional operators are
> * risky: they bypass page accounting.
> */
> -TESTPAGEFLAG(Writeback, writeback, PF_NO_TAIL)
> - TESTSCFLAG(Writeback, writeback, PF_NO_TAIL)
> +FOLIO_TEST_FLAG(writeback, FOLIO_HEAD_PAGE)
> + FOLIO_TEST_SET_FLAG(writeback, FOLIO_HEAD_PAGE)
> FOLIO_FLAG(mappedtodisk, FOLIO_HEAD_PAGE)
>
> /* PG_readahead is only used for reads; PG_reclaim is only for writes */
>
> ---
> base-commit: b733fe31e781ed45c56d2ec561dbb61a903693c8
> change-id: 20260904-remove-pagewriteback-69d2aa5b3ee9
>
> Best regards,
> --
> Tal Zussman <tz2294@columbia.edu>
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove PageWriteback
2026-09-07 14:08 ` Lorenzo Stoakes (ARM)
@ 2026-09-07 14:29 ` David Hildenbrand (Arm)
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand (Arm) @ 2026-09-07 14:29 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM), Tal Zussman
Cc: Andrew Morton, Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Matthew Wilcox, linux-mm,
linux-kernel
On 9/7/26 16:08, Lorenzo Stoakes (ARM) wrote:
> On Sat, Sep 05, 2026 at 03:08:30PM -0400, Tal Zussman wrote:
>> The last caller of PageWriteback() was removed in commit f75987e543c2
>> ("libceph: remove pinning assertion in ceph_msg_data_iter_next()").
>> This flag is now only used on folios, so we can remove all the page
>> accessors. folio_test_clear_writeback() is not used, so don't add
>> FOLIO_TEST_CLEAR_FLAG() for it.
>>
>> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
>
> Nice! LGTM so:
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Indeed!
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: remove PageWriteback
2026-09-05 19:08 [PATCH] mm: remove PageWriteback Tal Zussman
2026-09-07 14:08 ` Lorenzo Stoakes (ARM)
@ 2026-09-07 22:04 ` SJ Park
1 sibling, 0 replies; 4+ messages in thread
From: SJ Park @ 2026-09-07 22:04 UTC (permalink / raw)
To: Tal Zussman
Cc: SJ Park, Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Matthew Wilcox, linux-mm,
linux-kernel
On Sat, 05 Sep 2026 15:08:30 -0400 Tal Zussman <tz2294@columbia.edu> wrote:
> The last caller of PageWriteback() was removed in commit f75987e543c2
> ("libceph: remove pinning assertion in ceph_msg_data_iter_next()").
> This flag is now only used on folios, so we can remove all the page
> accessors. folio_test_clear_writeback() is not used, so don't add
> FOLIO_TEST_CLEAR_FLAG() for it.
Looks good to me.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
Reviewed-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-07 22:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 19:08 [PATCH] mm: remove PageWriteback Tal Zussman
2026-09-07 14:08 ` Lorenzo Stoakes (ARM)
2026-09-07 14:29 ` David Hildenbrand (Arm)
2026-09-07 22:04 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox