Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <baoquan.he@linux.dev>
Cc: Baoquan He <hebaoquan@kylinos.cn>,
	linux-mm@kvack.org, hch@lst.de, harry@kernel.org
Subject: Re: [PATCH 00/13] Don't use GFP_DMA when calling dma_alloc_coherent
Date: Mon, 28 Sep 2026 17:07:56 -0700	[thread overview]
Message-ID: <20260928170756.815406182a70947276446122@linux-foundation.org> (raw)
In-Reply-To: <aroZD9TBlOKoprQm@MiWiFi-R3L-srv>

On Mon, 28 Sep 2026 15:36:47 +0800 Baoquan He <baoquan.he@linux.dev> wrote:

> On 09/03/26 at 07:18pm, Baoquan He wrote:
> > This series picks up the first part of an earlier cleanup series [1] that
> > was prepared back in the year of 2022, but for various reasons never made
> > it merged and has been sitting in a local tree since then. This subset
> > only touches the call sites where GFP_DMA is passed to dma_alloc_coherent()
> > (and its dma_alloc_wc()/dmam_alloc_coherent() variants), which is the most
> > self-contained and least risky slice of that work.
> > 
> > That GFP_DMA is simply redundant here: the DMA API derives the allocation
> > zone from the device's coherent_dma_mask (together with bus_dma_limit) and
> > ignores the GFP_DMA flag passed by the caller. 
> > 
> > Removing the redundant GFP_DMA won't harm anything, while keeps it from
> > being blindly copied into new code.
> 
> Gentle ping!
> 
> Wondering if Andrew can help take this, or anyone else I can add this to
> ask for help.

oof, mm.git is overflowing and I'm trying to stem the flood.

But this series is so modest so what the heck.

I actually kinda prefer that this sort of thing be done in a single
"treewide: " patch.  It reduces the patch count and reduces the chance
that a driver maintainer will cherrypick a random patch from mid-series
instead of saying "ack".  But many disagree with me!


  reply	other threads:[~2026-09-29  0:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 11:18 [PATCH 00/13] Don't use GFP_DMA when calling dma_alloc_coherent Baoquan He
2026-09-03 11:18 ` [PATCH 01/13] gpu: ipu-v3: Don't use GFP_DMA when calling dma_alloc_coherent() Baoquan He
2026-09-03 11:18 ` [PATCH 02/13] drm/sti: Don't use GFP_DMA when calling dma_alloc_wc() Baoquan He
2026-09-03 11:18 ` [PATCH 03/13] ALSA: n64: Don't use GFP_DMA when calling dma_alloc_coherent() Baoquan He
2026-09-03 11:18 ` [PATCH 04/13] spi: spi-ti-qspi: " Baoquan He
2026-09-03 11:18 ` [PATCH 05/13] fbdev: fsl-diu-fb: Don't use GFP_DMA when calling dmam_alloc_coherent() Baoquan He
2026-09-03 11:18 ` [PATCH 06/13] usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling dma_alloc_coherent() Baoquan He
2026-09-03 11:18 ` [PATCH 07/13] usb: cdns3: " Baoquan He
2026-09-03 11:18 ` [PATCH 08/13] media: staging: imx: " Baoquan He
2026-09-03 11:18 ` [PATCH 09/13] spi: atmel: " Baoquan He
2026-09-03 11:18 ` [PATCH 10/13] media: imx7-media-csi: " Baoquan He
2026-09-04 15:14   ` Frank Li
2026-09-03 11:18 ` [PATCH 11/13] media: nxp: imx8-isi: " Baoquan He
2026-09-04 15:14   ` Frank Li
2026-09-03 11:18 ` [PATCH 12/13] mtd: rawnand: gpmi: " Baoquan He
2026-09-03 11:18 ` [PATCH 13/13] usb: cdns2: " Baoquan He
2026-09-28  7:36 ` [PATCH 00/13] Don't use GFP_DMA when calling dma_alloc_coherent Baoquan He
2026-09-29  0:07   ` Andrew Morton [this message]
2026-09-29  2:14     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928170756.815406182a70947276446122@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=harry@kernel.org \
    --cc=hch@lst.de \
    --cc=hebaoquan@kylinos.cn \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox