Re: [PATCH 00/13] Don't use GFP_DMA when calling dma_alloc_coherent

[Baoquan He <baoquan.he@linux.dev>]

Hi,

On 09/03/26 at 07:18pm, Baoquan He wrote:
> This series picks up the first part of an earlier cleanup series [1] that
> was prepared back in the year of 2022, but for various reasons never made
> it merged and has been sitting in a local tree since then. This subset
> only touches the call sites where GFP_DMA is passed to dma_alloc_coherent()
> (and its dma_alloc_wc()/dmam_alloc_coherent() variants), which is the most
> self-contained and least risky slice of that work.
> 
> That GFP_DMA is simply redundant here: the DMA API derives the allocation
> zone from the device's coherent_dma_mask (together with bus_dma_limit) and
> ignores the GFP_DMA flag passed by the caller. 
> 
> Removing the redundant GFP_DMA won't harm anything, while keeps it from
> being blindly copied into new code.

Gentle ping!

Wondering if Andrew can help take this, or anyone else I can add this to
ask for help.

Thanks
Baoquan

> 
> [1]
> [PATCH 00/22] Don't use kmalloc() with GFP_DMA
> https://lore.kernel.org/all/20220219005221.634-1-bhe@redhat.com/T/#u
> 
> 
> Baoquan He (13):
>   gpu: ipu-v3: Don't use GFP_DMA when calling dma_alloc_coherent()
>   drm/sti: Don't use GFP_DMA when calling dma_alloc_wc()
>   ALSA: n64: Don't use GFP_DMA when calling dma_alloc_coherent()
>   spi: spi-ti-qspi: Don't use GFP_DMA when calling dma_alloc_coherent()
>   fbdev: fsl-diu-fb: Don't use GFP_DMA when calling
>     dmam_alloc_coherent()
>   usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling
>     dma_alloc_coherent()
>   usb: cdns3: Don't use GFP_DMA when calling dma_alloc_coherent()
>   media: staging: imx: Don't use GFP_DMA when calling
>     dma_alloc_coherent()
>   spi: atmel: Don't use GFP_DMA when calling dma_alloc_coherent()
>   media: imx7-media-csi: Don't use GFP_DMA when calling
>     dma_alloc_coherent()
>   media: nxp: imx8-isi: Don't use GFP_DMA when calling
>     dma_alloc_coherent()
>   mtd: rawnand: gpmi: Don't use GFP_DMA when calling
>     dma_alloc_coherent()
>   usb: cdns2: Don't use GFP_DMA when calling dma_alloc_coherent()
> 
>  drivers/gpu/drm/sti/sti_cursor.c                     | 4 ++--
>  drivers/gpu/drm/sti/sti_hqvdp.c                      | 2 +-
>  drivers/gpu/ipu-v3/ipu-image-convert.c               | 2 +-
>  drivers/media/platform/nxp/imx7-media-csi.c          | 2 +-
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c | 2 +-
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c           | 2 +-
>  drivers/spi/spi-atmel.c                              | 4 ++--
>  drivers/spi/spi-ti-qspi.c                            | 2 +-
>  drivers/staging/media/imx/imx-media-utils.c          | 2 +-
>  drivers/usb/cdns3/cdns3-gadget.c                     | 2 +-
>  drivers/usb/gadget/udc/cdns2/cdns2-gadget.c          | 2 +-
>  drivers/usb/gadget/udc/lpc32xx_udc.c                 | 2 +-
>  drivers/video/fbdev/fsl-diu-fb.c                     | 2 +-
>  sound/mips/snd-n64.c                                 | 2 +-
>  14 files changed, 16 insertions(+), 16 deletions(-)
> 
> -- 
> 2.54.0
> 
>