From: SJ Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SJ Park <sj@kernel.org>,
muchun.song@linux.dev, osalvador@suse.de, david@kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [PATCH] mm/hugetlb_cma: remove two unused include files
Date: Thu, 8 Oct 2026 04:22:14 -0700 [thread overview]
Message-ID: <20261008112215.43826-1-sj@kernel.org> (raw)
In-Reply-To: <20261005142040.675204-1-lienze@kylinos.cn>
On Mon, 5 Oct 2026 22:20:40 +0800 Enze Li <lienze@kylinos.cn> wrote:
> hugetlb_cma.c includes <linux/mm_inline.h> and <asm/setup.h> but never
> uses anything from them, so they can be dropped.
Makes sense to me.
>
> Found with clang-tidy (misc-include-cleaner). This holds regardless of
> config: the file's only #ifdef is CONFIG_NUMA, and it only touches memblock
> helpers, so removing these is safe on all arches.
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
Reviewed-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-10-08 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 14:20 [PATCH] mm/hugetlb_cma: remove two unused include files Enze Li
2026-10-06 13:46 ` Muchun Song
2026-10-08 11:22 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008112215.43826-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=enze.li@gmx.com \
--cc=lienze@kylinos.cn \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox