Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Enze Li <lienze@kylinos.cn>
Cc: osalvador@suse.de, david@kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [PATCH] mm/hugetlb_cma: remove two unused include files
Date: Tue, 6 Oct 2026 15:46:21 +0200	[thread overview]
Message-ID: <BD7EEACA-71CE-4919-B60B-5767EDFE035C@linux.dev> (raw)
In-Reply-To: <20261005142040.675204-1-lienze@kylinos.cn>



> On Oct 5, 2026, at 16:20, Enze Li <lienze@kylinos.cn> wrote:
> 
> hugetlb_cma.c includes <linux/mm_inline.h> and <asm/setup.h> but never
> uses anything from them, so they can be dropped.
> 
> Found with clang-tidy (misc-include-cleaner).  This holds regardless of
> config: the file's only #ifdef is CONFIG_NUMA, and it only touches memblock
> helpers, so removing these is safe on all arches.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

I'm inclined to believe clang-tidy tool.

Acked-by: Muchun Song <muchun.song@linux.dev>

Thanks.



  reply	other threads:[~2026-10-06 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 14:20 [PATCH] mm/hugetlb_cma: remove two unused include files Enze Li
2026-10-06 13:46 ` Muchun Song [this message]
2026-10-08 11:22 ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BD7EEACA-71CE-4919-B60B-5767EDFE035C@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=enze.li@gmx.com \
    --cc=lienze@kylinos.cn \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox