* [PATCH] selftests/exec: report the skipped binfmt_misc_bpf test on stderr
@ 2026-10-14 20:01 Sasha Levin
2026-10-15 4:34 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2026-10-14 20:01 UTC (permalink / raw)
To: Kees Cook
Cc: Sasha Levin, Farid Zakaria, Christian Brauner, Shuah Khan,
linux-mm, linux-kselftest, linux-kernel
The exec Makefile announces that binfmt_misc_bpf is skipped with
$(info), which writes to standard output whenever the Makefile is
parsed. The selftests install target appends the standard output of
"make -s emit_tests" to kselftest-list.txt, so on systems without the
BPF toolchain the runlist gains a line that is not a test entry:
exec selftests: skipping binfmt_misc_bpf, needs clang, bpftool, ...
run_kselftest.sh and CI systems that parse the runlist then treat it as
a malformed test entry.
Use $(warning) so that the notice still appears in build logs but goes
to standard error.
Fixes: 277d787feb2e ("selftests/exec: add binfmt_misc bpf-backed handler test")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
tools/testing/selftests/exec/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
index 2220ed345e920..91decfa8ff2c1 100644
--- a/tools/testing/selftests/exec/Makefile
+++ b/tools/testing/selftests/exec/Makefile
@@ -67,7 +67,7 @@ TEST_GEN_FILES += bpf_interp.bpf.o nix_origin.bpf.o transparent.bpf.o
TEST_GEN_FILES += loader.bpf.o interp_bind.bpf.o
TEST_GEN_FILES += binfmt_bpf_interp binfmt_bpf_app binfmt_bind_interp
else
-$(info exec selftests: skipping binfmt_misc_bpf, needs clang, bpftool, vmlinux BTF and libbpf)
+$(warning exec selftests: skipping binfmt_misc_bpf, needs clang, bpftool, vmlinux BTF and libbpf)
endif
EXTRA_CLEAN := $(OUTPUT)/subdir.moved $(OUTPUT)/execveat.moved $(OUTPUT)/xxxxx* \
base-commit: 4eb2586bd40db27d77cc5b724ca9386ed0c71d53
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] selftests/exec: report the skipped binfmt_misc_bpf test on stderr
2026-10-14 20:01 [PATCH] selftests/exec: report the skipped binfmt_misc_bpf test on stderr Sasha Levin
@ 2026-10-15 4:34 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2026-10-15 4:34 UTC (permalink / raw)
To: Sasha Levin
Cc: Kees Cook, Farid Zakaria, Christian Brauner, Shuah Khan, linux-mm,
linux-kselftest, linux-kernel
On Wed, 14 Oct 2026 16:01:35 -0400, Sasha Levin wrote:
> The exec Makefile announces that binfmt_misc_bpf is skipped with
> $(info), which writes to standard output whenever the Makefile is
> parsed. The selftests install target appends the standard output of
> "make -s emit_tests" to kselftest-list.txt, so on systems without the
> BPF toolchain the runlist gains a line that is not a test entry:
>
> exec selftests: skipping binfmt_misc_bpf, needs clang, bpftool, ...
>
> [...]
Applied to for-next/execve, thanks!
[1/1] selftests/exec: report the skipped binfmt_misc_bpf test on stderr
https://git.kernel.org/kees/c/b36b990c50b1
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-15 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14 20:01 [PATCH] selftests/exec: report the skipped binfmt_misc_bpf test on stderr Sasha Levin
2026-10-15 4:34 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox