Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Duplicate Text] in mm/damon/ and Doc/admin-guide/mm/damon/
@ 2026-10-17 15:32 Manuel Ebner
  2026-10-17 16:29 ` SJ Park
  0 siblings, 1 reply; 2+ messages in thread
From: Manuel Ebner @ 2026-10-17 15:32 UTC (permalink / raw)
  To: SJ Park, damon
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, linux-mm, linux-doc,
	linux-kernel, Aveline Noir, Adrian Huang (Lenovo)

Hi SJ,

there is a lot of duplicated text in these directories. Diff doesn't show
any because in mm/damon/ the text is a multi-line comment.

~40 Lines in lru_sort.c and lru_sort.rst,
~50 Lines in reclaim.c and reclaim.rst and
a few Lines in stat.c and stat.rst.

I think it's important to decide on how to handle the duplication before
patching.

Delete one set, keep (and fix) both or add a reference in one place to
the other? Could sphinx do the duplication?

Thanks
 Manuel 


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [Duplicate Text] in mm/damon/ and Doc/admin-guide/mm/damon/
  2026-10-17 15:32 [Duplicate Text] in mm/damon/ and Doc/admin-guide/mm/damon/ Manuel Ebner
@ 2026-10-17 16:29 ` SJ Park
  0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-10-17 16:29 UTC (permalink / raw)
  To: Manuel Ebner
  Cc: SJ Park, damon, Jonathan Corbet, Shuah Khan, Randy Dunlap,
	linux-mm, linux-doc, linux-kernel, Aveline Noir,
	Adrian Huang (Lenovo)

On Sat, 17 Oct 2026 17:32:47 +0200 Manuel Ebner <manuelebnerli@mailbox.org> wrote:

> Hi SJ,
> 
> there is a lot of duplicated text in these directories. Diff doesn't show
> any because in mm/damon/ the text is a multi-line comment.
> 
> ~40 Lines in lru_sort.c and lru_sort.rst,
> ~50 Lines in reclaim.c and reclaim.rst and
> a few Lines in stat.c and stat.rst.
> 
> I think it's important to decide on how to handle the duplication before
> patching.
> 
> Delete one set, keep (and fix) both or add a reference in one place to
> the other? Could sphinx do the duplication?

Let's keep and fix both for now.  We can consider deduplicating if it turns out
to be too much overhead.  I don't feel so yet.


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-17 16:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-17 15:32 [Duplicate Text] in mm/damon/ and Doc/admin-guide/mm/damon/ Manuel Ebner
2026-10-17 16:29 ` SJ Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox