Re: Sashiko change proposal

[SJ Park <sj@kernel.org>]

On Sun, 18 Oct 2026 15:48:28 -0700 SJ Park <sj@kernel.org> wrote:

> On Fri, 16 Oct 2026 14:39:49 +0000 Roman Gushchin <roman.gushchin@linux.dev> wrote:
> 
> > "David Hildenbrand (Arm)" <david@kernel.org> writes:
> > 
> > > On 10/16/26 02:15, Roman Gushchin wrote:
> > >> Yosry Ahmed <yosry@kernel.org> writes:
> > >> 
> > >>> On Thu, Oct 15, 2026 at 1:38 AM David Hildenbrand (Arm)
> > >>> <david@kernel.org> wrote:
> [...]
> > >>>> I suggest the following sashiko change for linux-mm:
> > >>>>
> > >>>> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> > >>>> index a9198de..ba123da 100644
> > >>>> --- a/projects/linux/mailing_lists.toml
> > >>>> +++ b/projects/linux/mailing_lists.toml
> > >>>> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
> > >>>>  ["linux-integrity@vger.kernel.org"]
> > >>>>  ["linux-kernel@vger.kernel.org"]
> > >>>>  ["linux-kselftest@vger.kernel.org"]
> > >>>> -["linux-mm@kvack.org"]
> > >>>>  ["linux-nvme@lists.infradead.org"]
> > >>>>  ["linux-omap@vger.kernel.org"]
> > >>>>  ["linux-pm@vger.kernel.org"]
> > >>>> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
> > >>>>
> > >>>>  ["fsverity@lists.linux.dev"]
> > >>>>  reply_to = ["author", "list", "recipients"]
> > >>>> +
> > >>>> +["linux-mm@kvack.org"]
> > >>>> +reply_to = ["author", "list", "recipients"]
> > >>>> +embargo_hours = 24
> > >>>>
> > >>>>
> > >>>> Which means:
> > >>>> - Embargo 24h
> > >>>> - Mails sent to everybody (author, list, CC list)
> > >>>> - No positive-review ("looks great") mails (default)
> > >>>> - No other static email addresses that receive a copy (default)
> > >>>> - No additional ignored author email addresses (default)
> [...]
> > https://github.com/sashiko-dev/sashiko/pull/699/ , landed.
> > 
> > I'll roll it out later today.
> 
> Now linux-mm@ and damon@ has slightly different configs.  damon@ has no
> embabrgo but send mails to only the author and the mailing list.  It is a
> faster but narrower-scoped delivery setup.
> 
> I was assuming linux-mm@ side change will not make any change to damon@ side,
> but apparently it is not.  DAMON patches Cc linux-mm@, and seems it results in
> applying linux-mm@ side setup.  For example, this patch [1] got a sashiko
> review, but it was marked as embargo on sashiko.dev.  I found and clicked a
> button for releasing it.  It resulted in sending the review mail to all
> recipients, not just the author and damon@ mailing list.  Correct me if I'm
> wrong.
> 
> Could we keep the old behavior for DAMON patches?  For example, let damon@
> setup to override linux-mm@ setup for DAMON patches.  After a second thought, I
> realize this would be not very simple.  Identifying if a given patch is for
> DAMON or not is implicit.  Maybe we could see if the subject contains "damon"
> keyword...?  Still not perfect but maybe work for most cases?

I just found sashiko has a feature, subject_prefixes [1], which seems designed
for this case.  I should have read document carefully.  Based on my current
understanding, I uploaded a PR [2].  Please let me knwo if I'm misunderstanding
something.

> 
> For now, I will release damon@ patch reviews as soon as I find.  I don't mind
> clicking the button multiple times, but I'm slightly concerned if someone might
> be distracted, because DAMON patch review mails will be delivered to not only
> the author and damon@ list but all recipients.  Please let me know if that
> really distracts you.  Let's find a way if that's the case.
> 
> [1] https://lore.kernel.org/20261018220253.158238-1-sj@kernel.org/

[1] https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md?plain=1#L60
[2] https://github.com/sashiko-dev/sashiko/pull/711


Thanks,
SJ

[...]