Re: [PATCH v3 5/6] KEYS: Replace assoc

Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed

* Re: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
       [not found] <20261025001105.1824178-6-jarkko@kernel.org>
@ 2026-10-28  7:28 ` kernel test robot
  2026-10-28 20:13   ` Jarkko Sakkinen
  2026-10-29  8:43 ` kernel test robot
  1 sibling, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-10-28  7:28 UTC (permalink / raw)
  To: Jarkko Sakkinen, David Howells
  Cc: llvm, oe-kbuild-all, keyrings, Eric Biggers, Jarkko Sakkinen,
	Andrew Morton, Linux Memory Management List, Thomas Graf,
	Herbert Xu, Paul Moore, James Morris, Serge E. Hallyn,
	linux-kernel, linux-crypto, linux-security-module

Hi Jarkko,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[cannot apply to akpm-mm/mm-nonmm-unstable manguebit/cifs-next manguebit/cifs-fixes device-mapper-dm/for-next fsverity/for-next fsverity/for-current shuah-kselftest/next shuah-kselftest/fixes dhowells-fs/fscache-next dhowells-fs/keys-next v7.3 next-20261027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jarkko-Sakkinen/KEYS-Expand-key-datalen-quotalen-to-unsigned-int/20261025-031009
base:   linus/master
patch link:    https://lore.kernel.org/r/20261025001105.1824178-6-jarkko%40kernel.org
patch subject: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20261028/202610281546.OMDCubFW-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 186e70f4e6a1521991d2340d3d49b23b1beff11f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261028/202610281546.OMDCubFW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610281546.OMDCubFW-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
>> kernel/bpf/keys.c:32:30: error: no member named 'keys' in 'struct key'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                        ~~~~~~~~~~~  ^
   7 errors generated.


vim +32 kernel/bpf/keys.c

abaa0835b4f3810 Daniel Borkmann 2026-08-28  25  
264d8fd2794fabe Daniel Borkmann 2026-08-28  26  struct bpf_key *bpf_lookup_keyring(void)
264d8fd2794fabe Daniel Borkmann 2026-08-28  27  {
264d8fd2794fabe Daniel Borkmann 2026-08-28  28  	struct bpf_key *bkey;
264d8fd2794fabe Daniel Borkmann 2026-08-28  29  
264d8fd2794fabe Daniel Borkmann 2026-08-28  30  	if (!bpf_keyring)
264d8fd2794fabe Daniel Borkmann 2026-08-28  31  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28 @32  	if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
264d8fd2794fabe Daniel Borkmann 2026-08-28  33  	    !READ_ONCE(bpf_keyring->restrict_link))
264d8fd2794fabe Daniel Borkmann 2026-08-28  34  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28  35  
264d8fd2794fabe Daniel Borkmann 2026-08-28  36  	bkey = kmalloc_obj(*bkey);
264d8fd2794fabe Daniel Borkmann 2026-08-28  37  	if (!bkey)
264d8fd2794fabe Daniel Borkmann 2026-08-28  38  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28  39  
264d8fd2794fabe Daniel Borkmann 2026-08-28  40  	bkey->key = bpf_keyring;
264d8fd2794fabe Daniel Borkmann 2026-08-28  41  	bkey->has_ref = false;
264d8fd2794fabe Daniel Borkmann 2026-08-28  42  	return bkey;
264d8fd2794fabe Daniel Borkmann 2026-08-28  43  }
264d8fd2794fabe Daniel Borkmann 2026-08-28  44  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
  2026-10-28  7:28 ` [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable kernel test robot
@ 2026-10-28 20:13   ` Jarkko Sakkinen
  0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2026-10-28 20:13 UTC (permalink / raw)
  To: kernel test robot
  Cc: David Howells, llvm, oe-kbuild-all, keyrings, Eric Biggers,
	Andrew Morton, Linux Memory Management List, Thomas Graf,
	Herbert Xu, Paul Moore, James Morris, Serge E. Hallyn,
	linux-kernel, linux-crypto, linux-security-module

On Wed, Oct 28, 2026 at 03:28:38PM +0800, kernel test robot wrote:
> Hi Jarkko,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on linus/master]
> [cannot apply to akpm-mm/mm-nonmm-unstable manguebit/cifs-next manguebit/cifs-fixes device-mapper-dm/for-next fsverity/for-next fsverity/for-current shuah-kselftest/next shuah-kselftest/fixes dhowells-fs/fscache-next dhowells-fs/keys-next v7.3 next-20261027]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Jarkko-Sakkinen/KEYS-Expand-key-datalen-quotalen-to-unsigned-int/20261025-031009
> base:   linus/master
> patch link:    https://lore.kernel.org/r/20261025001105.1824178-6-jarkko%40kernel.org
> patch subject: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20261028/202610281546.OMDCubFW-lkp@intel.com/config)
> compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 186e70f4e6a1521991d2340d3d49b23b1beff11f)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261028/202610281546.OMDCubFW-lkp@intel.com/reproduce)

This is expected as at the time when I sent the patch set I did not have 
BPF changes yet.

Br, Jarkko


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
       [not found] <20261025001105.1824178-6-jarkko@kernel.org>
  2026-10-28  7:28 ` [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable kernel test robot
@ 2026-10-29  8:43 ` kernel test robot
  1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-10-29  8:43 UTC (permalink / raw)
  To: Jarkko Sakkinen, David Howells
  Cc: oe-kbuild-all, keyrings, Eric Biggers, Jarkko Sakkinen,
	Andrew Morton, Linux Memory Management List, Thomas Graf,
	Herbert Xu, Paul Moore, James Morris, Serge E. Hallyn,
	linux-kernel, linux-crypto, linux-security-module

Hi Jarkko,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[cannot apply to akpm-mm/mm-nonmm-unstable manguebit/cifs-next manguebit/cifs-fixes device-mapper-dm/for-next fsverity/for-next fsverity/for-current shuah-kselftest/next shuah-kselftest/fixes dhowells-fs/fscache-next dhowells-fs/keys-next v7.3 next-20261028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jarkko-Sakkinen/KEYS-Expand-key-datalen-quotalen-to-unsigned-int/20261025-031009
base:   linus/master
patch link:    https://lore.kernel.org/r/20261025001105.1824178-6-jarkko%40kernel.org
patch subject: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20261029/202610291634.MckYHsJq-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261029/202610291634.MckYHsJq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610291634.MckYHsJq-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <command-line>:
   kernel/bpf/keys.c: In function 'bpf_lookup_keyring':
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
     682 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
     702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |                            ^~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
     682 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
     702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |                            ^~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
     682 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
     702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |                            ^~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
     682 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
     702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |                            ^~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:682:23: note: in definition of macro '__compiletime_assert'
     682 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:702:9: note: in expansion of macro '_compiletime_assert'
     702 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/linux/compiler_types.h:635:53: note: in definition of macro '__unqual_scalar_typeof'
     635 | #define __unqual_scalar_typeof(x) __typeof_unqual__(x)
         |                                                     ^
   include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
      50 |         __READ_ONCE(x);                                                 \
         |         ^~~~~~~~~~~
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~
   In file included from ./arch/x86/include/generated/asm/rwonce.h:1,
                    from include/linux/compiler.h:391,
                    from include/uapi/linux/filter.h:9,
                    from include/linux/bpf.h:8,
                    from kernel/bpf/keys.c:4:
>> kernel/bpf/keys.c:32:35: error: 'struct key' has no member named 'keys'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |                                   ^~
   include/asm-generic/rwonce.h:44:73: note: in definition of macro '__READ_ONCE'
      44 | #define __READ_ONCE(x)  (*(const volatile __unqual_scalar_typeof(x) *)&(x))
         |                                                                         ^
   kernel/bpf/keys.c:32:14: note: in expansion of macro 'READ_ONCE'
      32 |         if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
         |              ^~~~~~~~~


vim +32 kernel/bpf/keys.c

abaa0835b4f3810 Daniel Borkmann 2026-08-28  25  
264d8fd2794fabe Daniel Borkmann 2026-08-28  26  struct bpf_key *bpf_lookup_keyring(void)
264d8fd2794fabe Daniel Borkmann 2026-08-28  27  {
264d8fd2794fabe Daniel Borkmann 2026-08-28  28  	struct bpf_key *bkey;
264d8fd2794fabe Daniel Borkmann 2026-08-28  29  
264d8fd2794fabe Daniel Borkmann 2026-08-28  30  	if (!bpf_keyring)
264d8fd2794fabe Daniel Borkmann 2026-08-28  31  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28 @32  	if (!READ_ONCE(bpf_keyring->keys.nr_leaves_on_tree) ||
264d8fd2794fabe Daniel Borkmann 2026-08-28  33  	    !READ_ONCE(bpf_keyring->restrict_link))
264d8fd2794fabe Daniel Borkmann 2026-08-28  34  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28  35  
264d8fd2794fabe Daniel Borkmann 2026-08-28  36  	bkey = kmalloc_obj(*bkey);
264d8fd2794fabe Daniel Borkmann 2026-08-28  37  	if (!bkey)
264d8fd2794fabe Daniel Borkmann 2026-08-28  38  		return NULL;
264d8fd2794fabe Daniel Borkmann 2026-08-28  39  
264d8fd2794fabe Daniel Borkmann 2026-08-28  40  	bkey->key = bpf_keyring;
264d8fd2794fabe Daniel Borkmann 2026-08-28  41  	bkey->has_ref = false;
264d8fd2794fabe Daniel Borkmann 2026-08-28  42  	return bkey;
264d8fd2794fabe Daniel Borkmann 2026-08-28  43  }
264d8fd2794fabe Daniel Borkmann 2026-08-28  44  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-29  8:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261025001105.1824178-6-jarkko@kernel.org>
2026-10-28  7:28 ` [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable kernel test robot
2026-10-28 20:13   ` Jarkko Sakkinen
2026-10-29  8:43 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox