* [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters
@ 2026-11-16 11:06 Jason Angelov
2026-11-16 11:06 ` [PATCH v2 1/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter() Jason Angelov
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Jason Angelov @ 2026-11-16 11:06 UTC (permalink / raw)
To: SJ Park, Andrew Morton; +Cc: damon, linux-mm, linux-kernel, Jason Angelov
The DAMON core tests do not cover DAMOS_FILTER_TYPE_AGE_MS. Add tests for
committing valid and invalid age ranges, identifying the filter as
core-handled, and matching ages at and outside the range boundaries.
Region age is counted in aggregation intervals, but age_ms filter bounds
are in milliseconds. The interval-change test checks filter matching
after both increasing and decreasing the aggregation interval.
Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
---
Changes in v2:
- Fix commit-message formatting, line wrapping, and comments.
- Set age and interval inputs directly in patch 3.
- Add SJ's Reviewed-by tags to patches 1 and 2.
- Link to v1: https://lore.kernel.org/r/20261113-test-age-ms-filter-v1-0-b99eab2f71bb@ucla.edu
---
Jason Angelov (3):
mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter()
mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops()
mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes
mm/damon/tests/core-kunit.h | 93 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 93 insertions(+)
---
base-commit: daed51c9105158768a3949395135aa6e0a04bb7e
change-id: 20261112-test-age-ms-filter-9953843e7204
Best regards,
--
Jason Angelov <jasonangelov@ucla.edu>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter()
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
@ 2026-11-16 11:06 ` Jason Angelov
2026-11-16 11:06 ` [PATCH v2 2/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops() Jason Angelov
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Jason Angelov @ 2026-11-16 11:06 UTC (permalink / raw)
To: SJ Park, Andrew Morton; +Cc: damon, linux-mm, linux-kernel, Jason Angelov
Add kunit tests that commit DAMOS core filter type
DAMOS_FILTER_TYPE_AGE_MS.
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
---
mm/damon/tests/core-kunit.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index a5ca4bfe2f0d..0eb5dcdba0ae 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1271,6 +1271,10 @@ static void damos_test_commit_filter_for(struct kunit *test,
KUNIT_EXPECT_EQ(test, dst->matching, src->matching);
KUNIT_EXPECT_EQ(test, dst->allow, src->allow);
switch (src->type) {
+ case DAMOS_FILTER_TYPE_AGE_MS:
+ KUNIT_EXPECT_EQ(test, dst->range_min, src->range_min);
+ KUNIT_EXPECT_EQ(test, dst->range_max, src->range_max);
+ break;
case DAMOS_FILTER_TYPE_MEMCG:
KUNIT_EXPECT_EQ(test, dst->memcg_id, src->memcg_id);
break;
@@ -1304,6 +1308,22 @@ static void damos_test_commit_filter(struct kunit *test)
.allow = false,
};
+ damos_test_commit_filter_for(test, &dst,
+ &(struct damos_filter){
+ .type = DAMOS_FILTER_TYPE_AGE_MS,
+ .matching = true,
+ .allow = true,
+ .range_min = 36,
+ .range_max = 14
+ }, true);
+ damos_test_commit_filter_for(test, &dst,
+ &(struct damos_filter){
+ .type = DAMOS_FILTER_TYPE_AGE_MS,
+ .matching = true,
+ .allow = true,
+ .range_min = 14,
+ .range_max = 36
+ }, false);
damos_test_commit_filter_for(test, &dst,
&(struct damos_filter){
.type = DAMOS_FILTER_TYPE_ANON,
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops()
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
2026-11-16 11:06 ` [PATCH v2 1/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter() Jason Angelov
@ 2026-11-16 11:06 ` Jason Angelov
2026-11-16 11:06 ` [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes Jason Angelov
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Jason Angelov @ 2026-11-16 11:06 UTC (permalink / raw)
To: SJ Park, Andrew Morton; +Cc: damon, linux-mm, linux-kernel, Jason Angelov
DAMOS_FILTER_TYPE_AGE_MS is core filter, not ops filter.
Add kunit test covering this rejection.
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
---
mm/damon/tests/core-kunit.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 0eb5dcdba0ae..156f74832c40 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1832,6 +1832,12 @@ static void damon_test_valid_probe_params(struct kunit *test)
damon_destroy_ctx(ctx);
}
+static void damos_test_age_ms_filter_is_core(struct kunit *test)
+{
+ KUNIT_EXPECT_FALSE(test,
+ damos_filter_for_ops(DAMOS_FILTER_TYPE_AGE_MS));
+}
+
static void damos_test_filter_out(struct kunit *test)
{
struct damon_target *t;
@@ -2593,6 +2599,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_commit_ctx),
KUNIT_CASE(damon_test_commit_ctx_keeps_quota),
KUNIT_CASE(damon_test_valid_probe_params),
+ KUNIT_CASE(damos_test_age_ms_filter_is_core),
KUNIT_CASE(damos_test_filter_out),
KUNIT_CASE(damos_test_apply_scheme_filtered_sz),
KUNIT_CASE(damos_test_apply_scheme_filter_sz_unchanged),
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
2026-11-16 11:06 ` [PATCH v2 1/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter() Jason Angelov
2026-11-16 11:06 ` [PATCH v2 2/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops() Jason Angelov
@ 2026-11-16 11:06 ` Jason Angelov
2026-11-16 15:22 ` SJ Park
2026-11-16 11:25 ` [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Aveline Noir
2026-11-16 15:28 ` SJ Park
4 siblings, 1 reply; 7+ messages in thread
From: Jason Angelov @ 2026-11-16 11:06 UTC (permalink / raw)
To: SJ Park, Andrew Morton; +Cc: damon, linux-mm, linux-kernel, Jason Angelov
DAMOS_FILTER_TYPE_AGE_MS defines an inclusive range for age in
milliseconds to filter for target regions. Aggregation interval can be
changed by users or intervals auto-tuning features.
Add a kunit test for each:
- convert region age to milliseconds, correct behavior at boundaries
for defined filter range
- DAMOS_FILTER_TYPE_AGE_MS filter keeps correct behavior even when
aggregation interval changes
Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
---
mm/damon/tests/core-kunit.h | 66 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 156f74832c40..3b2b745b8546 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1838,6 +1838,71 @@ static void damos_test_age_ms_filter_is_core(struct kunit *test)
damos_filter_for_ops(DAMOS_FILTER_TYPE_AGE_MS));
}
+static void damos_test_age_ms_filter_interval_changes(struct kunit *test)
+{
+ struct damos_filter filter = {
+ .type = DAMOS_FILTER_TYPE_AGE_MS,
+ .matching = true,
+ .range_min = 200,
+ .range_max = 400,
+ };
+ struct damon_ctx *ctx;
+ struct damon_target *t;
+ struct damon_region *r;
+ int err;
+
+ ctx = damon_new_ctx();
+ if (!ctx)
+ kunit_skip(test, "ctx alloc fail");
+ t = damon_new_target();
+ if (!t) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "target alloc fail");
+ }
+ damon_add_target(ctx, t);
+ r = damon_new_region(0, DAMON_MIN_REGION_SZ);
+ if (!r) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "region alloc fail");
+ }
+ damon_add_region(r, t);
+ ctx->attrs.aggr_interval = 100000;
+
+ /* An age of 100 ms is below the 200 ms lower bound. */
+ r->age = 1;
+ KUNIT_EXPECT_FALSE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ /* An age of 200 ms matches the inclusive lower bound. */
+ r->age = 2;
+ KUNIT_EXPECT_TRUE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ /* At a 200 ms interval, age 1 matches the lower bound. */
+ ctx->attrs.aggr_interval = 200000;
+ r->age = 1;
+ KUNIT_EXPECT_TRUE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ /* An age of 400 ms matches the inclusive upper bound. */
+ r->age = 2;
+ KUNIT_EXPECT_TRUE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ /* At a 50 ms interval, age 8 matches the upper bound. */
+ ctx->attrs.aggr_interval = 50000;
+ r->age = 8;
+ KUNIT_EXPECT_TRUE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ /* An age of 450 ms exceeds the 400 ms upper bound. */
+ r->age = 9;
+ KUNIT_EXPECT_FALSE(test, damos_filter_match(ctx, t, r, &filter,
+ ctx->min_region_sz, &err));
+
+ damon_destroy_ctx(ctx);
+}
+
static void damos_test_filter_out(struct kunit *test)
{
struct damon_target *t;
@@ -2600,6 +2665,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_commit_ctx_keeps_quota),
KUNIT_CASE(damon_test_valid_probe_params),
KUNIT_CASE(damos_test_age_ms_filter_is_core),
+ KUNIT_CASE(damos_test_age_ms_filter_interval_changes),
KUNIT_CASE(damos_test_filter_out),
KUNIT_CASE(damos_test_apply_scheme_filtered_sz),
KUNIT_CASE(damos_test_apply_scheme_filter_sz_unchanged),
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
` (2 preceding siblings ...)
2026-11-16 11:06 ` [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes Jason Angelov
@ 2026-11-16 11:25 ` Aveline Noir
2026-11-16 15:28 ` SJ Park
4 siblings, 0 replies; 7+ messages in thread
From: Aveline Noir @ 2026-11-16 11:25 UTC (permalink / raw)
To: Jason Angelov
Cc: Andrew Morton, damon, linux-kernel, linux-mm, sashiko-bot,
sashiko-reviews, SJ Park
Hi Jason,
On Mon, 16 Nov 2026 03:06:20 -0800 Jason Angelov wrote:
> The DAMON core tests do not cover DAMOS_FILTER_TYPE_AGE_MS. Add tests for
> committing valid and invalid age ranges, identifying the filter as
> core-handled, and matching ages at and outside the range boundaries.
LGTM, thanks for adding these tests :)
Reviewed-by: Aveline Noir <jm5905938@gmail.com>
Thanks,
Aveline Noir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes
2026-11-16 11:06 ` [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes Jason Angelov
@ 2026-11-16 15:22 ` SJ Park
0 siblings, 0 replies; 7+ messages in thread
From: SJ Park @ 2026-11-16 15:22 UTC (permalink / raw)
To: Jason Angelov; +Cc: SJ Park, Andrew Morton, damon, linux-mm, linux-kernel
Hi Jason,
On Mon, 16 Nov 2026 03:06:23 -0800 Jason Angelov <jasonangelov@ucla.edu> wrote:
> DAMOS_FILTER_TYPE_AGE_MS defines an inclusive range for age in
> milliseconds to filter for target regions. Aggregation interval can be
> changed by users or intervals auto-tuning features.
>
> Add a kunit test for each:
>
> - convert region age to milliseconds, correct behavior at boundaries
> for defined filter range
> - DAMOS_FILTER_TYPE_AGE_MS filter keeps correct behavior even when
> aggregation interval changes
Looks good to me.
>
> Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
Reviewed-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
` (3 preceding siblings ...)
2026-11-16 11:25 ` [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Aveline Noir
@ 2026-11-16 15:28 ` SJ Park
4 siblings, 0 replies; 7+ messages in thread
From: SJ Park @ 2026-11-16 15:28 UTC (permalink / raw)
To: Jason Angelov; +Cc: SJ Park, Andrew Morton, damon, linux-mm, linux-kernel
Hello Jason,
On Mon, 16 Nov 2026 03:06:20 -0800 Jason Angelov <jasonangelov@ucla.edu> wrote:
> The DAMON core tests do not cover DAMOS_FILTER_TYPE_AGE_MS. Add tests for
> committing valid and invalid age ranges, identifying the filter as
> core-handled, and matching ages at and outside the range boundaries.
>
> Region age is counted in aggregation intervals, but age_ms filter bounds
> are in milliseconds. The interval-change test checks filter matching
> after both increasing and decreasing the aggregation interval.
>
> Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
> ---
> Changes in v2:
> - Fix commit-message formatting, line wrapping, and comments.
> - Set age and interval inputs directly in patch 3.
> - Add SJ's Reviewed-by tags to patches 1 and 2.
> - Link to v1: https://lore.kernel.org/r/20261113-test-age-ms-filter-v1-0-b99eab2f71bb@ucla.edu
From next time, please reply to comments on previous version and share plan to
the post next revision, before posting the next revision.
>
> ---
> Jason Angelov (3):
> mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter()
> mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops()
> mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes
All patches look good to me, thank you for this patch series, Jason.
This series is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-11-16 15:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 11:06 [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Jason Angelov
2026-11-16 11:06 ` [PATCH v2 1/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_test_commit_filter() Jason Angelov
2026-11-16 11:06 ` [PATCH v2 2/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS in damos_filter_for_ops() Jason Angelov
2026-11-16 11:06 ` [PATCH v2 3/3] mm/damon/tests/core-kunit: test DAMOS_FILTER_TYPE_AGE_MS interval changes Jason Angelov
2026-11-16 15:22 ` SJ Park
2026-11-16 11:25 ` [PATCH v2 0/3] mm/damon/tests: add KUnit coverage for age_ms filters Aveline Noir
2026-11-16 15:28 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox