* [PATCH] mm/damon/tests/core-kunit: add test for damon_call() on obsolete ctx
@ 2026-11-17 17:22 Sailesh Nandanavanam
2026-11-18 2:18 ` SJ Park
0 siblings, 1 reply; 2+ messages in thread
From: Sailesh Nandanavanam @ 2026-11-17 17:22 UTC (permalink / raw)
To: sj; +Cc: damon, linux-mm, linux-kernel, Sailesh Nandanavanam
A newly allocated damon_ctx has call_controls_obsolete set, meaning no
kdamond is available to handle call requests. damon_call() should
return -ECANCELED in that case instead of queueing the request and
waiting forever. Add a kunit test for that.
Signed-off-by: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
---
mm/damon/tests/core-kunit.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 43e2f950f8ff..13315291f69f 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -2481,6 +2481,24 @@ static void damon_test_last_region_quota_reset(struct kunit *test)
damon_free_target(t);
}
+static void damon_test_call_controls_obsolete(struct kunit *test)
+{
+ struct damon_ctx *ctx;
+ struct damon_call_control control = {};
+ int ret;
+
+ ctx = damon_new_ctx();
+
+ if (!ctx)
+ kunit_skip(test, "ctx alloc fail");
+
+ ret = damon_call(ctx, &control);
+
+ KUNIT_EXPECT_EQ(test, ret, -ECANCELED);
+
+ damon_destroy_ctx(ctx);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -2525,6 +2543,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_rand),
KUNIT_CASE(damos_test_esz_goal_temporal),
KUNIT_CASE(damon_test_last_region_quota_reset),
+ KUNIT_CASE(damon_test_call_controls_obsolete),
{},
};
base-commit: 72e1cd73734bc4d52affbf7896389bf3814bcf9d
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/damon/tests/core-kunit: add test for damon_call() on obsolete ctx
2026-11-17 17:22 [PATCH] mm/damon/tests/core-kunit: add test for damon_call() on obsolete ctx Sailesh Nandanavanam
@ 2026-11-18 2:18 ` SJ Park
0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-11-18 2:18 UTC (permalink / raw)
To: Sailesh Nandanavanam; +Cc: SJ Park, damon, linux-mm, linux-kernel
On Tue, 17 Nov 2026 22:52:19 +0530 Sailesh Nandanavanam <saileshnandanavanam@gmail.com> wrote:
> A newly allocated damon_ctx has call_controls_obsolete set, meaning no
> kdamond is available to handle call requests. damon_call() should
> return -ECANCELED in that case instead of queueing the request and
> waiting forever. Add a kunit test for that.
Please check my suggestions on the reply [1] to your another patch.
[1] https://lore.kernel.org/20261118014632.95656-1-sj@kernel.org
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 17:22 [PATCH] mm/damon/tests/core-kunit: add test for damon_call() on obsolete ctx Sailesh Nandanavanam
2026-11-18 2:18 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox