Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dev Jain <dev.jain@arm.com>
To: Shivank Garg <shivankg@amd.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
	Kemeng Shi <shikemeng@huaweicloud.com>,
	Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
	Barry Song <baohua@kernel.org>,
	Youngjun Park <youngjun.park@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
	Pedro Falcato <pfalcato@suse.de>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h
Date: Thu, 19 Nov 2026 10:01:36 +0530	[thread overview]
Message-ID: <2750d7ef-57b3-4a4c-bddc-840ab35ef45d@arm.com> (raw)
In-Reply-To: <15d75748-9baa-43d9-96e0-0e49c8e27be3@arm.com>



On 18/11/26 9:41 pm, Dev Jain wrote:
> 
> 
> On 17/11/26 12:46 pm, Shivank Garg wrote:
>> invalidate_remote_inode() lost its last user in commit d73065e60dcc
>> ("afs: Use alternative invalidation to using launder_folio").
>> mapping_clear_release_always() has no callers.
> 
> That was added in b4fa966f03b7401ceacd4ffd7227197afb2b8376.
> 
>>
>> Signed-off-by: Shivank Garg <shivankg@amd.com>
>> ---
> 
> Reviewed-by: Dev Jain <dev.jain@arm.com>

... with the commit message improved.


> 
> 
>>  include/linux/pagemap.h | 11 -----------
>>  1 file changed, 11 deletions(-)
>>
>> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
>> index 73af18a37367..e681a7ba6642 100644
>> --- a/include/linux/pagemap.h
>> +++ b/include/linux/pagemap.h
>> @@ -20,12 +20,6 @@ struct folio_batch;
>>  unsigned long invalidate_mapping_pages(struct address_space *mapping,
>>  					pgoff_t start, pgoff_t end);
>>  
>> -static inline void invalidate_remote_inode(struct inode *inode)
>> -{
>> -	if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
>> -	    S_ISLNK(inode->i_mode))
>> -		invalidate_mapping_pages(inode->i_mapping, 0, -1);
>> -}
>>  int invalidate_inode_pages2(struct address_space *mapping);
>>  int invalidate_inode_pages2_range(struct address_space *mapping,
>>  		pgoff_t start, pgoff_t end);
>> @@ -298,11 +292,6 @@ static inline void mapping_set_release_always(struct address_space *mapping)
>>  	set_bit(AS_RELEASE_ALWAYS, &mapping->flags);
>>  }
>>  
>> -static inline void mapping_clear_release_always(struct address_space *mapping)
>> -{
>> -	clear_bit(AS_RELEASE_ALWAYS, &mapping->flags);
>> -}
>> -
>>  static inline bool mapping_stable_writes(const struct address_space *mapping)
>>  {
>>  	return test_bit(AS_STABLE_WRITES, &mapping->flags);
>>
> 



  reply	other threads:[~2026-11-19  4:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:16 [PATCH mm-new v2 0/5] mm: remove unused functions Shivank Garg
2026-11-17  7:16 ` [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h Shivank Garg
2026-11-17 10:01   ` Barry Song
2026-11-18 16:11   ` Dev Jain
2026-11-19  4:31     ` Dev Jain [this message]
2026-11-19  5:21   ` Garg, Shivank
2026-11-17  7:16 ` [PATCH mm-new v2 2/5] mm/swapops: remove unused make_guard_swp_entry() Shivank Garg
2026-11-17 10:02   ` Barry Song
2026-11-19  4:32   ` Dev Jain
2026-11-19  5:23   ` Garg, Shivank
2026-11-17  7:16 ` [PATCH mm-new v2 3/5] mm/swap: remove unused folio_to_swp_tb() Shivank Garg
2026-11-17 10:03   ` Barry Song
2026-11-18 16:13   ` Dev Jain
2026-11-18 16:23   ` Nhat Pham
2026-11-17  7:16 ` [PATCH mm-new v2 4/5] mm/zsmalloc: remove unused zpdesc_lock() Shivank Garg
2026-11-17 10:04   ` Barry Song
2026-11-18  2:17   ` Sergey Senozhatsky
2026-11-19  4:36   ` Dev Jain
2026-11-17  7:16 ` [PATCH mm-new v2 5/5] mm: nommu: remove unused heap_stack_gap Shivank Garg
2026-11-17 10:07   ` Barry Song
2026-11-19  4:38   ` Dev Jain
2026-11-18 17:05 ` [PATCH mm-new v2 0/5] mm: remove unused functions Dev Jain
2026-11-18 17:14   ` Dev Jain
2026-11-18 18:55     ` Garg, Shivank
2026-11-19  3:55       ` Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2750d7ef-57b3-4a4c-bddc-840ab35ef45d@arm.com \
    --to=dev.jain@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=kasong@tencent.com \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=pfalcato@suse.de \
    --cc=senozhatsky@chromium.org \
    --cc=shikemeng@huaweicloud.com \
    --cc=shivankg@amd.com \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox