From: "Garg, Shivank" <shivankg@amd.com>
To: "pfalcato@suse.de" <pfalcato@suse.de>,
"nphamcs@gmail.com" <nphamcs@gmail.com>,
"chrisl@kernel.org" <chrisl@kernel.org>,
"shikemeng@huaweicloud.com" <shikemeng@huaweicloud.com>,
"vbabka@kernel.org" <vbabka@kernel.org>,
"willy@infradead.org" <willy@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"youngjun.park@lge.com" <youngjun.park@lge.com>,
"jack@suse.cz" <jack@suse.cz>,
"minchan@kernel.org" <minchan@kernel.org>,
"baohua@kernel.org" <baohua@kernel.org>,
"liam@infradead.org" <liam@infradead.org>,
"kasong@tencent.com" <kasong@tencent.com>,
"jannh@google.com" <jannh@google.com>,
"ljs@kernel.org" <ljs@kernel.org>,
"baoquan.he@linux.dev" <baoquan.he@linux.dev>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h
Date: Thu, 19 Nov 2026 05:21:26 +0000 [thread overview]
Message-ID: <2b2042f2f32202fab77e256a2c71fa7963811ad0.camel@amd.com> (raw)
In-Reply-To: <20261117-unused-sym-mm-v2-1-2f845e94dd50@amd.com>
On Tue, 2026-11-17 at 07:16 +0000, Shivank Garg wrote:
> invalidate_remote_inode() lost its last user in commit d73065e60dcc
> ("afs: Use alternative invalidation to using launder_folio").
> mapping_clear_release_always() has no callers.
>
> Signed-off-by: Shivank Garg <shivankg@amd.com>
> ---
> include/linux/pagemap.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 73af18a37367..e681a7ba6642 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -20,12 +20,6 @@ struct folio_batch;
> unsigned long invalidate_mapping_pages(struct address_space *mapping,
> pgoff_t start, pgoff_t end);
>
> -static inline void invalidate_remote_inode(struct inode *inode)
> -{
> - if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> - S_ISLNK(inode->i_mode))
> - invalidate_mapping_pages(inode->i_mapping, 0, -1);
> -}
> int invalidate_inode_pages2(struct address_space *mapping);
> int invalidate_inode_pages2_range(struct address_space *mapping,
> pgoff_t start, pgoff_t end);
> @@ -298,11 +292,6 @@ static inline void mapping_set_release_always(struct address_space *mapping)
> set_bit(AS_RELEASE_ALWAYS, &mapping->flags);
> }
>
> -static inline void mapping_clear_release_always(struct address_space *mapping)
> -{
> - clear_bit(AS_RELEASE_ALWAYS, &mapping->flags);
> -}
> -
> static inline bool mapping_stable_writes(const struct address_space *mapping)
> {
> return test_bit(AS_STABLE_WRITES, &mapping->flags);
Hi Willy,
I checked now that MAINTAINERS lists for pagemap.h to your tree
git://git.infradead.org/users/willy/pagecache.git
Rest of this series files go through Andrew's tree.
What would you prefer: should I send this patch separately, rebased on your
tree, or is it fine to keep it in this series for Andrew to pick up?
As suggested by Dev, additional info to fold into commit:
mapping_clear_release_always() was added in b4fa966f03b7 ("mm, netfs,
fscache: stop read optimisation when folio removed from pagecache") and
never had a caller. Earlier version of had called it from ->evict_inode()
but V4 dropped those calls as unnecessary [1] leaving the helper.
[1] https://lore.kernel.org/all/166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk
Thanks,
Shivank
next prev parent reply other threads:[~2026-11-19 5:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:16 [PATCH mm-new v2 0/5] mm: remove unused functions Shivank Garg
2026-11-17 7:16 ` [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h Shivank Garg
2026-11-17 10:01 ` Barry Song
2026-11-18 16:11 ` Dev Jain
2026-11-19 4:31 ` Dev Jain
2026-11-19 5:21 ` Garg, Shivank [this message]
2026-11-17 7:16 ` [PATCH mm-new v2 2/5] mm/swapops: remove unused make_guard_swp_entry() Shivank Garg
2026-11-17 10:02 ` Barry Song
2026-11-19 4:32 ` Dev Jain
2026-11-19 5:23 ` Garg, Shivank
2026-11-17 7:16 ` [PATCH mm-new v2 3/5] mm/swap: remove unused folio_to_swp_tb() Shivank Garg
2026-11-17 10:03 ` Barry Song
2026-11-18 16:13 ` Dev Jain
2026-11-18 16:23 ` Nhat Pham
2026-11-17 7:16 ` [PATCH mm-new v2 4/5] mm/zsmalloc: remove unused zpdesc_lock() Shivank Garg
2026-11-17 10:04 ` Barry Song
2026-11-18 2:17 ` Sergey Senozhatsky
2026-11-19 4:36 ` Dev Jain
2026-11-17 7:16 ` [PATCH mm-new v2 5/5] mm: nommu: remove unused heap_stack_gap Shivank Garg
2026-11-17 10:07 ` Barry Song
2026-11-19 4:38 ` Dev Jain
2026-11-18 17:05 ` [PATCH mm-new v2 0/5] mm: remove unused functions Dev Jain
2026-11-18 17:14 ` Dev Jain
2026-11-18 18:55 ` Garg, Shivank
2026-11-19 3:55 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b2042f2f32202fab77e256a2c71fa7963811ad0.camel@amd.com \
--to=shivankg@amd.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=chrisl@kernel.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=senozhatsky@chromium.org \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox