From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Pratyush Mallick <pratmal@google.com>, SJ Park <sj@kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Greg Thelen <gthelen@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Mike Rapoport <rppt@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_reporting: Add page_reporting_delay_ms sysctl
Date: Mon, 27 Jul 2026 16:00:46 +0200 [thread overview]
Message-ID: <3da27fde-25dc-4cb8-8e05-74cd26fc2f7c@kernel.org> (raw)
In-Reply-To: <CALHaPKd_Ytknjg7GFBXeQK8kXvE7DhbyX_een7k5Fti-ahxL0A@mail.gmail.com>
On 7/25/26 20:17, Pratyush Mallick wrote:
>> Why don't you make the lengths of the line and the section title same?
> Will fix the RST underline length.
>
>> So it is milliseconds. Why don't you add the unit to the name, like
>> page_reporting_delay_ms?
> Agreed, I'll rename the sysctl to page_reporting_delay_ms.
> Also I think it would better to make this a module param to be consistent
> with page_reporting_order.
>
>> Also, coule you elaborate why there is 10 seconds maximum limit? What's the
>> problem of having no limit, and why 10 seconds is the reasonable one?
> I don't have a strong justification for where the maximum limit should be set.
> The value is unsigned int, so it's bounded at UINT_MAX ms (~49.7 days)
> So at worst the worker just schedules that far out and reporting
> is effectively paused for that window.
> I'll drop this in V3.
As long as we don't trigger a report as part of the delay change in this patch
set, I'm fine without a MAX.
--
Cheers,
David
prev parent reply other threads:[~2026-07-27 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 21:15 [PATCH v2] mm/page_reporting: Add page_reporting_delay_ms sysctl pratmal
2026-07-22 22:54 ` Andrew Morton
2026-07-25 17:52 ` Pratyush Mallick
2026-07-23 0:06 ` SJ Park
2026-07-25 18:17 ` Pratyush Mallick
2026-07-27 14:00 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da27fde-25dc-4cb8-8e05-74cd26fc2f7c@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=corbet@lwn.net \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pratmal@google.com \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox