From: Muchun Song <muchun.song@linux.dev>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Li Zhe <lizhe.67@bytedance.com>,
Andrew Popple <apopple@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
James Houghton <jthoughton@google.com>,
Lance Yang <lance.yang@linux.dev>, Qi Zheng <qi.zheng@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization
Date: Tue, 17 Nov 2026 11:13:42 +0800 [thread overview]
Message-ID: <44fc03e4-a545-465b-a7f4-174be2038884@linux.dev> (raw)
In-Reply-To: <179482576829.2379196.2091312590305150578.b4-review@b4>
On 2026/11/16 18:42, Mike Rapoport wrote:
> Hi,
Hi Mike,
>> Several struct page fields have the same initial values for every page in
>> a zone. __init_single_page() initializes this state as part of its
>> per-page setup, while the shared vmemmap tail path open-codes only a
>> subset.
>>
>> Factor the PFN-independent state into memmap_init_page_common() and use
>> it for both regular and shared tail struct pages. Keep section-, PFN-
>> and instance-specific initialization in __init_single_page().
>>
>> This also initializes the last cpupid and KASAN tag for shared tail
>> struct pages consistently with regular struct pages.
>>
>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>> ---
>> v2:
>> - Remove __meminit from memmap_init_page_common() so HVO shared tail
>> pages can call it after init text is freed (reported by Sashiko).
>> ---
>> include/linux/mm.h | 8 --------
>> mm/mm_init.c | 22 +++++++++++++++++-----
>> mm/mm_init.h | 1 +
>> mm/sparse-vmemmap.c | 7 +------
>> 4 files changed, 19 insertions(+), 19 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 77b5d450fe45b..2e182498898ec 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -3022,14 +3022,6 @@ static inline void set_page_node(struct page *page, unsigned long node)
>> page->flags.f |= (node & NODES_MASK) << NODES_PGSHIFT;
>> }
>>
>> -static inline void set_page_links(struct page *page, enum zone_type zone,
>> - unsigned long node, unsigned long pfn)
>> -{
>> - set_page_zone(page, zone);
>> - set_page_node(page, node);
>> - set_page_section_from_pfn(page, pfn);
>> -}
>> -
>> /**
>> * folio_nr_pages - The number of pages in the folio.
>> * @folio: The folio.
>> diff --git a/mm/mm_init.c b/mm/mm_init.c
>> index af3b81733193b..d0a11989bd249 100644
>> --- a/mm/mm_init.c
>> +++ b/mm/mm_init.c
>> @@ -602,15 +602,27 @@ static inline void vmemmap_optimization_verify_zone(struct page *page)
>> page_zone_id(page));
>> }
>>
>> -void __meminit __init_single_page(struct page *page, unsigned long pfn,
>> - unsigned long zone, int nid)
>> +/* Initialize PFN-independent fields common to pages in the same zone. */
>> +void memmap_init_page_common(struct page *page, enum zone_type zone, int nid)
> I don't think _common adds much here, memmap_init_page() would do.
Naming is difficult. I'm fine with memmap_init_page.
>
>> {
>> mm_zero_struct_page(page);
>> - set_page_links(page, zone, nid, pfn);
>> - init_page_count(page);
>> - atomic_set(&page->_mapcount, -1);
>> + set_page_zone(page, zone);
>> + set_page_node(page, nid);
>> page_cpupid_reset_last(page);
>> page_kasan_tag_reset(page);
>> + atomic_set(&page->_mapcount, -1);
>> +#ifdef CONFIG_ZONE_DEVICE
>> + if (zone == ZONE_DEVICE)
>> + __SetPageReserved(page);
>> +#endif
> Can't we keep this in ZONE_DEVICE part?
We can. But I put it here because there are at least two places where
we need to mark a ZONE_DEVICE page as reserved. Handling it in
memmap_init_page_common is simpler — it reduces the number of places
where we have to set reserved individually. Otherwise, we would need
to explicitly set reserved in multiple places.
>
> If we can't, __init_single_page() sets PG_reserved for ZONE_DEVICE pages
> and the
>
> if (zone == ZONE_DEVICE)
> __SetPageReserved(page);
>
> in the MEMINIT_HOTPLUG part of memmap_init_range() becomes redundant.
>
Good catch. I think I could remove this redundancy next version if you
think handing it in memmap_init_page_common is okay.
Thanks,
Muchun
next prev parent reply other threads:[~2026-11-17 3:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:34 [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Muchun Song
2026-11-13 3:34 ` [PATCH v2 01/14] mm/mm_init: factor out memmap_init_page_from_template() Muchun Song
2026-11-16 4:40 ` Lance Yang
2026-11-13 3:34 ` [PATCH v2 02/14] mm/hugetlb: optimize bootmem hugepage tail vmemmap init Muchun Song
2026-11-13 4:07 ` sashiko-bot
2026-11-13 4:10 ` Muchun Song
2026-11-16 7:55 ` Lance Yang
2026-11-16 10:42 ` Mike Rapoport
2026-11-13 3:34 ` [PATCH v2 03/14] mm/mm_init: verify zones for template-initialized pages Muchun Song
2026-11-16 8:41 ` Lance Yang
2026-11-13 3:34 ` [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization Muchun Song
2026-11-16 10:42 ` Mike Rapoport
2026-11-17 2:50 ` Muchun Song
2026-11-17 3:13 ` Muchun Song [this message]
2026-11-13 3:34 ` [PATCH v2 05/14] mm/mm_init: simplify zone device " Muchun Song
2026-11-13 3:34 ` [PATCH v2 06/14] mm/mm_init: factor out frozen compound " Muchun Song
2026-11-16 10:42 ` Mike Rapoport
2026-11-17 3:11 ` Muchun Song
2026-11-13 3:34 ` [PATCH v2 07/14] mm/hugetlb: drop boot-time HVO handling for gigantic folios Muchun Song
2026-11-13 3:34 ` [PATCH v2 08/14] mm/hugetlb: initialize all struct pages for bootmem hugepages Muchun Song
2026-11-13 3:34 ` [PATCH v2 09/14] mm/hugetlb: use common compound page initialization helper Muchun Song
2026-11-13 3:34 ` [PATCH v2 10/14] mm/mm_init: make __init_single_page() static Muchun Song
2026-11-13 3:34 ` [PATCH v2 11/14] mm/mm_init: make memmap_init_page_from_template() static Muchun Song
2026-11-13 3:34 ` [PATCH v2 12/14] mm/cma: centralize CMA pageblock initialization Muchun Song
2026-11-13 4:07 ` sashiko-bot
2026-11-13 5:47 ` Muchun Song
2026-11-13 3:34 ` [PATCH v2 13/14] mm/cma: localize init_cma_pageblock() to cma.c Muchun Song
2026-11-13 3:34 ` [PATCH v2 14/14] mm/mm_init: move pageblock migratetype init to memmap helpers Muchun Song
2026-11-16 4:20 ` [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Lance Yang
2026-11-16 10:42 ` Mike Rapoport
2026-11-16 11:17 ` Li Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44fc03e4-a545-465b-a7f4-174be2038884@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=jthoughton@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhe.67@bytedance.com \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox