* [PATCH] docs: locking: Fix bracket
@ 2026-09-02 14:39 Manuel Ebner
2026-09-02 14:58 ` Jan Kara
2026-09-07 16:43 ` Jonathan Corbet
0 siblings, 2 replies; 4+ messages in thread
From: Manuel Ebner @ 2026-09-02 14:39 UTC (permalink / raw)
To: Matthew Wilcox (Oracle), Jan Kara, Jonathan Corbet, Shuah Khan
Cc: Manuel Ebner, linux-fsdevel, linux-mm, linux-doc, linux-kernel
Remove needless '(' from code block.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Should I also replace ')(' with ') (' as it is in the second code block?
It would improve readability in my opinion.
---
Documentation/filesystems/locking.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
index 844d65eb4..1598cf555 100644
--- a/Documentation/filesystems/locking.rst
+++ b/Documentation/filesystems/locking.rst
@@ -27,7 +27,7 @@ prototypes::
int (*d_init)(struct dentry *);
void (*d_release)(struct dentry *);
void (*d_iput)(struct dentry *, struct inode *);
- char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
+ char *(*d_dname)(struct dentry *dentry, char *buffer, int buflen);
struct vfsmount *(*d_automount)(struct path *path);
int (*d_manage)(const struct path *, bool);
struct dentry *(*d_real)(struct dentry *, enum d_real_type type);
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: locking: Fix bracket
2026-09-02 14:39 [PATCH] docs: locking: Fix bracket Manuel Ebner
@ 2026-09-02 14:58 ` Jan Kara
2026-09-02 17:13 ` Randy Dunlap
2026-09-07 16:43 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Jan Kara @ 2026-09-02 14:58 UTC (permalink / raw)
To: Manuel Ebner
Cc: Matthew Wilcox (Oracle), Jan Kara, Jonathan Corbet, Shuah Khan,
linux-fsdevel, linux-mm, linux-doc, linux-kernel
On Wed 02-09-26 16:39:38, Manuel Ebner wrote:
> Remove needless '(' from code block.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> Should I also replace ')(' with ') (' as it is in the second code block?
> It would improve readability in my opinion.
Dunno, at least I'm used to the way which is written here :)
Honza
> ---
> Documentation/filesystems/locking.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> index 844d65eb4..1598cf555 100644
> --- a/Documentation/filesystems/locking.rst
> +++ b/Documentation/filesystems/locking.rst
> @@ -27,7 +27,7 @@ prototypes::
> int (*d_init)(struct dentry *);
> void (*d_release)(struct dentry *);
> void (*d_iput)(struct dentry *, struct inode *);
> - char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
> + char *(*d_dname)(struct dentry *dentry, char *buffer, int buflen);
> struct vfsmount *(*d_automount)(struct path *path);
> int (*d_manage)(const struct path *, bool);
> struct dentry *(*d_real)(struct dentry *, enum d_real_type type);
> --
> 2.54.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: locking: Fix bracket
2026-09-02 14:58 ` Jan Kara
@ 2026-09-02 17:13 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-09-02 17:13 UTC (permalink / raw)
To: Jan Kara, Manuel Ebner
Cc: Matthew Wilcox (Oracle), Jonathan Corbet, Shuah Khan,
linux-fsdevel, linux-mm, linux-doc, linux-kernel
On 9/2/26 7:58 AM, Jan Kara wrote:
> On Wed 02-09-26 16:39:38, Manuel Ebner wrote:
>> Remove needless '(' from code block.
>>
>> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>
>> ---
>> Should I also replace ')(' with ') (' as it is in the second code block?
>> It would improve readability in my opinion.
>
> Dunno, at least I'm used to the way which is written here :)
I agree - this looks typical to me.
>
> Honza
>
>> ---
>> Documentation/filesystems/locking.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
>> index 844d65eb4..1598cf555 100644
>> --- a/Documentation/filesystems/locking.rst
>> +++ b/Documentation/filesystems/locking.rst
>> @@ -27,7 +27,7 @@ prototypes::
>> int (*d_init)(struct dentry *);
>> void (*d_release)(struct dentry *);
>> void (*d_iput)(struct dentry *, struct inode *);
>> - char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
>> + char *(*d_dname)(struct dentry *dentry, char *buffer, int buflen);
>> struct vfsmount *(*d_automount)(struct path *path);
>> int (*d_manage)(const struct path *, bool);
>> struct dentry *(*d_real)(struct dentry *, enum d_real_type type);
>> --
>> 2.54.0
>>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: locking: Fix bracket
2026-09-02 14:39 [PATCH] docs: locking: Fix bracket Manuel Ebner
2026-09-02 14:58 ` Jan Kara
@ 2026-09-07 16:43 ` Jonathan Corbet
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2026-09-07 16:43 UTC (permalink / raw)
To: Manuel Ebner, Matthew Wilcox (Oracle), Jan Kara, Shuah Khan
Cc: Manuel Ebner, linux-fsdevel, linux-mm, linux-doc, linux-kernel
Manuel Ebner <manuelebnerli@mailbox.org> writes:
> Remove needless '(' from code block.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Should I also replace ')(' with ') (' as it is in the second code block?
> It would improve readability in my opinion.
> ---
> Documentation/filesystems/locking.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> index 844d65eb4..1598cf555 100644
> --- a/Documentation/filesystems/locking.rst
> +++ b/Documentation/filesystems/locking.rst
> @@ -27,7 +27,7 @@ prototypes::
> int (*d_init)(struct dentry *);
> void (*d_release)(struct dentry *);
> void (*d_iput)(struct dentry *, struct inode *);
> - char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
> + char *(*d_dname)(struct dentry *dentry, char *buffer, int buflen);
> struct vfsmount *(*d_automount)(struct path *path);
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-07 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02 14:39 [PATCH] docs: locking: Fix bracket Manuel Ebner
2026-09-02 14:58 ` Jan Kara
2026-09-02 17:13 ` Randy Dunlap
2026-09-07 16:43 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox