Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>, kaitao.cheng@linux.dev
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
	akpm@linux-foundation.org, vbabka@kernel.org,
	linmiaohe@huawei.com, nao.horiguchi@gmail.com, ziy@nvidia.com,
	wangkefeng.wang@huawei.com, tujinjiang@huawei.com,
	mgorman@techsingularity.net, chengkaitao@kylinos.cn,
	muchun.song@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/compaction: skip folios containing hwpoisoned pages
Date: Mon, 26 Oct 2026 10:51:47 +0100	[thread overview]
Message-ID: <916c7258-5b2f-438f-b59b-db9dde28889e@kernel.org> (raw)
In-Reply-To: <20261026025747.1432066-1-xiangzao@linux.alibaba.com>

On 10/26/26 03:57, Yuanhe Shu wrote:
> On 10/22/26 20:39, Kaitao Cheng wrote:
>> Here are a few subtle corner cases I came up with. They may be
>> extremely unlikely to occur.
> 
> Both cases set the flag while the memcpy still succeeds - that is
> the "how this makes sense" for checking after the copy: a check
> before it misses them, the recheck after it catches both, and the
> refusal is the same either way (the data is still good in case A,
> already bad in case B).  What no flag check, before or after, can
> catch is corruption whose hardware report lands after the last
> check; that needs architecture support, as David noted.

Yes. And you really want to avoid reading corrupt data an triggering some
undesired HW reaction (MCE )etc.

> 
> The migration paths spell out the same placement and races in v2
> (patch 2, just posted), and the fallback patch ("mm/highmem: refuse
> to copy hwpoisoned folios in the !copy_mc fallbacks") is posted as
> well, with the races in its changelog.

Sorry, which patches did you post? Do you have a link? Do the supersede
both patches here?
-- 
Cheers,

David


  reply	other threads:[~2026-10-26  9:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 10:58 [PATCH 0/2] mm: don't migrate folios containing hwpoisoned pages Yuanhe Shu
2026-09-28 10:58 ` [PATCH 1/2] mm/compaction: skip " Yuanhe Shu
2026-09-28 12:12   ` David Hildenbrand (Arm)
2026-09-29  3:41     ` Yuanhe Shu
2026-10-11 13:14       ` Huang, Ying
2026-10-20  7:16         ` Yuanhe Shu
2026-10-20  7:52         ` David Hildenbrand (Arm)
2026-10-20 11:27         ` Kaitao Cheng
2026-10-20 13:07           ` David Hildenbrand (Arm)
2026-10-20 13:31             ` Kaitao Cheng
2026-10-20 13:58               ` David Hildenbrand (Arm)
2026-10-21  2:49                 ` Kaitao Cheng
2026-10-21  8:27                   ` David Hildenbrand (Arm)
2026-10-22 12:38                     ` Kaitao Cheng
2026-10-26  2:57                       ` Yuanhe Shu
2026-10-26  9:51                         ` David Hildenbrand (Arm) [this message]
2026-10-10  8:35     ` Kaitao Cheng
2026-09-28 10:58 ` [PATCH 2/2] mm/migrate: refuse to migrate " Yuanhe Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=916c7258-5b2f-438f-b59b-db9dde28889e@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chengkaitao@kylinos.cn \
    --cc=kaitao.cheng@linux.dev \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=muchun.song@linux.dev \
    --cc=nao.horiguchi@gmail.com \
    --cc=tujinjiang@huawei.com \
    --cc=vbabka@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=xiangzao@linux.alibaba.com \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox