Re: [PATCH v2 2/5] proc/task_mmu: remove unnecessary inlines in function definitions

[Suren Baghdasaryan <surenb@google.com>]

On Mon, Sep 7, 2026 at 9:49 AM Usama Arif <usama.arif@linux.dev> wrote:
>
> On Sun,  6 Sep 2026 23:39:15 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
>
> > It was pointed out in the previous reviews of this code that many
> > functions are specified as inline, which is unnecessary as the compile
> > can make that decision by itself. Cleanup these definitions.
> >
> > No functional change intended.
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> > ---
> >  fs/proc/task_mmu.c | 32 ++++++++++++++++----------------
> >  1 file changed, 16 insertions(+), 16 deletions(-)
>
> Most of these functions would be inlined anyways so should be ok.
>
> Curious if there was a change in binary size with this?

No change whatsoever:

W/o this patch:
   text   data    bss    dec    hex filename
31321399 9024030 1127028 41472457 278d1c9 vmlinux

With this patch:
   text   data    bss    dec    hex filename
31321399 9024030 1127028 41472457 278d1c9 vmlinux


>
> Acked-by: Usama Arif <usama.arif@linux.dev>
>
> >
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index 2f500d639db5..9908ba32f180 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> > @@ -130,7 +130,7 @@ static void release_task_mempolicy(struct proc_maps_private *priv)
> >  }
> >  #endif
> >
> > -static inline int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
> > +static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
> >  {
> >       int ret = mmap_read_lock_killable(lock_ctx->mm);
> >
> > @@ -140,7 +140,7 @@ static inline int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
> >       return ret;
> >  }
> >
> > -static inline void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
> > +static void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx)
> >  {
> >       mmap_read_unlock(lock_ctx->mm);
> >       lock_ctx->mmap_locked = false;
> > @@ -177,7 +177,7 @@ static struct vm_area_struct *get_next_vma(struct proc_maps_private *priv,
> >       return vma;
> >  }
> >
> > -static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv,
> > +static bool fallback_to_mmap_lock(struct proc_maps_private *priv,
> >                                        loff_t pos)
> >  {
> >       struct proc_maps_locking_ctx *lock_ctx = &priv->lock_ctx;
> > @@ -194,7 +194,7 @@ static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv,
> >       return true;
> >  }
> >
> > -static inline void drop_rcu(struct proc_maps_private *priv)
> > +static void drop_rcu(struct proc_maps_private *priv)
> >  {
> >       if (priv->lock_ctx.mmap_locked)
> >               return;
> > @@ -202,7 +202,7 @@ static inline void drop_rcu(struct proc_maps_private *priv)
> >       rcu_read_unlock();
> >  }
> >
> > -static inline void reacquire_rcu(struct proc_maps_private *priv)
> > +static void reacquire_rcu(struct proc_maps_private *priv)
> >  {
> >       if (priv->lock_ctx.mmap_locked)
> >               return;
> > @@ -1230,7 +1230,7 @@ static const struct mm_walk_ops smaps_shmem_walk_vma_lock_ops = {
> >       .walk_lock              = PGWALK_VMA_RDLOCK_VERIFY,
> >  };
> >
> > -static inline const struct mm_walk_ops *
> > +static const struct mm_walk_ops *
> >  get_smaps_walk_ops(struct proc_maps_private *priv)
> >  {
> >       if (priv->lock_ctx.mmap_locked)
> > @@ -1238,7 +1238,7 @@ get_smaps_walk_ops(struct proc_maps_private *priv)
> >       return &smaps_walk_vma_lock_ops;
> >  }
> >
> > -static inline const struct mm_walk_ops *
> > +static const struct mm_walk_ops *
> >  get_smaps_shmem_walk_ops(struct proc_maps_private *priv)
> >  {
> >       if (priv->lock_ctx.mmap_locked)
> > @@ -1572,7 +1572,7 @@ struct clear_refs_private {
> >       enum clear_refs_types type;
> >  };
> >
> > -static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte)
> > +static bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte)
> >  {
> >       struct folio *folio;
> >
> > @@ -1588,8 +1588,8 @@ static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr,
> >       return folio_maybe_dma_pinned(folio);
> >  }
> >
> > -static inline void clear_soft_dirty(struct vm_area_struct *vma,
> > -             unsigned long addr, pte_t *pte)
> > +static void clear_soft_dirty(struct vm_area_struct *vma, unsigned long addr,
> > +                          pte_t *pte)
> >  {
> >       if (!pgtable_supports_soft_dirty())
> >               return;
> > @@ -1620,8 +1620,8 @@ static inline void clear_soft_dirty(struct vm_area_struct *vma,
> >  }
> >
> >  #if defined(CONFIG_TRANSPARENT_HUGEPAGE)
> > -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
> > -             unsigned long addr, pmd_t *pmdp)
> > +static void clear_soft_dirty_pmd(struct vm_area_struct *vma,
> > +                              unsigned long addr, pmd_t *pmdp)
> >  {
> >       pmd_t old, pmd = *pmdp;
> >
> > @@ -1646,8 +1646,8 @@ static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
> >       }
> >  }
> >  #else
> > -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
> > -             unsigned long addr, pmd_t *pmdp)
> > +static void clear_soft_dirty_pmd(struct vm_area_struct *vma,
> > +                              unsigned long addr, pmd_t *pmdp)
> >  {
> >  }
> >  #endif
> > @@ -1846,7 +1846,7 @@ struct pagemapread {
> >
> >  #define PM_END_OF_BUFFER    1
> >
> > -static inline pagemap_entry_t make_pme(u64 frame, u64 flags)
> > +static pagemap_entry_t make_pme(u64 frame, u64 flags)
> >  {
> >       return (pagemap_entry_t) { .pme = (frame & PM_PFRAME_MASK) | flags };
> >  }
> > @@ -3388,7 +3388,7 @@ static const struct mm_walk_ops show_numa_vma_lock_ops = {
> >       .walk_lock = PGWALK_VMA_RDLOCK_VERIFY,
> >  };
> >
> > -static inline const struct mm_walk_ops *
> > +static const struct mm_walk_ops *
> >  get_show_numa_ops(struct proc_maps_private *priv)
> >  {
> >       if (priv->lock_ctx.mmap_locked)
> > --
> > 2.55.0.979.g7e5102b832-goog
> >
> >