* FAILED: Patch "mm/page_alloc: clear page->private in free_pages_prepare()" failed to apply to 6.6-stable tree
@ 2026-03-01 1:38 Sasha Levin
2026-05-29 5:02 ` [PATCH] mm/page_alloc: clear page->private in free_pages_prepare() Li Wang
0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2026-03-01 1:38 UTC (permalink / raw)
To: stable, mikhail.v.gavrilov
Cc: Zi Yan, David Hildenbrand (Arm), Vlastimil Babka, Brendan Jackman,
Chris Li, Hugh Dickins, Johannes Weiner, Kairui Song,
Matthew Wilcox (Oracle), Michal Hocko, Nicholas Piggin,
Suren Baghdasaryan, Andrew Morton, linux-mm
The patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
Thanks,
Sasha
------------------ original commit in Linus's tree ------------------
From ac1ea219590c09572ed5992dc233bbf7bb70fef9 Mon Sep 17 00:00:00 2001
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Date: Sat, 7 Feb 2026 22:36:14 +0500
Subject: [PATCH] mm/page_alloc: clear page->private in free_pages_prepare()
Several subsystems (slub, shmem, ttm, etc.) use page->private but don't
clear it before freeing pages. When these pages are later allocated as
high-order pages and split via split_page(), tail pages retain stale
page->private values.
This causes a use-after-free in the swap subsystem. The swap code uses
page->private to track swap count continuations, assuming freshly
allocated pages have page->private == 0. When stale values are present,
swap_count_continued() incorrectly assumes the continuation list is valid
and iterates over uninitialized page->lru containing LIST_POISON values,
causing a crash:
KASAN: maybe wild-memory-access in range [0xdead000000000100-0xdead000000000107]
RIP: 0010:__do_sys_swapoff+0x1151/0x1860
Fix this by clearing page->private in free_pages_prepare(), ensuring all
freed pages have clean state regardless of previous use.
Link: https://lkml.kernel.org/r/20260207173615.146159-1-mikhail.v.gavrilov@gmail.com
Fixes: 3b8000ae185c ("mm/vmalloc: huge vmalloc backing pages should be split rather than compound")
Signed-off-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Suggested-by: Zi Yan <ziy@nvidia.com>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Brendan Jackman <jackmanb@google.com>
Cc: Chris Li <chrisl@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kairui Song <ryncsn@gmail.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e4104973e22fd..77dcec36946f0 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1429,6 +1429,7 @@ __always_inline bool free_pages_prepare(struct page *page,
page_cpupid_reset_last(page);
page->flags.f &= ~PAGE_FLAGS_CHECK_AT_PREP;
+ page->private = 0;
reset_page_owner(page, order);
page_table_check_free(page, order);
pgalloc_tag_sub(page, 1 << order);
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] mm/page_alloc: clear page->private in free_pages_prepare()
2026-03-01 1:38 FAILED: Patch "mm/page_alloc: clear page->private in free_pages_prepare()" failed to apply to 6.6-stable tree Sasha Levin
@ 2026-05-29 5:02 ` Li Wang
2026-05-29 16:28 ` Brendan Jackman
0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2026-05-29 5:02 UTC (permalink / raw)
To: sashal
Cc: akpm, chrisl, david, hannes, hughd, jackmanb, linux-mm, mhocko,
mikhail.v.gavrilov, npiggin, ryncsn, stable, surenb, vbabka,
willy, ziy
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
[commit ac1ea219590c09572ed5992dc233bbf7bb70fef9 upstream]
Several subsystems (slub, shmem, ttm, etc.) use page->private but don't
clear it before freeing pages. When these pages are later allocated as
high-order pages and split via split_page(), tail pages retain stale
page->private values.
This causes a use-after-free in the swap subsystem. The swap code uses
page->private to track swap count continuations, assuming freshly
allocated pages have page->private == 0. When stale values are present,
swap_count_continued() incorrectly assumes the continuation list is valid
and iterates over uninitialized page->lru containing LIST_POISON values,
causing a crash:
KASAN: maybe wild-memory-access in range [0xdead000000000100-0xdead000000000107]
RIP: 0010:__do_sys_swapoff+0x1151/0x1860
Fix this by clearing page->private in free_pages_prepare(), ensuring all
freed pages have clean state regardless of previous use.
Link: https://lkml.kernel.org/r/20260207173615.146159-1-mikhail.v.gavrilov@gmail.com
Fixes: 3b8000ae185c ("mm/vmalloc: huge vmalloc backing pages should be split rather than compound")
Signed-off-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Suggested-by: Zi Yan <ziy@nvidia.com>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Brendan Jackman <jackmanb@google.com>
Cc: Chris Li <chrisl@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kairui Song <ryncsn@gmail.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[backport: context only]
Signed-off-by: Li Wang <li.wang@windriver.com>
---
mm/page_alloc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b617fb364b15..ffdc71103c2a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1178,6 +1178,7 @@ static __always_inline bool free_pages_prepare(struct page *page,
page_cpupid_reset_last(page);
page->flags &= ~PAGE_FLAGS_CHECK_AT_PREP;
+ page->private = 0;
reset_page_owner(page, order);
page_table_check_free(page, order);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_alloc: clear page->private in free_pages_prepare()
2026-05-29 5:02 ` [PATCH] mm/page_alloc: clear page->private in free_pages_prepare() Li Wang
@ 2026-05-29 16:28 ` Brendan Jackman
0 siblings, 0 replies; 3+ messages in thread
From: Brendan Jackman @ 2026-05-29 16:28 UTC (permalink / raw)
To: Li Wang, sashal
Cc: akpm, chrisl, david, hannes, hughd, jackmanb, linux-mm, mhocko,
mikhail.v.gavrilov, npiggin, ryncsn, stable, surenb, vbabka,
willy, ziy, melotti
On Fri May 29, 2026 at 5:02 AM UTC, Li Wang wrote:
> From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
>
> [commit ac1ea219590c09572ed5992dc233bbf7bb70fef9 upstream]
Thanks Li!
Sasha, this version also applies to 6.12, can we apply it there too?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-29 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-01 1:38 FAILED: Patch "mm/page_alloc: clear page->private in free_pages_prepare()" failed to apply to 6.6-stable tree Sasha Levin
2026-05-29 5:02 ` [PATCH] mm/page_alloc: clear page->private in free_pages_prepare() Li Wang
2026-05-29 16:28 ` Brendan Jackman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox