From: Andy Shevchenko <andy@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hongbo Li <lihongbo22@huawei.com>,
kees@kernel.org, trondmy@kernel.org, anna@kernel.org,
gregkh@linuxfoundation.org, linux-hardening@vger.kernel.org,
linux-mm@kvack.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper
Date: Wed, 28 Aug 2024 15:59:38 +0300 [thread overview]
Message-ID: <Zs8fOjcHcsjZXR5a@smile.fi.intel.com> (raw)
In-Reply-To: <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org>
On Tue, Aug 27, 2024 at 04:42:18PM -0700, Andrew Morton wrote:
> On Tue, 27 Aug 2024 10:45:15 +0800 Hongbo Li <lihongbo22@huawei.com> wrote:
...
> > +#define str_false_true(v) str_true_false(!(v))
> This might result in copies of the strings "true" and "false" being
> generated for every .c file which uses this function, resulting in
> unnecessary bloat.
>
> It's possible that the compiler/linker can eliminate this duplication.
> If not, I suggest that every function in string_choices.h be uninlined.
From this perspective this patch doesn't change anything.
The function is inline and in the same compilation module the linker will
optimise away the duplicates (note as well that this is kinda new feature,
some relatively old GCC might not have this feature, but I'm not an expert
in the area).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-28 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:45 [PATCH -next v3 0/3] Add str_true_false()/str_false_true() helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 1/3] lib/string_choices: " Hongbo Li
2024-08-27 23:42 ` Andrew Morton
2024-08-28 1:48 ` Hongbo Li
2024-08-28 3:22 ` Andrew Morton
2024-08-28 3:49 ` Hongbo Li
2024-08-28 20:25 ` Andrew Morton
2024-08-29 1:12 ` Hongbo Li
2024-09-05 16:51 ` (subset) " Kees Cook
2024-08-28 12:59 ` Andy Shevchenko [this message]
2024-08-27 2:45 ` [PATCH -next v3 2/3] mm: make use of str_true_false helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 3/3] nfs make use of str_false_true helper Hongbo Li
2024-08-27 3:33 ` Matthew Wilcox
2024-08-27 6:15 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs8fOjcHcsjZXR5a@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox