* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
@ 2026-04-22 12:45 ` Lorenzo Stoakes
2026-04-22 15:43 ` David Hildenbrand (Arm)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Stoakes @ 2026-04-22 12:45 UTC (permalink / raw)
To: Pedro Falcato
Cc: Andrew Morton, linux-mm, Vlastimil Babka, David Hildenbrand,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Liam R . Howlett
On Wed, Apr 22, 2026 at 01:37:26PM +0100, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
>
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
>
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
>
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
LGTM, so:
Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>
> ---
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d25342ca8aa1..224c15299acc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16804,7 +16804,7 @@ F: mm/sparse.c
> F: mm/util.c
> F: mm/vmpressure.c
> F: mm/vmstat.c
> -N: include/linux/page[-_]*
> +N: include\/linux\/page[-_][a-zA-Z]*
>
> MEMORY MANAGEMENT - EXECMEM
> M: Andrew Morton <akpm@linux-foundation.org>
> @@ -16961,6 +16961,7 @@ S: Maintained
> F: include/linux/compaction.h
> F: include/linux/gfp.h
> F: include/linux/page-isolation.h
> +F: include/linux/pageblock-flags.h
> F: mm/compaction.c
> F: mm/debug_page_alloc.c
> F: mm/debug_page_ref.c
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
2026-04-22 12:45 ` Lorenzo Stoakes
@ 2026-04-22 15:43 ` David Hildenbrand (Arm)
2026-04-22 16:40 ` Vlastimil Babka (SUSE)
2026-04-23 0:32 ` SeongJae Park
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand (Arm) @ 2026-04-22 15:43 UTC (permalink / raw)
To: Pedro Falcato, Andrew Morton
Cc: linux-mm, Vlastimil Babka, Lorenzo Stoakes, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Liam R . Howlett
On 4/22/26 14:37, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
>
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
Nice
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
2026-04-22 12:45 ` Lorenzo Stoakes
2026-04-22 15:43 ` David Hildenbrand (Arm)
@ 2026-04-22 16:40 ` Vlastimil Babka (SUSE)
2026-04-23 0:32 ` SeongJae Park
3 siblings, 0 replies; 5+ messages in thread
From: Vlastimil Babka (SUSE) @ 2026-04-22 16:40 UTC (permalink / raw)
To: Pedro Falcato, Andrew Morton
Cc: linux-mm, David Hildenbrand, Lorenzo Stoakes, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Liam R . Howlett
On 4/22/26 14:37, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
>
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
>
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
>
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d25342ca8aa1..224c15299acc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16804,7 +16804,7 @@ F: mm/sparse.c
> F: mm/util.c
> F: mm/vmpressure.c
> F: mm/vmstat.c
> -N: include/linux/page[-_]*
> +N: include\/linux\/page[-_][a-zA-Z]*
>
> MEMORY MANAGEMENT - EXECMEM
> M: Andrew Morton <akpm@linux-foundation.org>
> @@ -16961,6 +16961,7 @@ S: Maintained
> F: include/linux/compaction.h
> F: include/linux/gfp.h
> F: include/linux/page-isolation.h
> +F: include/linux/pageblock-flags.h
> F: mm/compaction.c
> F: mm/debug_page_alloc.c
> F: mm/debug_page_ref.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
` (2 preceding siblings ...)
2026-04-22 16:40 ` Vlastimil Babka (SUSE)
@ 2026-04-23 0:32 ` SeongJae Park
3 siblings, 0 replies; 5+ messages in thread
From: SeongJae Park @ 2026-04-23 0:32 UTC (permalink / raw)
To: Pedro Falcato
Cc: SeongJae Park, Andrew Morton, linux-mm, Vlastimil Babka,
David Hildenbrand, Lorenzo Stoakes, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Liam R . Howlett
On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <pfalcato@suse.de> wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
>
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
>
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
>
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
Just thinking loud. I was initially wondering the purpose of this link. Seems
this was added to show the example of pagemap.h touching patch that can
dmonstrate how many CC can be reduced. I once thought about suggesting to add
the number or the context on the description, but realize it is too trivial.
So just thinking loud.
$ # Without this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
13
$ # With this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
6
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread