[PATCH] mm/cma: fix stray newline in auto-generated CMA area name

[PATCH] mm/cma: fix stray newline in auto-generated CMA area name

[Ivy Lopez]

When no explicit name is provided, cma_new_area() falls back to
generating one via snprintf(), but the format string contains an
embedded newline: "cma%d\n". This name is used as-is for the area's
sysfs entry (cma_sysfs.c) and debugfs directory (cma_debug.c), so
every auto-named CMA area ends up with a newline embedded in its
sysfs/debugfs name.

Drop the stray newline and the extra space after the size argument.

Signed-off-by: Ivy Lopez <skunkolee@gmail.com>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index a13ce4999b39..092cbb8f27ec 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -240,7 +240,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
 	if (name)
 		strscpy(cma->name, name);
 	else
-		snprintf(cma->name, CMA_MAX_NAME,  "cma%d\n", cma_area_count);
+		snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count);
 
 	cma->available_count = cma->count = size >> PAGE_SHIFT;
 	cma->order_per_bit = order_per_bit;
-- 
2.55.0

Re: [PATCH] mm/cma: fix stray newline in auto-generated CMA area name

[David Hildenbrand (Arm)]

On 8/11/26 02:34, Ivy Lopez wrote:
> When no explicit name is provided, cma_new_area() falls back to
> generating one via snprintf(), but the format string contains an
> embedded newline: "cma%d\n". This name is used as-is for the area's
> sysfs entry (cma_sysfs.c) and debugfs directory (cma_debug.c), so
> every auto-named CMA area ends up with a newline embedded in its
> sysfs/debugfs name.
> 
> Drop the stray newline and the extra space after the size argument.
> 
> Signed-off-by: Ivy Lopez <skunkolee@gmail.com>
> ---
>  mm/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index a13ce4999b39..092cbb8f27ec 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -240,7 +240,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
>  	if (name)
>  		strscpy(cma->name, name);
>  	else
> -		snprintf(cma->name, CMA_MAX_NAME,  "cma%d\n", cma_area_count);
> +		snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count);
>  
>  	cma->available_count = cma->count = size >> PAGE_SHIFT;
>  	cma->order_per_bit = order_per_bit;

Hi,

please see

https://lore.kernel.org/r/20260810093215.91419-1-hongfu.li@linux.dev

-- 
Cheers,

David