From: Lorenzo Stoakes <ljs@kernel.org>
To: ranxiaokai627@163.com
Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
hughd@google.com, leitao@debian.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ran.xiaokai@zte.com.cn
Subject: Re: [PATCH v2 1/2] mm: huge_memory: refactor thpsize_shmem_enabled_store() with sysfs_match_string()
Date: Fri, 22 May 2026 14:04:02 +0100 [thread overview]
Message-ID: <ahBQ59peQvHYfAOD@lucifer> (raw)
In-Reply-To: <20260520102922.63737-1-ranxiaokai627@163.com>
On Wed, May 20, 2026 at 10:29:22AM +0000, ranxiaokai627@163.com wrote:
> >On Thu, 14 May 2026 09:26:39 +0000 ranxiaokai627@163.com wrote:
> >
> >> Thanks for the detailed and thoughtful review! I'll fix this as
> >> suggested in the next version.
> >
> >AI review is asking about a couple of atomicity issues - please check it out?
> > https://sashiko.dev/#/patchset/20260513094508.50888-1-ranxiaokai627@163.com
>
> The huge_shmem_orders_xxx global variables are of type unsigned long,
> which is 32-bit even on 32-bit systems. There is no reason for the
> store in __test_and_set_bit() to be split into two instructions,
> so I do not think this introduces a torn write issue.
Yep agreed, this doesn't look like a real issue.
>
> David also mentioned this optimization here:
> https://lore.kernel.org/all/4f2abf42-983f-4cc2-92f5-c81827e7b7e2@kernel.org/
>
Yup, I think it's fine as is!
Thanks, Lorenzo
next prev parent reply other threads:[~2026-05-22 13:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260518110816.79be9a7c71777c1876b0019d@linux-foundation.org>
2026-05-20 10:29 ` [PATCH v2 1/2] mm: huge_memory: refactor thpsize_shmem_enabled_store() with sysfs_match_string() ranxiaokai627
2026-05-22 13:04 ` Lorenzo Stoakes [this message]
2026-05-13 9:45 ranxiaokai627
2026-05-14 2:36 ` Baolin Wang
2026-05-14 10:10 ` ranxiaokai627
2026-05-14 12:05 ` Lorenzo Stoakes
2026-05-14 8:33 ` Breno Leitao
2026-05-14 9:26 ` ranxiaokai627
2026-05-14 12:48 ` Lorenzo Stoakes
2026-05-15 6:21 ` ranxiaokai627
2026-05-15 7:23 ` ranxiaokai627
2026-05-15 11:34 ` Lorenzo Stoakes
2026-05-18 2:02 ` ranxiaokai627
2026-05-18 11:16 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahBQ59peQvHYfAOD@lucifer \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hughd@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=ranxiaokai627@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox