From: Lorenzo Stoakes <ljs@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Anthony Yznaga <anthony.yznaga@oracle.com>,
Mark Brown <broonie@kernel.org>,
Sarthak Sharma <sarthak.sharma@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aishwarya TCV <Aishwarya.TCV@arm.com>
Subject: Re: [PATCH] selftests: mm: fix and speedup "droppable" test
Date: Fri, 12 Jun 2026 09:26:59 +0100 [thread overview]
Message-ID: <aivCvvj_Ztezkrie@lucifer> (raw)
In-Reply-To: <2cf7bff8-1681-4344-8bbc-16bf4306ade3@kernel.org>
On Fri, Jun 12, 2026 at 10:00:29AM +0200, David Hildenbrand (Arm) wrote:
> >> tools/testing/selftests/mm/droppable.c | 46 +++++++++++++++++++---------------
> >> 1 file changed, 26 insertions(+), 20 deletions(-)
> >>
> >> diff --git a/tools/testing/selftests/mm/droppable.c b/tools/testing/selftests/mm/droppable.c
> >> index 30c8be37fcb9..57e1b6fc5569 100644
> >> --- a/tools/testing/selftests/mm/droppable.c
> >> +++ b/tools/testing/selftests/mm/droppable.c
> >> @@ -17,10 +17,10 @@
> >>
> >> int main(int argc, char *argv[])
> >> {
> >> - size_t alloc_size = 134217728;
> >> - size_t page_size = getpagesize();
> >> + const size_t alloc_size = 2 * 1024 * 1024;
> >
> > I guess regardless of page size this suffices as an arbitrary range over which
> > to check things work.
>
> Yes, that was my thinking. "some pages".
>
> I was briefly wondering whether to add separate tests for THP vs. !THP, but
> decided to leave that for another day :)
Yeah we (or Claude ;) can expand and extend later, key thing here is to get the
slowness sorted... :)
>
> --
> Cheers,
>
> David
Cheers, Lorenzo
prev parent reply other threads:[~2026-06-12 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:01 [PATCH] selftests: mm: fix and speedup "droppable" test David Hildenbrand (Arm)
2026-06-11 11:07 ` Sarthak Sharma
2026-06-11 11:26 ` David Hildenbrand (Arm)
2026-06-11 11:32 ` Lance Yang
2026-06-11 12:13 ` Sarthak Sharma
2026-06-11 11:15 ` Lance Yang
2026-06-11 11:19 ` Dev Jain
2026-06-11 11:26 ` David Hildenbrand (Arm)
2026-06-11 11:28 ` Dev Jain
2026-06-12 1:29 ` SeongJae Park
2026-06-12 7:35 ` David Hildenbrand (Arm)
2026-06-12 7:58 ` Lorenzo Stoakes
2026-06-12 8:00 ` David Hildenbrand (Arm)
2026-06-12 8:26 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aivCvvj_Ztezkrie@lucifer \
--to=ljs@kernel.org \
--cc=Aishwarya.TCV@arm.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=broonie@kernel.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox