* [PATCH] arch_numa: remove redundant nodemask clears in numa_init()
@ 2026-06-17 16:39 Sang-Heon Jeon
2026-06-18 9:58 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Sang-Heon Jeon @ 2026-06-17 16:39 UTC (permalink / raw)
To: rppt, akpm, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich
Cc: linux-mm, Sang-Heon Jeon, driver-core, linux-kernel
numa_init() clears numa_nodes_parsed, node_possible_map and
node_online_map, then calls numa_memblks_init(), which clears the same
nodemasks. Nothing uses them in between.
These clears have been redundant since commit 767507654c22 ("arch_numa:
switch over to numa_memblks") made numa_init() use numa_memblks_init().
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/base/arch_numa.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c
index c99f2ab105e5..442ea239bba7 100644
--- a/drivers/base/arch_numa.c
+++ b/drivers/base/arch_numa.c
@@ -231,10 +231,6 @@ static int __init numa_init(int (*init_func)(void))
{
int ret;
- nodes_clear(numa_nodes_parsed);
- nodes_clear(node_possible_map);
- nodes_clear(node_online_map);
-
ret = numa_memblks_init(init_func, /* memblock_force_top_down */ false);
if (ret < 0)
goto out_free_distance;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch_numa: remove redundant nodemask clears in numa_init()
2026-06-17 16:39 [PATCH] arch_numa: remove redundant nodemask clears in numa_init() Sang-Heon Jeon
@ 2026-06-18 9:58 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2026-06-18 9:58 UTC (permalink / raw)
To: Sang-Heon Jeon
Cc: akpm, Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
linux-mm, driver-core, linux-kernel
On Thu, Jun 18, 2026 at 01:39:19AM +0900, Sang-Heon Jeon wrote:
> numa_init() clears numa_nodes_parsed, node_possible_map and
> node_online_map, then calls numa_memblks_init(), which clears the same
> nodemasks. Nothing uses them in between.
>
> These clears have been redundant since commit 767507654c22 ("arch_numa:
> switch over to numa_memblks") made numa_init() use numa_memblks_init().
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> drivers/base/arch_numa.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c
> index c99f2ab105e5..442ea239bba7 100644
> --- a/drivers/base/arch_numa.c
> +++ b/drivers/base/arch_numa.c
> @@ -231,10 +231,6 @@ static int __init numa_init(int (*init_func)(void))
> {
> int ret;
>
> - nodes_clear(numa_nodes_parsed);
> - nodes_clear(node_possible_map);
> - nodes_clear(node_online_map);
> -
> ret = numa_memblks_init(init_func, /* memblock_force_top_down */ false);
> if (ret < 0)
> goto out_free_distance;
> --
> 2.43.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-18 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 16:39 [PATCH] arch_numa: remove redundant nodemask clears in numa_init() Sang-Heon Jeon
2026-06-18 9:58 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox